chromium/src
0
Fork 0
Code Activity

[rust] Add more UNSAFE_RUST_OWNERS + tweak related documentation.

Browse Source 
Bug: 393410747
Change-Id: I10f8c71f40f001d25a4a1a3c746d112da5ba22b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279505
Reviewed-by: Liza Burakova <liza@chromium.org>
Reviewed-by: Dustin Mitchell <djmitche@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422092}
This commit is contained in:
Lukasz Anforowicz
2025-02-19 11:07:58 -08:00
committed by Chromium LUCI CQ
parent ce09944110
commit 8174ee0645
2 changed files with 8 additions and 7 deletions

8
docs/rust-unsafe.md

@ -2,9 +2,9 @@
## Code Review Policy {#code-review-policy}
All `unsafe` Rust code in Chromium needs to be reviewed and LGTM-ed by a member
of the `unsafe-rust-in-chrome@google.com` group and the review must be cc'd to
the group for visibility. This policy applies to both third-party code
All `unsafe` Rust code in Chromium needs to be reviewed and LGTM-ed by a
reviewer from `//third_party/rust/UNSAFE_RUST_OWNERS`.
This policy applies to both third-party code
(e.g. under `//third_party/rust`) and first-party code.
### How to request a review
@ -22,7 +22,7 @@ To facilitate a code review please:
Note that changes _anywhere_ in a crate that uses `unsafe` blocks may violate
the internal invariants on which those `unsafe` blocks rely. It is unrealistic
to require a `unsafe-rust-in-chrome@google.com` review to re-audit all the
to require an `unsafe` review to re-audit all the
`unsafe` blocks each time a crate is updated, but the crate `OWNERS` and other
reviewers should be on the lookout for code changes which feel as though they
could affect invariants on which `unsafe` blocks rely.

7
third_party/rust/UNSAFE_RUST_OWNERS vendored

@ -38,8 +38,9 @@ chrome-unsafe-rust-reviews@google.com
# Gerrit will preferentially suggest the gwsq review alias above.
#
# Please keep this list alphabetized and in sync with the gwsq config (see
# go/chrome-ipc-review).
# go/chrome-unsafe-rust-reviews).
dcheng@chromium.org #{LAST_RESORT_SUGGESTION}
djmitche@chromium.org #{LAST_RESORT_SUGGESTION}
liza@chromium.org #{LAST_RESORT_SUGGESTION}
lukasza@chromium.org #{LAST_RESORT_SUGGESTION}
# TODO: Announce gwsq alias to `unsafe-rust-in-chrome@google.com` and add
# other volunteers here.
phao@chromium.org #{LAST_RESORT_SUGGESTION}