0

Migrate TODOs referencing old crbug IDs to the new issue tracker IDs

The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:

- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)

Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.

#crbug-todo-migration

Bug: b/321899722
Change-Id: Iee14d10d544e9f0ec046117cc4ec8a55c427adc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469947
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290838}
This commit is contained in:
Alison Gale
2024-04-22 19:33:31 +00:00
committed by Chromium LUCI CQ
parent 926b04c89f
commit 81f4f2c793
839 changed files with 1334 additions and 1309 deletions
apps/ui/views
base
build
build_overrides
buildtools
reclient_cfgs
third_party
cc
content
app
app_shim_remote_cocoa
browser
accessibility
aggregation_service
back_forward_cache_basics_browsertest.ccback_forward_cache_browsertest.ccback_forward_cache_features_browsertest.ccback_forward_cache_internal_browsertest.ccback_forward_cache_network_request_browsertest.ccback_forward_cache_not_restored_reasons_browsertest.cc
background_fetch
background_sync
browser_main_loop.cc
browser_plugin
browser_thread_browsertest.cc
browsing_data
cache_storage
child_process_launcher_helper_fuchsia.ccchild_process_launcher_helper_linux.ccchild_process_security_policy_impl.cc
client_hints
date_time_chooser
devtools
dom_storage
download
fenced_frame
file_system_access
find_request_manager.ccfind_request_manager_browsertest.ccform_controls_browsertest.cc
generic_sensor
gpu
hid
indexed_db
isolated_origin_browsertest.cc
loader
lock_screen
manifest
media
memory
mojo_sandbox_browsertest.ccnavigation_browsertest.ccnavigation_mhtml_browsertest.cc
network
network_service_instance_impl.cc
notifications
picture_in_picture
pointer_lock_browsertest.cc
preloading
private_aggregation
push_messaging
quota
renderer_host
back_forward_cache_impl.ccback_forward_cache_metrics_unittest.ccblocked_scheme_navigation_browsertest.ccbrowsing_context_state.cccross_process_frame_connector.ccdelegated_frame_host.ccdelegated_frame_host.hdocument_token_browsertest.ccframe_tree.hframe_tree_node.cc
input
media
mixed_content_checker.ccnavigation_controller_android.ccnavigation_controller_impl.ccnavigation_controller_impl_browsertest.ccnavigation_request.ccnavigation_request.hnavigation_request_browsertest.cc
navigation_transitions
navigator.ccpage_impl.ccpage_lifecycle_state_manager.ccproactively_swap_browsing_instances_browsertest.ccrender_frame_host_impl.ccrender_frame_host_impl.hrender_frame_host_impl_browsertest.ccrender_frame_host_impl_interface_binders.ccrender_frame_host_manager.ccrender_frame_host_manager.hrender_frame_host_manager_browsertest.ccrender_frame_proxy_host.ccrender_process_host_impl.ccrender_view_host_impl.ccrender_widget_host_browsertest.ccrender_widget_host_impl.ccrender_widget_host_impl.hrender_widget_host_view_android.ccrender_widget_host_view_aura.ccrender_widget_host_view_aura_browsertest.ccrender_widget_host_view_aura_unittest.ccrender_widget_host_view_base.hrender_widget_host_view_browsertest.ccrender_widget_host_view_child_frame.ccrender_widget_host_view_child_frame.hrender_widget_host_view_child_frame_browsertest.ccrender_widget_host_view_event_handler.ccrender_widget_host_view_mac.mmshould_swap_browsing_instance.hunassigned_site_instance_browsertest.ccvisible_time_request_trigger.h
screenlock_monitor
security
service_worker
site_instance_impl.ccsite_per_process_browsertest.ccsite_per_process_hit_test_browsertest.ccsite_per_process_layout_browsertest.ccsite_per_process_sad_frame_browsertest.cc
sms
speech
storage_service_sandbox_browsertest.cc
tracing
utility_sandbox_delegate.cc
web_contents
web_package
webauth
webrtc
webui
worker_host
xr
child
common
public
renderer
services
auction_worklet
shell
test
web_test
device
docs
extensions
browser
common
renderer
shell
test
data
web_view
apitest
fuchsia_web
gin
google_apis
gpu
headless
infra/config
ipc
media
mojo/public
cpp
interfaces
bindings
java
system
javatests
src
org
chromium
js
tools
net
pdf
printing
remoting
sandbox
services
audio
cert_verifier
device
media_session
network
preferences
resource_coordinator
public
cpp
memory_instrumentation
screen_ai
service_manager
public
tracing
viz
skia
sql
storage/browser
styleguide/c++
testing
ui
url

@ -146,7 +146,7 @@ gfx::Rect AppWindowFrameView::GetBoundsForClientView() const {
gfx::Rect AppWindowFrameView::GetWindowBoundsForClientBounds(
const gfx::Rect& client_bounds) const {
gfx::Rect window_bounds = client_bounds;
// TODO(crbug.com/1052397): Revisit once build flag switch of lacros-chrome is
// TODO(crbug.com/40118868): Revisit once build flag switch of lacros-chrome is
// complete.
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS_LACROS)
// Get the difference between the widget's client area bounds and window

@ -1473,7 +1473,7 @@ component("base") {
# These only need to be public deps because of includes of their headers
# by public //base headers, which requires they be on the include path.
# TODO(https://crbug.com/841171): Move these back to |deps|.
# TODO(crbug.com/40575514): Move these back to |deps|.
public_deps += [
"//third_party/fuchsia-sdk/sdk/fidl/fuchsia.component.runner:fuchsia.component.runner_hlcpp",
"//third_party/fuchsia-sdk/sdk/fidl/fuchsia.intl:fuchsia.intl_hlcpp",
@ -1517,7 +1517,7 @@ component("base") {
# cannot easily depend on BoringSSL due to the nacl_io library, so NaCl builds
# still retain a dedicated local implementation of the functionality.
#
# TODO(crbug.com/702997) Use only boringssl when NaCl is removed.
# TODO(crbug.com/40511454) Use only boringssl when NaCl is removed.
sources += [
"hash/md5.h",
"hash/md5_constexpr.h",
@ -3114,7 +3114,7 @@ if (is_fuchsia) {
sources = [ "fuchsia/test.test-fidl" ]
}
# TODO(crbug.com/1416553): remove this once all users are migrated to natural bindings.
# TODO(crbug.com/40256912): remove this once all users are migrated to natural bindings.
source_set("test_interface_impl") {
testonly = true
sources = [

@ -150,7 +150,7 @@ bool UseMapJit() {
#if TARGET_IPHONE_SIMULATOR
return true;
#else
// TODO(https://crbug.com/1413818): Fill this out when the API it is
// TODO(crbug.com/40255826): Fill this out when the API it is
// available.
return false;
#endif // TARGET_IPHONE_SIMULATOR

@ -290,12 +290,13 @@ public class ApiCompatibilityUtils {
}
/**
* Sets the bottom handwriting bounds offset of the given view to 0.
* See https://crbug.com/1427112
* Sets the bottom handwriting bounds offset of the given view to 0. See
* https://crbug.com/1427112
*
* @param view The view on which to set the handwriting bounds.
*/
public static void clearHandwritingBoundsOffsetBottom(View view) {
// TODO(crbug.com/1427112): Replace uses of this method with direct calls once the API is
// TODO(crbug.com/40261637): Replace uses of this method with direct calls once the API is
// available.
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.UPSIDE_DOWN_CAKE) return;
// Set the bottom handwriting bounds offset to 0 so that the view doesn't intercept

@ -154,7 +154,7 @@ public class BundleUtils {
// The Application class handles locking itself using the split context lock. This is
// necessary to prevent a possible deadlock, since the application waits for splits
// preloading on a background thread.
// TODO(crbug.com/1172950): Consider moving preloading logic into //base so we can lock
// TODO(crbug.com/40745927): Consider moving preloading logic into //base so we can lock
// here.
if (isApplicationContext(base)) {
context = ApiHelperForO.createContextForSplit(base, splitName);

@ -27,7 +27,8 @@ public final class StrictModeContext implements Closeable {
private final StrictMode.VmPolicy mVmPolicy;
private StrictModeContext(StrictMode.ThreadPolicy threadPolicy, StrictMode.VmPolicy vmPolicy) {
// TODO(crbug/1475610): Determine after auditing strict mode context usage if we should keep
// TODO(crbug.com/40279700): Determine after auditing strict mode context usage if we should
// keep
// or remove these trace events.
TraceEvent.startAsync("StrictModeContext", hashCode());
mThreadPolicy = threadPolicy;

@ -118,7 +118,7 @@ public class ChildProcessConnection {
/** The string passed to bindToCaller to identify this class loader. */
@VisibleForTesting
public static String getBindToCallerClazz() {
// TODO(crbug.com/1057102): Have embedder explicitly set separate different strings since
// TODO(crbug.com/40677220): Have embedder explicitly set separate different strings since
// this could still collide in theory.
ClassLoader cl = ChildProcessConnection.class.getClassLoader();
return cl.toString() + cl.hashCode();

@ -33,7 +33,7 @@ namespace {
// uncaught Java exception (historical behavior). If enabled, we give the Java
// uncaught exception handler a chance to handle the exception first, so that
// the crash is (hopefully) seen as a Java crash, not a native crash.
// TODO(https://crbug.com/1426888): remove this switch once we are confident the
// TODO(crbug.com/40261529): remove this switch once we are confident the
// new behavior is fine.
BASE_FEATURE(kHandleExceptionsInJava,
"HandleJniExceptionsInJava",

@ -24,7 +24,7 @@ bool PathProviderFuchsia(int key, FilePath* result) {
*result = base::FilePath(base::kPackageRootDirectoryPath);
return true;
// TODO(crbug.com/1459692): Align with other platforms and remove this
// TODO(crbug.com/40274404): Align with other platforms and remove this
// specialization.
case DIR_GEN_TEST_DATA_ROOT:
[[fallthrough]];

@ -35,7 +35,7 @@ bool ExitedCleanly(int exit_status) {
return exit_status == 0;
}
// TODO(crbug.com/1402267): ASAN death test is not picking up the failure
// TODO(crbug.com/40884672): ASAN death test is not picking up the failure
// in the emulator logs. Disabling to keep ASAN queue clear.
#if BUILDFLAG(IS_FUCHSIA)
#define MAYBE_ErrorCallback DISABLED_ErrorCallback

@ -22,7 +22,7 @@ CrashKeyString* AllocateCrashKeyString(const char name[],
if (!g_crash_key_impl)
return nullptr;
// TODO(https://crbug.com/1341077): It would be great if the DCHECKs below
// TODO(crbug.com/40850825): It would be great if the DCHECKs below
// could also be enabled on Android, but debugging tryjob failures was a bit
// difficult... :-/
#if DCHECK_IS_ON() && !BUILDFLAG(IS_ANDROID)

@ -413,7 +413,7 @@ TEST_F(StackTraceTest, MAYBE_TraceStackFramePointers) {
// This is expected because we're walking and reading the stack, and
// sometimes we read fp / pc from the place that previously held
// uninitialized value.
// TODO(crbug.com/1132511): Enable this test on Fuchsia.
// TODO(crbug.com/40150655): Enable this test on Fuchsia.
#if defined(MEMORY_SANITIZER) || BUILDFLAG(IS_FUCHSIA)
#define MAYBE_TraceStackFramePointersFromBuffer \
DISABLED_TraceStackFramePointersFromBuffer

@ -40,7 +40,7 @@ FileTracing::ScopedEnabler::~ScopedEnabler() {
FileTracing::Provider* provider = GetProvider();
if (provider)
provider->FileTracingDisable(this);
// TODO(crbug.com/1021571): Remove this once fixed.
// TODO(crbug.com/40657156): Remove this once fixed.
PERFETTO_INTERNAL_ADD_EMPTY_EVENT();
}

@ -406,7 +406,7 @@ bool TouchFile(const FilePath& path,
flags |= File::FLAG_WIN_BACKUP_SEMANTICS;
#elif BUILDFLAG(IS_FUCHSIA)
// On Fuchsia, we need O_RDONLY for directories, or O_WRONLY for files.
// TODO(https://crbug.com/947802): Find a cleaner workaround for this.
// TODO(crbug.com/40620916): Find a cleaner workaround for this.
flags |= (DirectoryExists(path) ? File::FLAG_READ : File::FLAG_WRITE);
#endif

@ -293,7 +293,7 @@ BASE_EXPORT bool ReadStreamToStringWithMaxSize(FILE* stream,
// into `buffer`. This function is protected against EINTR and partial reads.
// Returns true iff `buffer` was successfully filled with bytes read from `fd`.
BASE_EXPORT bool ReadFromFD(int fd, span<char> buffer);
// TODO(https://crbug.com/1490484): Migrate callers to the span variant.
// TODO(crbug.com/40284755): Migrate callers to the span variant.
BASE_EXPORT bool ReadFromFD(int fd, char* buffer, size_t bytes);
// Performs the same function as CreateAndOpenTemporaryStreamInDir(), but
@ -456,8 +456,8 @@ BASE_EXPORT void SetDisableSecureSystemTempForTesting(bool disabled);
#endif // BUILDFLAG(IS_WIN)
// Do NOT USE in new code. Use ScopedTempDir instead.
// TODO(crbug.com/561597) Remove existing usage and make this an implementation
// detail inside ScopedTempDir.
// TODO(crbug.com/40446440) Remove existing usage and make this an
// implementation detail inside ScopedTempDir.
//
// Create a new directory. If prefix is provided, the new directory name is in
// the format of prefixyyyy.
@ -566,14 +566,14 @@ BASE_EXPORT std::optional<uint64_t> ReadFile(const FilePath& filename,
span<uint8_t> buffer);
// Same as above, but returns -1 on error.
// TODO(https://crbug.com/1490484): Migrate callers to the span variant.
// TODO(crbug.com/40284755): Migrate callers to the span variant.
BASE_EXPORT int ReadFile(const FilePath& filename, char* data, int max_size);
// Writes the given buffer into the file, overwriting any data that was
// previously there. Returns the number of bytes written, or -1 on error.
// If file doesn't exist, it gets created with read/write permissions for all.
// Note that the other variants of WriteFile() below may be easier to use.
// TODO(https://crbug.com/1490484): Migrate callers to the span variant.
// TODO(crbug.com/40284755): Migrate callers to the span variant.
BASE_EXPORT int WriteFile(const FilePath& filename, const char* data,
int size);

@ -4522,7 +4522,7 @@ TEST_F(FileUtilTest, MAYBE_PreReadFileWithSequentialAccess) {
// thread-safety issues @ https://crbug.com/826408#c17.
TEST(FileUtilMultiThreadedTest, MultiThreadedTempFiles) {
#if BUILDFLAG(IS_FUCHSIA)
// TODO(crbug.com/844416): Too slow to run on infra due to QEMU overhead.
// TODO(crbug.com/40577019): Too slow to run on infra due to QEMU overhead.
constexpr int kNumThreads = 8;
#else
constexpr int kNumThreads = 64;

@ -22,7 +22,7 @@ namespace base {
// FilePath dir(FILE_PATH_LITERAL("foo")); dir.Append(*a);
class BASE_EXPORT SafeBaseName {
public:
// TODO(crbug.com/1269986): Change to only be exposed to Mojo.
// TODO(crbug.com/40205226): Change to only be exposed to Mojo.
SafeBaseName() = default;
// Factory method that returns a valid SafeBaseName or std::nullopt.

@ -27,7 +27,7 @@ constexpr float kAudioSchedulingCapacity = 0.3;
constexpr TimeDelta kDisplaySchedulingPeriod = Seconds(1) / 60;
// Request 50% max CPU deadline utilization for a display thread.
// TODO(crbug.com/1181421): Currently DISPLAY priority is not enabled for any
// TODO(crbug.com/40750845): Currently DISPLAY priority is not enabled for any
// thread on Fuchsia. The value below will need to be fine-tuned when it's
// enabled.
const float kDisplaySchedulingCapacity = 0.5;

@ -27,7 +27,7 @@ class MemoryPressureObserver {
~MemoryPressureObserver() = delete;
void AddObserver(MemoryPressureListener* listener, bool sync) {
// TODO(crbug.com/1063868): DCHECK instead of silently failing when a
// TODO(crbug.com/40123466): DCHECK instead of silently failing when a
// MemoryPressureListener is created in a non-sequenced context. Tests will
// need to be adjusted for that to work.
if (SequencedTaskRunner::HasCurrentDefault()) {

@ -118,7 +118,7 @@ PlatformSharedMemoryRegion PlatformSharedMemoryRegion::Create(Mode mode,
return {};
}
// TODO(crbug.com/991805): Take base::Location from the caller and use it to
// TODO(crbug.com/40639453): Take base::Location from the caller and use it to
// generate the name here.
constexpr char kVmoName[] = "cr-shared-memory-region";
status = vmo.set_property(ZX_PROP_NAME, kVmoName, strlen(kVmoName));

@ -149,9 +149,9 @@ class BASE_EXPORT MessagePump {
// Called before a unit of work is executed. This allows reports
// about individual units of work to be produced. The unit of work ends when
// the returned ScopedDoWorkItem goes out of scope.
// TODO(crbug.com/851163): Place calls for all platforms. Without this, some
// state like the top-level "ThreadController active" trace event will not
// be correct when work is performed.
// TODO(crbug.com/40580088): Place calls for all platforms. Without this,
// some state like the top-level "ThreadController active" trace event will
// not be correct when work is performed.
[[nodiscard]] ScopedDoWorkItem BeginWorkItem() {
return ScopedDoWorkItem(this);
}

@ -964,9 +964,9 @@ void GlobalHistogramAllocator::Set(GlobalHistogramAllocator* allocator) {
// Record the number of histograms that were sampled before the global
// histogram allocator was initialized.
//
// TODO(crbug/1504919): CHECK(histogram_count == 0) and remove emit of early
// histogram count once |histogram_count| is reliably zero (0) for all process
// types.
// TODO(crbug.com/40945497): CHECK(histogram_count == 0) and remove emit of
// early histogram count once |histogram_count| is reliably zero (0) for all
// process types.
size_t histogram_count = StatisticsRecorder::GetHistogramCount();
if (histogram_count != 0) {
DVLOG(1) << histogram_count

@ -59,7 +59,7 @@ NativeLibrary LoadNativeLibraryWithOptions(const FilePath& library_path,
// Use fdio_open_fd (a Fuchsia-specific API) here so we can pass the
// appropriate FS rights flags to request executability.
// TODO(crbug.com/1018538): Teach base::File about FLAG_WIN_EXECUTE on
// TODO(crbug.com/40655456): Teach base::File about FLAG_WIN_EXECUTE on
// Fuchsia, and then use it here instead of using fdio_open_fd() directly.
base::ScopedFD fd;
zx_status_t status = fdio_open_fd(

@ -9,7 +9,7 @@
namespace base {
ProcessIterator::ProcessIterator(const ProcessFilter* filter) {
// TODO(crbug.com/1131239): Implement ProcessIterator on Fuchsia.
// TODO(crbug.com/40721279): Implement ProcessIterator on Fuchsia.
NOTREACHED();
}

@ -431,8 +431,8 @@ void Process::CleanUpProcess(int remaining_retries) const {
}
// Try to delete the cgroup
// TODO(1322562): We can use notify_on_release to automoatically delete the
// cgroup when the process has left the cgroup.
// TODO(crbug.com/40224348): We can use notify_on_release to automoatically
// delete the cgroup when the process has left the cgroup.
FilePath cgroup = CGroups::Get().GetForegroundCgroupDir(unique_token_);
if (!DeleteFile(cgroup)) {
auto saved_errno = errno;

@ -783,7 +783,7 @@ TEST(SystemMetrics2Test, GetSystemMemoryInfo) {
// All the values should be less than the total amount of memory.
#if !BUILDFLAG(IS_WIN) && !BUILDFLAG(IS_IOS)
// TODO(crbug.com/711450): re-enable the following assertion on iOS.
// TODO(crbug.com/40515565): re-enable the following assertion on iOS.
EXPECT_LT(info.free, info.total);
#endif
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS) || BUILDFLAG(IS_ANDROID)

@ -432,7 +432,7 @@ NativeLibrary LoadTestLibrary(std::string_view library_name) {
const auto load = [&](NativeLibrary* library) {
FilePath library_path;
#if BUILDFLAG(IS_FUCHSIA) || BUILDFLAG(IS_IOS)
// TODO(crbug.com/1262430): Find a solution that works across platforms.
// TODO(crbug.com/40799492): Find a solution that works across platforms.
ASSERT_TRUE(PathService::Get(DIR_ASSETS, &library_path));
#else
// The module is next to the test module rather than with test data.

@ -90,7 +90,7 @@ BASE_EXPORT float BitsToOpenEndedUnitIntervalF(uint64_t bits);
// random number source, code outside of base/ that relies on this should use
// crypto::RandBytes instead to ensure the requirement is easily discoverable.
BASE_EXPORT void RandBytes(span<uint8_t> output);
// TODO(https://crbug.com/1490484): Migrate callers to the span version.
// TODO(crbug.com/40284755): Migrate callers to the span version.
BASE_EXPORT void RandBytes(void* output, size_t output_length);
// Creates a vector of `length` bytes, fills it with random data, and returns

@ -33,7 +33,7 @@ namespace {
// Note that this does not support capture groups, so all lambdas defined like
// this must be stateless.
// Example Usage: `CONSTEXPR_LAMBDA((int i, int j) { return i + j; }) lambda;`
// TODO(crbug.com/752720): Remove once we have constexpr lambdas for real.
// TODO(crbug.com/40533712): Remove once we have constexpr lambdas for real.
#define CONSTEXPR_LAMBDA(fun) \
constexpr struct { constexpr bool operator() fun }

@ -80,7 +80,7 @@ void OverflowTestsSoftExpectTrue(bool overflow_detected) {
// - XSan aborts when operator new returns nullptr.
// - PartitionAlloc crashes by design when size_t overflows.
//
// TODO(https://crbug.com/927179): Fix the test on Mac.
// TODO(crbug.com/40611888): Fix the test on Mac.
TEST(SecurityTest, MAYBE_NewOverflow) {
const size_t kArraySize = 4096;
// We want something "dynamic" here, so that the compiler doesn't

@ -7,7 +7,7 @@
// Prevent the optimizer from optimizing away a function call by "using" the
// result.
//
// TODO(crbug.com/1377534): Replace this with a more general solution.
// TODO(crbug.com/40243629): Replace this with a more general solution.
void UseResult(const std::string& input) {
volatile char c;
if (input.length() > 0)

@ -57,7 +57,7 @@ class BASE_EXPORT SyncSocket {
// Same as above, but with the following parameters:
// `buffer` is a pointer to the data to send.
// `length` is the length of the data to send (must be non-zero).
// TODO(https://crbug.com/1490484): Migrate callers to the span version.
// TODO(crbug.com/40284755): Migrate callers to the span version.
virtual size_t Send(const void* buffer, size_t length);
// Receives a message from an SyncSocket.
@ -67,14 +67,14 @@ class BASE_EXPORT SyncSocket {
// Same as above, but with the following parameters:
// `buffer` is a pointer to the buffer to receive data.
// `length` is the number of bytes of data to receive (must be non-zero).
// TODO(https://crbug.com/1490484): Migrate callers to the span version.
// TODO(crbug.com/40284755): Migrate callers to the span version.
virtual size_t Receive(void* buffer, size_t length);
// Same as Receive() but only blocks for data until `timeout` has elapsed or
// `buffer` is exhausted. Currently only timeouts less than one second are
// allowed. Returns the number of bytes read.
virtual size_t ReceiveWithTimeout(span<uint8_t> buffer, TimeDelta timeout);
// TODO(https://crbug.com/1490484): Migrate callers to the span version.
// TODO(crbug.com/40284755): Migrate callers to the span version.
virtual size_t ReceiveWithTimeout(void* buffer,
size_t length,
TimeDelta timeout);
@ -128,10 +128,10 @@ class BASE_EXPORT CancelableSyncSocket : public SyncSocket {
// SyncSocket methods in order to support shutting down the 'socket'.
void Close() override;
size_t Receive(span<uint8_t> buffer) override;
// TODO(https://crbug.com/1490484): Migrate callers to the span version.
// TODO(crbug.com/40284755): Migrate callers to the span version.
size_t Receive(void* buffer, size_t length) override;
size_t ReceiveWithTimeout(span<uint8_t> buffer, TimeDelta timeout) override;
// TODO(https://crbug.com/1490484): Migrate callers to the span version.
// TODO(crbug.com/40284755): Migrate callers to the span version.
size_t ReceiveWithTimeout(void* buffer,
size_t length,
TimeDelta timeout) override;
@ -143,7 +143,7 @@ class BASE_EXPORT CancelableSyncSocket : public SyncSocket {
// SyncSocket::Send will, but instead return 0, as no bytes could be sent.
// Note that the socket will not be closed in this case.
size_t Send(span<const uint8_t> data) override;
// TODO(https://crbug.com/1490484): Migrate callers to the span version.
// TODO(crbug.com/40284755): Migrate callers to the span version.
size_t Send(const void* buffer, size_t length) override;
private:

@ -202,7 +202,7 @@ std::string SysInfo::OperatingSystemArchitecture() {
// static
std::string SysInfo::CPUModelName() {
// TODO(crbug.com/1233859): Implement this when Fuchsia supports it.
// TODO(crbug.com/40191727): Implement this when Fuchsia supports it.
NOTIMPLEMENTED_LOG_ONCE();
return std::string();
}

@ -449,7 +449,7 @@ void ThreadController::RunLevelTracker::RunLevel::UpdateState(
LogOnIdleMetrics(lazy_now);
TRACE_EVENT_END("base", lazy_now.Now());
// TODO(crbug.com/1021571): Remove this once fixed.
// TODO(crbug.com/40657156): Remove this once fixed.
PERFETTO_INTERNAL_ADD_EMPTY_EVENT();
}

@ -142,7 +142,7 @@ class BASE_EXPORT WorkQueueSets {
// This is for a debugging feature which lets us randomize task selection. Its
// not for production use.
// TODO(crbug.com/1350190): Use a seedable PRNG from ::base if one is added.
// TODO(crbug.com/40234060): Use a seedable PRNG from ::base if one is added.
uint64_t Random() const {
last_rand_ = MurmurHash3(last_rand_);
return last_rand_;

@ -1289,7 +1289,7 @@ TEST_P(SingleThreadTaskExecutorTypedTest, RunLoopQuitOrderAfter) {
// accumulated in the pipe per two posts, so we should repeat 128K times to
// reproduce the bug.
#if BUILDFLAG(IS_CHROMEOS)
// TODO(crbug.com/1188497): This test is unreasonably slow on CrOS and flakily
// TODO(crbug.com/40754898): This test is unreasonably slow on CrOS and flakily
// times out (100x slower than other platforms which take < 1s to complete
// it).
#define MAYBE_RecursivePostsDoNotFloodPipe DISABLED_RecursivePostsDoNotFloodPipe

@ -401,7 +401,7 @@ void WorkerThread::RunWorker() {
std::optional<WatchHangsInScope> hang_watch_scope;
TRACE_EVENT_END0("base", "WorkerThread active");
// TODO(crbug.com/1021571): Remove this once fixed.
// TODO(crbug.com/40657156): Remove this once fixed.
PERFETTO_INTERNAL_ADD_EMPTY_EVENT();
hang_watch_scope.reset();
delegate()->WaitForWork();
@ -475,7 +475,7 @@ void WorkerThread::RunWorker() {
TRACE_EVENT_END0("base", "WorkerThread active");
TRACE_EVENT_INSTANT0("base", "WorkerThread dead", TRACE_EVENT_SCOPE_THREAD);
// TODO(crbug.com/1021571): Remove this once fixed.
// TODO(crbug.com/40657156): Remove this once fixed.
PERFETTO_INTERNAL_ADD_EMPTY_EVENT();
}

@ -48,7 +48,7 @@ public class ApplicationTestUtils {
ACTIVITY_TIMEOUT,
CriteriaHelper.DEFAULT_POLLING_INTERVAL);
// De-flake by flushing the tasks that are already queued on the Looper's Handler.
// TODO(https://crbug.com/1424788): Remove this and properly fix flaky tests.
// TODO(crbug.com/40260566): Remove this and properly fix flaky tests.
TestThreadUtils.flushNonDelayedLooperTasks();
}

@ -162,7 +162,7 @@ class TestLauncher {
#if BUILDFLAG(IS_WIN)
return true;
#else
// TODO(https://crbug.com/1038857): Enable for macOS, Linux, and Fuchsia.
// TODO(crbug.com/40666527): Enable for macOS, Linux, and Fuchsia.
return false;
#endif
}

@ -1292,7 +1292,7 @@ TEST(ProcessGTestOutputTest, RunMockTests) {
EXPECT_GT(*test_results[2].timestamp, Time());
}
// TODO(crbug.com/1498237): Enable the test once GetAppOutputAndError
// TODO(crbug.com/40287376): Enable the test once GetAppOutputAndError
// can collect stdout and stderr on Fuchsia.
#if !BUILDFLAG(IS_FUCHSIA)
TEST(ProcessGTestOutputTest, FoundTestCaseNotEnforced) {

@ -124,7 +124,7 @@ class DisableMaybeTests : public testing::EmptyTestEventListener {
class ResetCommandLineBetweenTests : public testing::EmptyTestEventListener {
public:
ResetCommandLineBetweenTests() : old_command_line_(CommandLine::NO_PROGRAM) {
// TODO(crbug.com/1123627): Remove this after A/B test is done.
// TODO(crbug.com/40053215): Remove this after A/B test is done.
// Workaround a test-specific race conditon with StatisticsRecorder lock
// initialization checking CommandLine by ensuring it's created here (when
// we start the test process), rather than in some arbitrary test. This

@ -767,7 +767,7 @@ void HangWatcher::WatchStateSnapShot::Init(
this, perfetto::ThreadTrack::ForThread(thread_id));
TRACE_EVENT_BEGIN("base", "HangWatcher::ThreadHung", track, deadline);
TRACE_EVENT_END("base", track, now);
// TODO(crbug.com/1021571): Remove this once fixed.
// TODO(crbug.com/40657156): Remove this once fixed.
PERFETTO_INTERNAL_ADD_EMPTY_EVENT();
}
#endif

@ -112,9 +112,9 @@ void MakeSomeErrors(char *ptr, size_t size) {
// verifies that _sanitizer_options_link_helper actually makes it into our
// binaries.
#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_WIN)
// TODO(https://crbug.com/1322143): Sanitizer options are currently broken
// TODO(crbug.com/40224191): Sanitizer options are currently broken
// on Android.
// TODO(https://crbug.com/1321584): __asan_default_options should be used
// TODO(crbug.com/40223949): __asan_default_options should be used
// on Windows too, but currently isn't.
#define MAYBE_LinksSanitizerOptions DISABLED_LinksSanitizerOptions
#else

@ -441,7 +441,7 @@ void ProcessMemoryDump::SerializeAllocatorDumpsInto(
memory_edge->set_source_id(edge.source.ToUint64());
memory_edge->set_target_id(edge.target.ToUint64());
// TODO(crbug.com/1333557): Fix .proto and remove this cast.
// TODO(crbug.com/40845742): Fix .proto and remove this cast.
memory_edge->set_importance(static_cast<uint32_t>(edge.importance));
}
}

@ -92,7 +92,7 @@ namespace {
//
// The high 16 bits of the keyword have special semantics and should not be
// set for enabling individual categories as they are reserved by winmeta.xml.
// TODO(crbug.com/1497783): Move this to
// TODO(crbug.com/40287173): Move this to
// components/tracing/common/etw_export_win.cc once no longer used by
// TraceEventETWExport.
const char* const kFilteredEventGroupNames[] = {

@ -47,7 +47,7 @@ struct TraceEventHandle {
class BASE_EXPORT TraceEvent {
public:
// TODO(898794): Remove once all users have been updated.
// TODO(crbug.com/40599662): Remove once all users have been updated.
using TraceValue = base::trace_event::TraceValue;
TraceEvent();

@ -597,7 +597,7 @@ message ChromeThreadPoolTask {
optional ShutdownBehavior shutdown_behavior = 4;
}
// TODO(crbug.com/1258495): Add more information.
// TODO(crbug.com/40797026): Add more information.
message BackForwardCacheCanStoreDocumentResult {
enum BackForwardCacheNotRestoredReason {
NOT_MAIN_FRAME = 1;
@ -723,7 +723,7 @@ message RendererMainThreadTaskExecution {
TASK_TYPE_WORKER_THREAD_TASK_QUEUE_COMPOSITOR = 48;
TASK_TYPE_COMPOSITOR_THREAD_TASK_QUEUE_INPUT = 49;
// TODO(crbug.com/860545): Obsolete. Remove.
// TODO(crbug.com/40583778): Obsolete. Remove.
TASK_TYPE_NETWORKING_WITH_URL_LOADER_ANNOTATION = 50;
TASK_TYPE_WORKER_ANIMATION = 51;

@ -239,7 +239,7 @@ python_library("resource_sizes_py") {
# logcat.
# Hidden behind build_with_chromium because some third party repos that use
# //build don't pull in //third_party/android_platform.
# TODO(crbug.com/1120190): Move stack script into //build/third_party
# TODO(crbug.com/40145789): Move stack script into //build/third_party
# and enable unconditionally.
group("stack_tools") {
if (build_with_chromium) {

@ -306,7 +306,8 @@ def main(args):
# Python's zip implementation duplicates file comments in the central
# directory, whereas zipalign does not, so use zipalign for official builds.
requires_alignment = options.format == 'apk'
# TODO(crbug.com/1495851): Re-enable zipalign once we are using Android V SDK.
# TODO(crbug.com/40286668): Re-enable zipalign once we are using Android V
# SDK.
run_zipalign = requires_alignment and options.best_compression and False
fast_align = bool(requires_alignment and not run_zipalign)

@ -71,7 +71,7 @@ def FinalizeApk(apksigner_path,
print_stdout=True,
fail_on_output=warnings_as_errors)
shutil.move(staging_file.name, final_apk_path)
# TODO(crbug.com/1174969): Remove this once Python2 is obsoleted.
# TODO(crbug.com/40167754): Remove this once Python2 is obsoleted.
if sys.version_info.major == 2:
staging_file.delete = False
else:

@ -1042,7 +1042,7 @@ class _AvdInstance:
self._debug_tags.add('time')
emulator_cmd.extend(['-debug', ','.join(self._debug_tags)])
if 'kernel' in self._debug_tags or 'all' in self._debug_tags:
# TODO(crbug.com/1404176): newer API levels need "-virtio-console"
# TODO(crbug.com/40885864): newer API levels need "-virtio-console"
# as well to print kernel log.
emulator_cmd.append('-show-kernel')

@ -21,7 +21,7 @@ def merge_shard_results(summary_json, jsons_to_merge):
with open(summary_json) as f:
summary = json.load(f)
except (IOError, ValueError):
# TODO(crbug.com/1245494):Re-enable this check after the recipe module
# TODO(crbug.com/40196155):Re-enable this check after the recipe module
# chromium_swarming can run it with py3
# pylint: disable=raise-missing-from
raise Exception('Summary json cannot be loaded.')

@ -436,6 +436,6 @@ if (is_android || is_chromeos) {
javac_paths_for_inputs =
[ "//third_party/jdk/current/bin/javac" ] + _common_inputs_for_jre_jdk
# TODO(crbug.com/1426605): Remove.
# TODO(crbug.com/40261378): Remove.
use_upstream_errorprone_annotations_threadsafe = true
}

@ -3889,7 +3889,7 @@ if (enable_java_templates) {
}
if (defined(invoker.resources_package) && _type == "java_library") {
# TODO(crbug.com/1296632): remove _bypass_platform_checks from the list
# TODO(crbug.com/40821816): remove _bypass_platform_checks from the list
# once all robolectric targets have migrated to robolectric_library.
assert(_requires_android || _bypass_platform_checks || _is_robolectric,
"Setting resources_package applicable only for " +

@ -2259,7 +2259,7 @@ if (is_robolectric) {
_uses_static_library = defined(invoker.static_library_provider)
# TODO(crbug.com/864142): Allow incremental installs of bundle modules.
# TODO(crbug.com/40585188): Allow incremental installs of bundle modules.
_incremental_apk =
!_is_bundle_module &&
!(defined(invoker.never_incremental) && invoker.never_incremental) &&
@ -3820,7 +3820,7 @@ if (is_robolectric) {
testonly = true
create_apk_script = false
# TODO(crbug.com/1099849): Figure out why angle tests fail to launch
# TODO(crbug.com/40702672): Figure out why angle tests fail to launch
# with newer target_sdk_version.
if (!defined(invoker.target_sdk_version) && _use_native_activity) {
target_sdk_version = 24

@ -11,7 +11,7 @@ declare_args() {
# If this flag is set, we assume Chrome runs on Chrome OS devices, using
# Wayland (instead of X11).
#
# TODO(crbug.com/1052397):
# TODO(crbug.com/40118868):
# Define chromeos_product instead, which takes either "browser" or "ash".
# Re-define the following variables as:
# is_chromeos_lacros = chromeos_product == "browser"

@ -198,7 +198,7 @@ declare_args() {
# * Windows is not supported as it doesn't use DWARF.
# * Apple platforms (e.g. MacOS, iPhone, iPad) aren't supported because xcode
# lldb doesn't have the needed changes yet.
# TODO(crbug.com/1379070): Remove if the upstream default ever changes.
# TODO(crbug.com/40244196): Remove if the upstream default ever changes.
#
# This greatly reduces the size of debug builds, at the cost of
# debugging information which is required by some specialized
@ -611,7 +611,7 @@ config("compiler") {
}
}
# TODO(crbug.com/1488374): This causes binary size growth and potentially
# TODO(crbug.com/40283598): This causes binary size growth and potentially
# other problems.
# TODO(crbug.com/40284925): This isn't supported by Cronet's mainline llvm version.
if (default_toolchain != "//build/toolchain/cros:target" &&
@ -629,7 +629,7 @@ config("compiler") {
}
}
# TODO(crbug.com/1235145): Investigate why/if this should be needed.
# TODO(crbug.com/40192287): Investigate why/if this should be needed.
if (is_win) {
cflags += [ "/clang:-ffp-contract=off" ]
} else {
@ -808,7 +808,7 @@ config("compiler") {
# TODO(b/271459198): Revert limit on amd64 to 30 when fixed.
import_instr_limit = 20
} else if (is_android && optimize_for_size) {
# TODO(crbug.com/1308318): Investigate if we can get the > 6% perf win
# TODO(crbug.com/40219076): Investigate if we can get the > 6% perf win
# of import_instr_limit 30 with a binary size hit smaller than ~2 MiB.
import_instr_limit = 5
}
@ -824,7 +824,7 @@ config("compiler") {
ldflags += [ "-Wl,-mllvm,-disable-auto-upgrade-debug-info" ]
}
# TODO(https://crbug.com/1211155): investigate why this isn't effective on
# TODO(crbug.com/40182783): investigate why this isn't effective on
# arm32.
if (!is_android || current_cpu == "arm64") {
cflags += [ "-fwhole-program-vtables" ]
@ -878,7 +878,7 @@ config("compiler") {
ldflags += [ "-Wl,--no-rosegment" ]
}
# TODO(crbug.com/1374347): Cleanup undefined symbol errors caught by
# TODO(crbug.com/40242425): Cleanup undefined symbol errors caught by
# --no-undefined-version.
if (use_lld && !is_win && !is_mac && !is_ios) {
ldflags += [ "-Wl,--undefined-version" ]
@ -1075,10 +1075,10 @@ config("compiler") {
# consistently apply in both Chromium and non-Chromium code *and* non-NaCl
# and NaCl code.
#
# TODO(https://crbug.com/702997): Move this back to the `runtime_library`
# TODO(crbug.com/40511454): Move this back to the `runtime_library`
# config when NaCl is removed.
if (use_safe_libcxx) {
# TODO(https://crbug.com/1465186): Switch saigo to hardened mode once
# TODO(crbug.com/40275904): Switch saigo to hardened mode once
# it's rolled in.
if (is_nacl_saigo) {
defines += [ "_LIBCPP_ENABLE_ASSERTIONS=1" ]
@ -1498,7 +1498,7 @@ config("compiler_codegen") {
if (current_cpu == "arm64" && !is_win && is_clang) {
# Disable outlining everywhere on arm64 except Win. For more information see
# crbug.com/931297 for Android and crbug.com/1410297 for iOS.
# TODO(crbug.com/1411363): Enable this on Windows if possible.
# TODO(crbug.com/40890229): Enable this on Windows if possible.
cflags += [ "-mno-outline" ]
# This can be removed once https://bugs.llvm.org/show_bug.cgi?id=40348
@ -1689,7 +1689,7 @@ config("runtime_library") {
configs += [ "//build/config/clang:compiler_builtins" ]
}
# TODO(crbug.com/830987): Come up with a better name for is POSIX + Fuchsia
# TODO(crbug.com/40570904): Come up with a better name for is POSIX + Fuchsia
# configuration.
if (is_posix || is_fuchsia) {
configs += [ "//build/config/posix:runtime_library" ]
@ -1901,22 +1901,22 @@ config("default_warnings") {
# TODO(thakis): Only for no_chromium_code? http://crbug.com/912662
"-Wno-ignored-pragma-optimize",
# TODO(crbug.com/1343975) Evaluate and possibly enable.
# TODO(crbug.com/40231599) Evaluate and possibly enable.
"-Wno-deprecated-builtins",
# TODO(crbug.com/1352183) Evaluate and possibly enable.
# TODO(crbug.com/40234766) Evaluate and possibly enable.
"-Wno-bitfield-constant-conversion",
# TODO(crbug.com/1412713) Evaluate and possibly enable.
# TODO(crbug.com/40255410) Evaluate and possibly enable.
"-Wno-deprecated-this-capture",
# TODO(https://crbug.com/1491833): Fix and re-enable.
# TODO(crbug.com/40285259): Fix and re-enable.
"-Wno-invalid-offsetof",
# TODO(crbug.com/1494809): Evaluate and possibly enable.
# TODO(crbug.com/40286317): Evaluate and possibly enable.
"-Wno-vla-extension",
# TODO(https://crbug.com/1490607): Fix and re-enable.
# TODO(crbug.com/40284799): Fix and re-enable.
"-Wno-thread-safety-reference-return",
]
@ -2119,7 +2119,7 @@ config("no_chromium_code") {
# Disabled for similar reasons as -Wunused-variable.
"-Wno-unused-but-set-variable",
# TODO(https://crbug.com/1202159): Clean up and enable.
# TODO(crbug.com/40762742): Clean up and enable.
"-Wno-misleading-indentation",
]
}
@ -2182,7 +2182,7 @@ config("no_rtti") {
# (de)allocate memory on a different heap, which would spell trouble if pointers
# to heap-allocated memory are passed over shared library boundaries.
config("export_dynamic") {
# TODO(crbug.com/1052397): Revisit after target_os flip is completed.
# TODO(crbug.com/40118868): Revisit after target_os flip is completed.
if (is_linux || is_chromeos_lacros || export_libcxxabi_from_executables) {
ldflags = [ "-rdynamic" ]
}
@ -2832,7 +2832,7 @@ config("symbols") {
if (is_clang && (!is_nacl || is_nacl_saigo) && current_os != "zos") {
if (is_apple) {
# TODO(https://crbug.com/1050118): Investigate missing debug info on mac.
# TODO(crbug.com/40117949): Investigate missing debug info on mac.
# Make sure we don't use constructor homing on mac.
cflags += [
"-Xclang",

@ -333,7 +333,7 @@ if (forbid_non_component_debug_builds) {
"Can't do non-component debug builds at symbol_level=2 without use_debug_fission=true")
}
# TODO(crbug.com/1341436) For Windows, to assemble lzma_sdk's assembly files,
# TODO(crbug.com/40230692) For Windows, to assemble lzma_sdk's assembly files,
# ml64.exe needs to be utilized as llvm-ml cannot yet assemble it. Once llvm-ml
# is able to assemble lzma_sdk assembly files, remove this.
# LzmaDecOpt.asm only works on x64 and not x86.

@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# TODO(crbug.com/1233050): Until the bug is resolved we need to include
# TODO(crbug.com/40191347): Until the bug is resolved we need to include
# gclient_args for the definition of build_with_chromium and build_overrides
# for client overrides of that flag. The latter should go away.
import("//build/config/gclient_args.gni")

@ -12,7 +12,7 @@ assert(!is_posix, "Fuchsia is not POSIX.")
config("compiler") {
configs = [ "//third_party/fuchsia-gn-sdk/src/config:compiler" ]
# TODO(https://crbug.com/706592): The stack defaults to 256k on Fuchsia (see
# TODO(crbug.com/40513182): The stack defaults to 256k on Fuchsia (see
# https://fuchsia.googlesource.com/zircon/+/master/system/private/zircon/stack.h#9),
# but on other platforms it's much higher, so a variety of code assumes more
# will be available. Raise to 8M which matches e.g. macOS.

@ -235,7 +235,7 @@ template("fuchsia_test_runner") {
"$root_gen_dir/package_metadata/${invoker.package_name}.meta",
]
# TODO(crbug.com/1256870): Remove this once all out-of-tree references
# TODO(crbug.com/40200403): Remove this once all out-of-tree references
# to "package_name_override" are migrated to "package_name".
if (defined(invoker.package_name_override)) {
package_name = invoker.package_name_override

@ -11,6 +11,6 @@ assert(is_fuchsia)
# of fuchsia_package().
FUCHSIA_PACKAGED_CONTENT_EMBEDDER_EXCLUDED_DIRS = [
# These are mistakenly being shipped in both PAK form and runtime data deps.
# TODO(crbug.com/1265660): Remove when DevTools stops leaking its source list.
# TODO(crbug.com/40203829): Remove when DevTools stops leaking its source list.
devtools_root_location,
]

@ -25,7 +25,7 @@ enable_dav1d_decoder = false
produce_v8_compile_hints = false
# //chrome makes many assumptions that Extensions are enabled.
# TODO(crbug.com/1363742): Fix theses assumptions or avoid building it.
# TODO(crbug.com/40238815): Fix theses assumptions or avoid building it.
# enable_extensions = false
enable_hidpi = false

@ -5,7 +5,7 @@
use: [
{
protocol: [
// TODO(crbug.com/1348174): Rather than require the system to provide
// TODO(crbug.com/40855135): Rather than require the system to provide
// capabilities straight from audio_core, we should run Chromium tests
// against an audio stack with fake device(s).
"fuchsia.media.Audio",

@ -242,7 +242,7 @@ config("xctest_config") {
]
}
# TODO(crbug.com/1444308): any target that uses this config will miscompile.
# TODO(crbug.com/40911785): any target that uses this config will miscompile.
# This needs to be fixed if we want to use Swift - C++ interop.
config("enable_swift_cxx_interop") {
swiftflags = [ "-enable-experimental-cxx-interop" ]

@ -64,7 +64,7 @@ declare_args() {
# host (they are not shipped) --- this is required as Chrome on iOS is usually
# build with the latest version of Xcode that may not ship with the version of
# the macOS SDK used to build Chrome on mac.
# TODO(crbug.com/635745): the check for target_os should be replaced by a
# TODO(crbug.com/40479759): the check for target_os should be replaced by a
# check that current_toolchain is default_toolchain, and the file should
# assert that current_os is "mac" once this file is no longer included by
# iOS toolchains.

@ -73,7 +73,7 @@ declare_args() {
# compilation artifacts produced by `rustc`). In LaCrOS and ash builds this
# may not be true - see b/299483903.
#
# TODO(https://crbug.com/1482525): Re-enable ThinLTO for Rust on LaCrOS
# TODO(crbug.com/40281834): Re-enable ThinLTO for Rust on LaCrOS
# TODO(b/300937673): Re-enable ThinLTO for Rust on ash-chrome
toolchain_supports_rust_thin_lto = !is_chromeos

@ -471,7 +471,7 @@ config("msan_flags") {
"-fsanitize-memory-track-origins=$msan_track_origins",
"-fsanitize-ignorelist=$msan_ignorelist_path",
# TODO(https://crbug.com/1317909): evaluate and possibly enable
# TODO(crbug.com/40222690): evaluate and possibly enable
"-fno-sanitize-memory-use-after-dtor",
]
@ -503,7 +503,7 @@ config("ubsan_flags") {
rebase_path("//tools/ubsan/ignorelist.txt", root_build_dir)
}
# TODO(crbug.com/1502579): Enable all of -fsanitize=undefined. Note that
# TODO(crbug.com/40942951): Enable all of -fsanitize=undefined. Note that
# both this list and Clang's defaults omit -fsanitize=float-divide-by-zero.
# C and C++ leave it undefined to accommodate non-IEEE floating point, but
# we assume the compiler implements IEEE floating point, which does define

@ -42,7 +42,7 @@ declare_args() {
# Enables "param-retval" mode, which finds more uses of uninitialized data and
# reduces code size. Behind a flag as there are a number of previously
# undetected violations that still need to be fixed.
# TODO(crbug.com/1369167): Default this to true and remove.
# TODO(crbug.com/40240570): Default this to true and remove.
msan_eager_checks = false
# Use dynamic libraries instrumented by one of the sanitizers instead of the
@ -146,7 +146,7 @@ declare_args() {
# enable it by default only in sanitizer builds.
# Also be sure not to enable this on non-Chromium builds where
# the required //third_party/fuzztest dependency may be absent.
# TODO(crbug.com/1495713): enable on component builds
# TODO(crbug.com/40286621): enable on component builds
enable_fuzztest_fuzz =
!(use_libfuzzer || use_afl || use_centipede ||
use_external_fuzzing_engine) &&
@ -222,7 +222,7 @@ fuzzing_engine_supports_custom_main = use_libfuzzer || use_centipede
# declare_args block.
declare_args() {
# Generates an owners file for each fuzzer test.
# TODO(crbug.com/1194183): Remove this arg when finding OWNERS is faster.
# TODO(crbug.com/40175535): Remove this arg when finding OWNERS is faster.
generate_fuzzer_owners = use_fuzzing_engine
use_sanitizer_coverage =

@ -82,7 +82,7 @@ def __step_config(ctx, step_config):
"name": "android/dex",
"command_prefix": "python3 ../../build/android/gyp/dex.py",
"handler": "android_dex",
# TODO(crbug.com/1452038): include only required jar, dex files in GN config.
# TODO(crbug.com/40270798): include only required jar, dex files in GN config.
"indirect_inputs": {
"includes": ["*.dex", "*.ijar.jar", "*.turbine.jar"],
},

@ -646,7 +646,7 @@ config("default_incremental_linking") {
# lld.
ldflags += [ "/OPT:NOREF" ]
# TODO(crbug.com/1444129): Mixing incrememntal and icf produces an error
# TODO(crbug.com/40267564): Mixing incrememntal and icf produces an error
# in lld-link.
ldflags += [ "/OPT:NOICF" ]
}

@ -75,7 +75,7 @@ def ComputePackageDiffs(before_sizes_file, after_sizes_file, author=None):
' this trybot:<br>{}'.format(_TRYBOT_DOC))
growth['summary'] = summary
# TODO(crbug.com/1266085): Investigate using these fields.
# TODO(crbug.com/40801868): Investigate using these fields.
growth['archive_filenames'] = []
growth['links'] = []
return growth

@ -460,7 +460,7 @@ def GetPackageBlobs(far_files, build_out_dir):
def GetPackageSizes(package_blobs):
"""Calculates compressed and uncompressed package sizes from blob sizes."""
# TODO(crbug.com/1126177): Use partial sizes for blobs shared by
# TODO(crbug.com/40718363): Use partial sizes for blobs shared by
# non Chrome-Fuchsia packages.
# Count number of packages sharing blobs (a count of 1 is not shared).

@ -23,7 +23,7 @@ class BlinkTestRunner(TestRunner):
target_id: Optional[str]) -> None:
super().__init__(out_dir, test_args, ['content_shell'], target_id)
# TODO(crbug.com/1278939): Remove when blink tests use CFv2 content_shell.
# TODO(crbug.com/40810506): Remove when blink tests use CFv2 content_shell.
@staticmethod
def is_cfv2() -> bool:
return False

@ -54,7 +54,7 @@ def _get_vulkan_args(use_vulkan: Optional[str]) -> List[str]:
vulkan_args = []
if not use_vulkan:
if get_host_arch() == 'x64':
# TODO(crbug.com/1261646) Remove once Vulkan is enabled by
# TODO(crbug.com/40202294) Remove once Vulkan is enabled by
# default.
use_vulkan = 'native'
else:

@ -46,7 +46,7 @@ class TelemetryTestRunner(TestRunner):
super().__init__(out_dir, test_args, packages, target_id)
# TODO(crbug.com/1345390): Remove when Telemetry tests use CFv2 components.
# TODO(crbug.com/40853548): Remove when Telemetry tests use CFv2 components.
@staticmethod
def is_cfv2() -> bool:
return False

@ -32,7 +32,7 @@ from update_sdk import GetSDKOverrideGCSPath
IMAGE_SIGNATURE_FILE = '.hash'
# TODO(crbug.com/1138433): Investigate whether we can deprecate
# TODO(crbug.com/40725453): Investigate whether we can deprecate
# use of sdk_bucket.txt.
def GetOverrideCloudStorageBucket():
"""Read bucket entry from sdk_bucket.txt"""

@ -82,9 +82,9 @@ def _ReceiveFDs(sock):
# The newest one: ash-chrome returns three FDs, the mojo connection of
# old bootstrap procedure, the second for the start up data FD, and
# the third for another mojo connection of new bootstrap procedure.
# TODO(crbug.com/1156033): Clean up the code to drop the support of
# TODO(crbug.com/40735724): Clean up the code to drop the support of
# oldest one after M91.
# TODO(crbug.com/1180712): Clean up the mojo procedure support of the
# TODO(crbug.com/40170079): Clean up the mojo procedure support of the
# the middle one after M92.
cmsg_len_candidates = [(i + 1) * fds.itemsize
for i in range(_NUM_FDS_MAX)]

@ -281,7 +281,7 @@ def _WaitForAshChromeToStart(tmp_xdg_dir, lacros_mojo_socket_file,
Determine whether ash-chrome is up and running by checking whether two files
(lock file + socket) have been created in the |XDG_RUNTIME_DIR| and the lacros
mojo socket file has been created if enabling the mojo "crosapi" interface.
TODO(crbug.com/1107966): Figure out a more reliable hook to determine the
TODO(crbug.com/40707216): Figure out a more reliable hook to determine the
status of ash-chrome, likely through mojo connection.
Args:

@ -86,7 +86,7 @@ template("rust_unit_test") {
_env_out_dir = target_gen_dir
}
# TODO(crbug.com/1229320): Arrange to run test executables on try bots.
# TODO(crbug.com/40778298): Arrange to run test executables on try bots.
# TODO(crbug.com/gn/146): Allow Rust executables to depend on C/C++ source
# sets.
# This is important in cases where Rust tests may depend upon C/C++

@ -32,7 +32,7 @@ build_file_template = "BUILD.gn.hbs"
# However, we can't apply it yet. GN can't automatically clean old artifacts,
# nor can we delete and rebuild the sysroot on every build.
#
# TODO(crbug.com/1245714): set up GN rules to rebuilt the sysroot only when
# TODO(crbug.com/40196262): set up GN rules to rebuilt the sysroot only when
# needed. Then set this metadata.
#
# rustc_metadata = "libstd"

@ -108,7 +108,7 @@ char kLSanDefaultSuppressions[] =
#if BUILDFLAG(IS_MAC)
// These are caused by the system, but not yet clear if they are false
// positives or bugs in the Mac LSAN runtime. Suppress while investigating.
// TODO(https://crbug.com/1320449): Remove these if/when fixed in macOS
// TODO(crbug.com/40223516): Remove these if/when fixed in macOS
// or the runtime.
"leak:_ensureAuxServiceAwareOfHostApp\n"
"leak:cssmErrorString\n"

@ -138,7 +138,7 @@ clang_toolchain("robolectric_$host_cpu") {
is_robolectric = true
}
# TODO(crbug.com/1487407): Figure out why robolectric tests fail with component builds.
# TODO(crbug.com/40283271): Figure out why robolectric tests fail with component builds.
toolchain_args.is_component_build = false
shlib_extension = ".so"
}

@ -50,7 +50,7 @@ _can_use_hermetic_swift =
build_with_chromium && is_ios && target_environment != "catalyst"
if (swift_toolchain_path == -1) {
# TODO(crbug.com/1451611) The custom swift toolchain not does currently work
# TODO(crbug.com/40915887) The custom swift toolchain not does currently work
# with Xcode 15 beta 1.
if (_can_use_hermetic_swift && !(is_ios && xcode_version_int >= 1500)) {
# Version of the hermetic compiler. Needs to be updated when a new version of

@ -74,7 +74,7 @@ if (concurrent_links == -1) {
} else if (current_os == "zos") {
_args = [ "--mem_per_link_gb=1" ]
} else if (is_fuchsia) {
# TODO(crbug.com/1347159): This was defaulting to 8GB. The number of
# TODO(crbug.com/40854531): This was defaulting to 8GB. The number of
# linker instances to run in parallel is calculated by diviging
# the available memory by this value. On a 32GB machine with
# roughly 29GB of available memory, this would cause three instances

@ -259,7 +259,7 @@ if (also_build_lacros_chrome_for_architecture != "") {
toolchain_args = {
forward_variables_from(lacros_args, "*")
# TODO(crbug.com/1298821) Change to a better way to set gn args.
# TODO(crbug.com/40823173) Change to a better way to set gn args.
# The following gn args are present in ash config like
# //build/args/chromeos/atlas.gni but not in
# //build/args/chromeos/amd64-generic-crostoolchain.gni.

@ -21,7 +21,7 @@ import wrapper_utils
def CollectSONAME(args):
"""Replaces: readelf -d $sofile | grep SONAME"""
# TODO(crbug.com/1259067): Come up with a way to get this info without having
# TODO(crbug.com/40797404): Come up with a way to get this info without having
# to bundle readelf in the toolchain package.
toc = ''
readelf = subprocess.Popen(wrapper_utils.CommandToRun(

@ -35,7 +35,7 @@ declare_args() {
# libchrome (CrOS's version of //base). This flag can disable tracing support
# altogether, in which case all tracing instrumentation in //base becomes a
# no-op.
# TODO(crbug/1065905): Add dependency on perfetto to support typed events.
# TODO(crbug.com/40124378): Add dependency on perfetto to support typed events.
enable_base_tracing = true
# Switches the TRACE_EVENT instrumentation from base's TraceLog implementation
@ -54,7 +54,7 @@ declare_args() {
gtest_enable_absl_printers = !is_nacl
# Allow projects that wish to stay on C++17 to override Chromium's default.
# TODO(crbug.com/1402249): evaluate removing this end of 2023
# TODO(crbug.com/40251117): evaluate removing this end of 2023
use_cxx17 = false
}

@ -1,4 +1,4 @@
#TODO(crbug.com/1245895): remove this when remote_toolchain_inputs is provided
#TODO(crbug.com/40788874): remove this when remote_toolchain_inputs is provided
# with the toolchain. This file is used by
# cros_chrome_sdk to generate rewrapper.cfg for
# ChromeOS (simple chrome).

@ -72,7 +72,7 @@
// termination function on Apple platforms.
#define _LIBCPP_VERBOSE_ABORT(...) ::std::__libcpp_verbose_abort(__VA_ARGS__)
// TODO(crbug.com/1455923) Link against compiler-rt's builtins library to
// TODO(crbug.com/40272953) Link against compiler-rt's builtins library to
// enable 128-arithmetic.
#if defined(_WIN32)
#define _LIBCPP_HAS_NO_INT128

@ -484,7 +484,7 @@ bool KeyframeEffect::RequiresInvalidation() const {
bool KeyframeEffect::AffectsNativeProperty() const {
for (const auto& it : keyframe_models()) {
// TODO(crbug.com/1257778): include the SCROLL_OFFSET here so that we won't
// TODO(crbug.com/40796582): include the SCROLL_OFFSET here so that we won't
// create a compositor animation frame sequence tracker when there is a
// composited scroll.
if (it->TargetProperty() != TargetProperty::CSS_CUSTOM_PROPERTY &&

@ -102,7 +102,7 @@ const char kAnimatedImageResume[] = "animated-image-resume";
// Allows scaling clipped images in GpuImageDecodeCache. Note that this may
// cause color-bleeding.
// TODO(crbug.com/1157548): Remove this workaround flag once the underlying
// TODO(crbug.com/40160880): Remove this workaround flag once the underlying
// cache problems are solved.
const char kEnableClippedImageScaling[] = "enable-scaling-clipped-images";

@ -476,7 +476,7 @@ void InputHandler::RecordScrollBegin(
// (2) the scroll is driven by the compositor, but blocked on the main
// thread.
// Otherwise, the compositor-thread is the 'scrolling thread'.
// TODO(crbug.com/1060712): We should also count 'main thread' as the
// TODO(crbug.com/40122138): We should also count 'main thread' as the
// 'scrolling thread' if the layer being scrolled has scroll-event handlers.
FrameInfo::SmoothEffectDrivingThread scrolling_thread;
switch (scroll_start_state) {

@ -214,7 +214,7 @@ gfx::Rect ScrollbarLayerImplBase::ComputeThumbQuadRectWithThumbThicknessScale(
int thumb_thickness = ThumbThickness();
// TODO(crbug.com/40194000): This is a speculative fix.
float maximum = std::max(scroll_layer_length() - clip_layer_length(), 0.0f);
// TODO(crbug.com/1239510): Re-enable the following DCHECK once the
// TODO(crbug.com/40193888): Re-enable the following DCHECK once the
// underlying issue is resolved.
// DCHECK(scroll_layer_length() >= clip_layer_length());

@ -60,7 +60,7 @@ using ::testing::AtLeast;
using ::testing::InvokeWithoutArgs;
using ::testing::Mock;
// TODO(https://crbug.com/1400943): settings new expecations after
// TODO(crbug.com/40883999): settings new expecations after
// VerifyAndClearExpectations is undefined behavior. See
// http://google.github.io/googletest/gmock_cook_book.html#forcing-a-verification
#define EXPECT_SET_NEEDS_COMMIT(expect, code_to_test) \
@ -1184,7 +1184,7 @@ class TextureLayerChangeInvisibleMailboxTest : public LayerTreeTest,
bool close_on_resource_returned_ = false;
};
// TODO(crbug.com/1197350): Test fails on chromeos-amd64-generic-rel.
// TODO(crbug.com/40760099): Test fails on chromeos-amd64-generic-rel.
#if BUILDFLAG(IS_CHROMEOS)
#define MAYBE_SINGLE_AND_MULTI_THREAD_TEST_F MULTI_THREAD_TEST_F
#else

@ -145,7 +145,7 @@ float FilterOperations::MaximumPixelMovement() const {
max_movement = fmax(max_movement, 100);
continue;
case FilterOperation::OFFSET:
// TODO(crbug/1379125): Work out how to correctly set maximum pixel
// TODO(crbug.com/40244221): Work out how to correctly set maximum pixel
// movement when an offset filter may be combined with other pixel
// moving filters.
max_movement =

@ -388,7 +388,7 @@ sk_sp<SkImage> ReadImage(
// overhead with modern APIs leading to lesser scheduling concerns.
// Also, eventually we want to move tile raster off the GPU main thread.
// Based on these reasons, its okay to not flush for Graphite here.
// TODO(crbug.com/1463790): Revisit flushes for Graphite here if yield
// TODO(crbug.com/40922674): Revisit flushes for Graphite here if yield
// to scheduler is needed.
plane = SkImages::TextureFromImage(graphite_recorder, plane, props);
}

@ -41,7 +41,7 @@ class CC_PAINT_EXPORT PaintFlags {
return static_cast<Style>(bitfields_.style_);
}
ALWAYS_INLINE void setStyle(Style style) { bitfields_.style_ = style; }
// TODO(crbug.com/1399566): Remove this function
// TODO(crbug.com/40249893): Remove this function
ALWAYS_INLINE SkColor getColor() const { return color_.toSkColor(); }
ALWAYS_INLINE SkColor4f getColor4f() const { return color_; }
ALWAYS_INLINE void setColor(SkColor color) {

@ -383,7 +383,7 @@ class CC_PAINT_EXPORT PaintImage {
friend class DrawImageToneMapUtil;
friend class DrawSkottieOp;
// TODO(crbug.com/1031051): Remove these once GetSkImage()
// TODO(crbug.com/40110279): Remove these once GetSkImage()
// is fully removed.
friend class ImagePaintFilter;
friend class PaintShader;

@ -207,7 +207,7 @@ class CC_PAINT_EXPORT RecordPaintCanvas : public PaintCanvas {
// Rasterization may batch operations, and that batching may be disabled if
// drawLine() is used instead of drawPath(). These members are used to
// determine is a drawLine() should be rastered as a drawPath().
// TODO(https://crbug.com/1420380): figure out better heurstics.
// TODO(crbug.com/40258748): figure out better heurstics.
uint32_t draw_path_count_ = 0;
uint32_t draw_line_count_ = 0;
};

Some files were not shown because too many files have changed in this diff Show More