0

Roll internal parsing patterns

Rolls over crrev.com/i/7658982 and adds the corresponding feature flag.

Fixed: 364593932
Change-Id: I4f2b93d6934a3597046ab55349ce3f377df03146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5844710
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1352753}
This commit is contained in:
Florian Leimgruber
2024-09-09 15:16:16 +00:00
committed by Chromium LUCI CQ
parent 5c3237ccdf
commit 83113cb343
8 changed files with 18 additions and 4 deletions
DEPS
android_webview/java/src/org/chromium/android_webview/common
components/autofill/core

2
DEPS

@ -4299,7 +4299,7 @@ deps = {
'src/components/autofill/core/browser/form_parsing/internal_resources': {
'url': Var('chrome_git') + '/chrome/components/autofill_regex_patterns.git' + '@' +
'039433e434fe0e89316a829accc77394f31fd823',
'8d1f2ac92088e96479b7c81f5e7f56abce5e0152',
'condition': 'checkout_src_internal',
},

@ -304,6 +304,9 @@ public final class ProductionSupportedFlagList {
Flag.baseFeature(
AutofillFeatures.AUTOFILL_USE_PL_ADDRESS_MODEL,
"When enabled, Autofill uses a custom address model for Poland."),
Flag.baseFeature(
AutofillFeatures.AUTOFILL_GREEK_REGEXES,
"When enabled, Greek regexes are used for parsing in branded builds."),
Flag.baseFeature(
AutofillFeatures.AUTOFILL_ENABLE_EMAIL_HEURISTIC_ONLY_ADDRESS_FORMS,
"When enabled, Autofill supports forms consisting of only email fields."),

@ -46,7 +46,7 @@ action("regex_patterns_inl_h") {
if (use_internal_autofill_patterns) {
sources += [
"form_parsing/internal_resources/0_default_regex_patterns.json",
"form_parsing/internal_resources/2_improved_predictions.json",
"form_parsing/internal_resources/1_improved_predictions.json",
]
} else {
sources += [ "form_parsing/resources/legacy_regex_patterns.json" ]

@ -18,6 +18,8 @@ const base::Feature* GetFeatureOfRegexFeature(RegexFeature feature) {
switch (feature) {
case RegexFeature::kUnusedDummyFeature:
return nullptr;
case RegexFeature::kAutofillGreekRegexes:
return &features::kAutofillGreekRegexes;
}
NOTREACHED();
}

@ -57,7 +57,8 @@ enum class RegexFeature : uint8_t {
// This entry only exists to ensure that the enum never becomes empty as
// features are added and removed.
kUnusedDummyFeature = 0,
kMaxValue = kUnusedDummyFeature
kAutofillGreekRegexes = 1,
kMaxValue = kAutofillGreekRegexes
};
// Returns a `DenseSet` containing all `RegexFeature`s whose corresponding

@ -747,6 +747,12 @@ BASE_FEATURE(kAutofillTrackMultipleUseDates,
"AutofillTrackMultipleUseDates",
base::FEATURE_DISABLED_BY_DEFAULT);
// When enabled, Greek regexes are used for parsing in branded builds.
COMPONENT_EXPORT(AUTOFILL)
BASE_FEATURE(kAutofillGreekRegexes,
"AutofillGreekRegexes",
base::FEATURE_DISABLED_BY_DEFAULT);
#if BUILDFLAG(IS_ANDROID)
// Controls if Chrome Autofill UI surfaces ignore touch events if something is
// fully or partially obscuring the Chrome window.

@ -252,6 +252,8 @@ extern const base::FeatureParam<std::string>
kAutofillUKMExperimentalFieldsBucket4;
COMPONENT_EXPORT(AUTOFILL)
BASE_DECLARE_FEATURE(kAutofillTrackMultipleUseDates);
COMPONENT_EXPORT(AUTOFILL)
BASE_DECLARE_FEATURE(kAutofillGreekRegexes);
#if BUILDFLAG(IS_ANDROID)
COMPONENT_EXPORT(AUTOFILL)