[Blink] Switch to using Graphite by default in layout tests on Mac14-ARM
Graphite has stuck in fieldtrial_testing_config.json and we are experimenting on stable in Mac-ARM, so it's time to move the layout tests on this platform to use Graphite. Rebaselines tests as necessary via third_party/blink/tools/blink_tool.py rebaseline-cl . In this CL we move only Mac14 to limit the scope of the change. We will follow up with other OS versions. Sheriffs: If this CL results in layout test failures please rebaseline/add suppressions if at all feasible and CC me rather than reverting the CL. Include-Ci-Only-Tests: true Bug: 40937352 Change-Id: I123cccc7ee9c7cec32fe8f4596c744a495b6bf25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179215 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1413635}


@ -48,6 +48,10 @@
|
||||
#include "ui/gl/gl_implementation.h"
|
||||
#include "ui/gl/gl_switches.h"
|
||||
|
||||
#if BUILDFLAG(IS_MAC)
|
||||
#include "base/mac/mac_util.h"
|
||||
#endif
|
||||
|
||||
#if BUILDFLAG(ENABLE_PPAPI)
|
||||
#include "content/public/test/ppapi_test_utils.h"
|
||||
#endif
|
||||
@ -269,12 +273,30 @@ void WebTestBrowserMainRunner::Initialize() {
|
||||
if (!command_line.HasSwitch(switches::kEnableGpuRasterization))
|
||||
command_line.AppendSwitch(switches::kDisableGpuRasterization);
|
||||
|
||||
#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM64)
|
||||
if (base::mac::MacOSMajorVersion() == 14) {
|
||||
// If Graphite is not explicitly disabled, enable it. This is to use
|
||||
// Graphite as the renderer for web tests on all bots for this platform
|
||||
// except those explicitly testing Ganesh.
|
||||
if (!command_line.HasSwitch(switches::kDisableSkiaGraphite)) {
|
||||
command_line.AppendSwitch(switches::kEnableSkiaGraphite);
|
||||
}
|
||||
} else {
|
||||
// If Graphite is not explicitly enabled, disable it. This is to keep using
|
||||
// Ganesh as renderer for web tests for now until we finish rebaselining all
|
||||
// images for Graphite renderer.
|
||||
if (!command_line.HasSwitch(switches::kEnableSkiaGraphite)) {
|
||||
command_line.AppendSwitch(switches::kDisableSkiaGraphite);
|
||||
}
|
||||
}
|
||||
#else
|
||||
// If Graphite is not explicitly enabled, disable it. This is to keep using
|
||||
// Ganesh as renderer for web tests for now until we finish rebaselining all
|
||||
// images for Graphite renderer.
|
||||
if (!command_line.HasSwitch(switches::kEnableSkiaGraphite)) {
|
||||
command_line.AppendSwitch(switches::kDisableSkiaGraphite);
|
||||
}
|
||||
#endif
|
||||
|
||||
// If the virtual test suite didn't specify a display color space, then
|
||||
// force sRGB.
|
||||
|
23
third_party/blink/web_tests/TestExpectations
vendored
@ -53,6 +53,27 @@ external/wpt/infrastructure/reftest/reftest_ref_timeout.html [ Timeout ]
|
||||
external/wpt/infrastructure/reftest/reftest_timeout.html [ Timeout ]
|
||||
wpt_internal/infrastructure/fail-before-timeout.html [ Timeout ]
|
||||
|
||||
# Graphite failures on Mac-ARM
|
||||
|
||||
# YUV edge sampling bug
|
||||
crbug.com/329041548 [ Mac14-arm64 ] media/video-colorspace-yuv422.html [ Failure ]
|
||||
|
||||
crbug.com/dawn/2456 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Crash ]
|
||||
crbug.com/dawn/2456 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Crash ]
|
||||
|
||||
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/drop-shadow-currentcolor-dynamic-003.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] external/wpt/css/filter-effects/backdrop-filter-backdrop-root-opacity.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] external/wpt/css/css-masking/mask-image/mask-opacity-1e.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] external/wpt/css/filter-effects/backdrop-filter-clip-rect-2.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] external/wpt/css/filter-effects/drop-shadow-currentcolor-dynamic-003.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/backdrop-filter-clip-rect-2.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] virtual/gpu-rasterization/external/wpt/css/css-images/cross-fade-premultiplied-alpha.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] virtual/off-main-thread-css-paint/http/tests/csspaint/transform-with-page-zoom-003.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/backdrop-filter-backdrop-root-opacity.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] external/wpt/css/filter-effects/backdrop-filter-transform.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] virtual/off-main-thread-css-paint/http/tests/csspaint/paint2d-zoom.html [ Failure ] # Reftest image failure
|
||||
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/backdrop-filter-transform.html [ Failure ] # Reftest image failure
|
||||
|
||||
# We don't support extracting fuzzy information from .ini files, which these
|
||||
# WPT infrastructure tests rely on.
|
||||
crbug.com/997202 external/wpt/infrastructure/reftest/legacy/reftest_fuzzy_chain_ini.html [ Failure ]
|
||||
@ -3006,7 +3027,6 @@ crbug.com/390000672 [ Mac12-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding
|
||||
crbug.com/378158966 crbug.com/390000672 [ Mac13 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure Timeout ]
|
||||
crbug.com/390000672 [ Mac13-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure ]
|
||||
crbug.com/378158966 crbug.com/390000672 [ Mac14 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure Timeout ]
|
||||
crbug.com/390000672 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure ]
|
||||
crbug.com/378158966 crbug.com/390000672 [ Mac15 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure Timeout ]
|
||||
crbug.com/390000672 [ Mac11 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
|
||||
crbug.com/390000672 [ Mac11-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
|
||||
@ -3015,7 +3035,6 @@ crbug.com/390000672 [ Mac12-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding
|
||||
crbug.com/378158966 crbug.com/390000672 [ Mac13 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure Timeout ]
|
||||
crbug.com/390000672 [ Mac13-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
|
||||
crbug.com/378158966 crbug.com/390000672 [ Mac14 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure Timeout ]
|
||||
crbug.com/390000672 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
|
||||
crbug.com/378158966 crbug.com/390000672 [ Mac15 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure Timeout ]
|
||||
crbug.com/377977965 [ Linux ] external/wpt/webdriver/tests/bidi/browser/get_client_windows/get_client_windows.py [ Failure ]
|
||||
crbug.com/377576485 [ Mac15 ] external/wpt/webrtc-extensions/RTCRtpParameters-adaptivePtime.html [ Timeout ]
|
||||
|
BIN
third_party/blink/web_tests/flag-specific/enable-skia-graphite/http/tests/media/video-frame-size-change-expected.png
vendored
Before ![]() (image error) Size: 116 KiB |
BIN
third_party/blink/web_tests/flag-specific/enable-skia-graphite/media/color-profile-video-seek-expected.png
vendored
Before ![]() (image error) Size: 29 KiB |
BIN
third_party/blink/web_tests/flag-specific/enable-skia-graphite/media/color-profile-video-seek-filter-expected.png
vendored
Before ![]() (image error) Size: 33 KiB |
Before ![]() (image error) Size: 39 KiB |
Before ![]() (image error) Size: 15 KiB |
Before ![]() (image error) Size: 9.3 KiB |
Before ![]() (image error) Size: 82 KiB |
Before ![]() (image error) Size: 52 KiB |
Before ![]() (image error) Size: 124 KiB |
Before ![]() (image error) Size: 120 KiB |
Before ![]() (image error) Size: 90 KiB |
Before ![]() (image error) Size: 35 KiB |
Before ![]() (image error) Size: 35 KiB |
Before ![]() (image error) Size: 84 KiB |
Before ![]() (image error) Size: 153 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/3d-corners-expected.png
vendored
Normal file
After ![]() (image error) Size: 6.2 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/3d-cube-expected.png
vendored
Normal file
After ![]() (image error) Size: 18 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/backface-visibility-transformed-expected.png
vendored
Normal file
After ![]() (image error) Size: 3.3 KiB |
Before ![]() (image error) Size: 5.5 KiB After ![]() (image error) Size: 5.5 KiB ![]() ![]() |
Before ![]() (image error) Size: 4.6 KiB After ![]() (image error) Size: 4.6 KiB ![]() ![]() |
Before ![]() (image error) Size: 2.9 KiB After ![]() (image error) Size: 2.8 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/direct-image-compositing-expected.png
vendored
Before ![]() (image error) Size: 64 KiB After ![]() (image error) Size: 63 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/flat-with-transformed-child-expected.png
vendored
Normal file
After ![]() (image error) Size: 4.6 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png
vendored
Normal file
After ![]() (image error) Size: 3.3 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png
vendored
Normal file
After ![]() (image error) Size: 6.2 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/geometry/layer-due-to-layer-children-deep-expected.png
vendored
Normal file
After ![]() (image error) Size: 16 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/geometry/layer-due-to-layer-children-expected.png
vendored
Normal file
After ![]() (image error) Size: 7.0 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/geometry/vertical-scroll-composited-expected.png
vendored
Normal file
After ![]() (image error) Size: 157 KiB |
Before ![]() (image error) Size: 39 KiB After ![]() (image error) Size: 39 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
vendored
Normal file
After ![]() (image error) Size: 7.8 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png
vendored
Normal file
After ![]() (image error) Size: 6.7 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/img-layer-object-fit-expected.png
vendored
Normal file
After ![]() (image error) Size: 11 KiB |
Before ![]() (image error) Size: 23 KiB After ![]() (image error) Size: 23 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/lots-of-img-layers-expected.png
vendored
Normal file
After ![]() (image error) Size: 170 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/lots-of-img-layers-with-opacity-expected.png
vendored
Before ![]() (image error) Size: 100 KiB After ![]() (image error) Size: 100 KiB ![]() ![]() |
Before ![]() (image error) Size: 50 KiB After ![]() (image error) Size: 50 KiB ![]() ![]() |
Before ![]() (image error) Size: 13 KiB After ![]() (image error) Size: 13 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/overflow/mask-with-filter-expected.png
vendored
Normal file
After ![]() (image error) Size: 18 KiB |
Before ![]() (image error) Size: 3.6 KiB After ![]() (image error) Size: 3.6 KiB ![]() ![]() |
Before ![]() (image error) Size: 3.1 KiB After ![]() (image error) Size: 3.1 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/overflow/nested-render-surfaces-with-rotation-expected.png
vendored
Normal file
After ![]() (image error) Size: 17 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/overflow/rotate-clip-expected.png
vendored
Normal file
After ![]() (image error) Size: 5.6 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/overflow/rotate-then-clip-effect-interleave-expected.png
vendored
Normal file
After ![]() (image error) Size: 7.0 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/overflow/rotate-then-clip-expected.png
vendored
Normal file
After ![]() (image error) Size: 5.6 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/overflow/rotate-then-clip-z-order-interleave-expected.png
vendored
Normal file
After ![]() (image error) Size: 4.7 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png
vendored
Normal file
After ![]() (image error) Size: 3.0 KiB |
Before ![]() (image error) Size: 3.0 KiB After ![]() (image error) Size: 3.0 KiB ![]() ![]() |
Before ![]() (image error) Size: 2.9 KiB After ![]() (image error) Size: 2.9 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/perpendicular-layer-sorting-expected.png
vendored
Normal file
After ![]() (image error) Size: 8.5 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/perspective-interest-rect-expected.png
vendored
Normal file
After ![]() (image error) Size: 5.5 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/reflections/animation-inside-reflection-expected.png
vendored
Normal file
After ![]() (image error) Size: 7.4 KiB |
Before ![]() (image error) Size: 15 KiB After ![]() (image error) Size: 15 KiB ![]() ![]() |
Before ![]() (image error) Size: 9.3 KiB After ![]() (image error) Size: 9.3 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/reflections/nested-reflection-transition-expected.png
vendored
Normal file
After ![]() (image error) Size: 7.9 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/reflections/transform-inside-reflection-expected.png
vendored
Normal file
After ![]() (image error) Size: 10 KiB |
Before ![]() (image error) Size: 24 KiB After ![]() (image error) Size: 24 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/transform-3d-scales-different-x-y-expected.png
vendored
Normal file
After ![]() (image error) Size: 29 KiB |
Before ![]() (image error) Size: 43 KiB After ![]() (image error) Size: 43 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/visibility/visibility-image-layers-expected.png
vendored
Normal file
After ![]() (image error) Size: 10 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/compositing/visibility/visibility-simple-video-layer-expected.png
vendored
Normal file
After ![]() (image error) Size: 12 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/css3/blending/background-blend-mode-overlapping-accelerated-elements-expected.png
vendored
Normal file
After ![]() (image error) Size: 20 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/css3/filters/backdrop-filter-browser-zoom-expected.png
vendored
Normal file
After ![]() (image error) Size: 5.7 KiB |
Before ![]() (image error) Size: 27 KiB After ![]() (image error) Size: 27 KiB ![]() ![]() |
Before ![]() (image error) Size: 38 KiB After ![]() (image error) Size: 38 KiB ![]() ![]() |
Before ![]() (image error) Size: 39 KiB After ![]() (image error) Size: 39 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/css3/filters/effect-brightness-hw-expected.png
vendored
Normal file
After ![]() (image error) Size: 5.2 KiB |
Before ![]() (image error) Size: 54 KiB After ![]() (image error) Size: 54 KiB ![]() ![]() |
Before ![]() (image error) Size: 4.7 KiB After ![]() (image error) Size: 4.7 KiB ![]() ![]() |
Before ![]() (image error) Size: 7.9 KiB After ![]() (image error) Size: 7.9 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/css3/filters/effect-reference-colorspace-hw-expected.png
vendored
Normal file
After ![]() (image error) Size: 50 KiB |
Before ![]() (image error) Size: 77 KiB After ![]() (image error) Size: 77 KiB ![]() ![]() |
Before ![]() (image error) Size: 30 KiB After ![]() (image error) Size: 30 KiB ![]() ![]() |
Before ![]() (image error) Size: 42 KiB After ![]() (image error) Size: 42 KiB ![]() ![]() |
Before ![]() (image error) Size: 32 KiB After ![]() (image error) Size: 32 KiB ![]() ![]() |
Before ![]() (image error) Size: 11 KiB After ![]() (image error) Size: 11 KiB ![]() ![]() |
Before ![]() (image error) Size: 12 KiB After ![]() (image error) Size: 12 KiB ![]() ![]() |
Before ![]() (image error) Size: 21 KiB After ![]() (image error) Size: 21 KiB ![]() ![]() |
Before ![]() (image error) Size: 21 KiB After ![]() (image error) Size: 21 KiB ![]() ![]() |
5
third_party/blink/web_tests/platform/mac-mac14-arm64/external/wpt/screen-orientation/active-lock-expected.txt
vendored
Normal file
Before ![]() (image error) Size: 12 KiB After ![]() (image error) Size: 12 KiB ![]() ![]() |
Before ![]() (image error) Size: 71 KiB After ![]() (image error) Size: 71 KiB ![]() ![]() |
Before ![]() (image error) Size: 99 KiB After ![]() (image error) Size: 99 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/fast/clip/nestedTransparencyClip-expected.png
vendored
Normal file
After ![]() (image error) Size: 5.5 KiB |
Before ![]() (image error) Size: 24 KiB After ![]() (image error) Size: 24 KiB ![]() ![]() |
Before ![]() (image error) Size: 24 KiB After ![]() (image error) Size: 24 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/fast/frames/frame-set-scaling-rotate-expected.png
vendored
Normal file
After ![]() (image error) Size: 6.5 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/fast/frames/frame-set-scaling-skew-expected.png
vendored
Normal file
After ![]() (image error) Size: 14 KiB |
Before ![]() (image error) Size: 6.5 KiB After ![]() (image error) Size: 6.5 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/http/tests/media/video-frame-size-change-expected.png
vendored
Before ![]() (image error) Size: 116 KiB After ![]() (image error) Size: 116 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/images/yuv-decode-eligible/color-profile-layer-expected.png
vendored
Normal file
After ![]() (image error) Size: 144 KiB |
Before ![]() (image error) Size: 79 KiB After ![]() (image error) Size: 79 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/media/color-profile-video-expected.png
vendored
Before ![]() (image error) Size: 31 KiB After ![]() (image error) Size: 31 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/media/color-profile-video-seek-expected.png
vendored
Before ![]() (image error) Size: 29 KiB After ![]() (image error) Size: 29 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/media/color-profile-video-seek-filter-expected.png
vendored
Before ![]() (image error) Size: 33 KiB After ![]() (image error) Size: 33 KiB ![]() ![]() |
Before ![]() (image error) Size: 26 KiB After ![]() (image error) Size: 26 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/media/controls/paint-controls-webkit-appearance-none-expected.png
vendored
Normal file
After ![]() (image error) Size: 9.8 KiB |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/media/track/track-cue-rendering-ruby-expected.png
vendored
Before ![]() (image error) Size: 74 KiB After ![]() (image error) Size: 74 KiB ![]() ![]() |
BIN
third_party/blink/web_tests/platform/mac-mac14-arm64/media/video-colorspace-yuv420-expected.png
vendored
Normal file
After ![]() (image error) Size: 20 KiB |