0

[Blink] Switch to using Graphite by default in layout tests on Mac14-ARM

Graphite has stuck in fieldtrial_testing_config.json and we are
experimenting on stable in Mac-ARM, so it's time to move the layout tests
on this platform to use Graphite. Rebaselines tests as necessary via
third_party/blink/tools/blink_tool.py rebaseline-cl .

In this CL we move only Mac14 to limit the scope of the change. We will
follow up with other OS versions.

Sheriffs: If this CL results in layout test failures please
rebaseline/add suppressions if at all feasible and CC me rather than
reverting the CL.

Include-Ci-Only-Tests: true
Bug: 40937352
Change-Id: I123cccc7ee9c7cec32fe8f4596c744a495b6bf25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179215
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413635}
This commit is contained in:
Colin Blundell
2025-01-30 11:29:20 -08:00
committed by Chromium LUCI CQ
parent 47d618fa56
commit 8317de3175
199 changed files with 48 additions and 2 deletions
content/web_test/browser
third_party/blink/web_tests
TestExpectations
flag-specific
platform
mac-mac14-arm64
compositing
3d-corners-expected.png3d-cube-expected.pngbackface-visibility-transformed-expected.png
culling
direct-image-compositing-expected.pngflat-with-transformed-child-expected.png
geometry
gestures
img-layer-object-fit-expected.pnglayers-inside-overflow-scroll-expected.pnglots-of-img-layers-expected.pnglots-of-img-layers-with-opacity-expected.png
masks
overflow
overlap-blending
perpendicular-layer-sorting-expected.pngperspective-interest-rect-expected.png
reflections
self-painting-layers-expected.pngtransform-3d-scales-different-x-y-expected.png
video
visibility
css3
external
wpt
screen-orientation
fast
http
images
media
overflow
paint
scrollbars
scaled-rendering
transforms
transitions
virtual
exotic-color-space
gpu-rasterization
images
2-dht-expected.pngalt-text-wrapping-expected.pngcolor-jpeg-with-color-profile-expected.pngcolor-profile-background-image-cross-fade-png-expected.pngcolor-profile-border-image-expected.pngcross-fade-invalidation-expected.pngcross-fade-overflow-position-expected.pngimage-in-map-expected.pngimagemap-circle-focus-ring-expected.pngimagemap-focus-ring-expected.pngimagemap-focus-ring-in-positioned-container-expected.pngimagemap-focus-ring-outline-color-expected.pngimagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.pngimagemap-focus-ring-outline-color-not-inherited-from-map-expected.pngimagemap-focus-ring-with-paint-root-offset-expected.pngimagemap-focus-ring-with-scale-transform-expected.pngimagemap-focus-ring-zoom-expected.pngimagemap-overflowing-circle-focus-ring-expected.pngimagemap-overflowing-polygon-focus-ring-expected.pngimagemap-polygon-focus-ring-expected.png
png-suite
rendering-broken-0px-images-expected.pngrendering-broken-0px-images-quirk-expected.pngrendering-broken-10px-images-expected.pngrendering-broken-16px-images-expected.pngrendering-broken-1px-images-expected.pngrendering-broken-block-flow-images-expected.pngrendering-broken-images-empty-alt-expected.pngrendering-broken-images-expected.pngrgb-png-with-cmyk-color-profile-expected.pngsprite-no-bleed-expected.png
yuv-decode-eligible
gpu
off-main-thread-css-paint
http
oopr-canvas2d
scalefactor200

@ -48,6 +48,10 @@
#include "ui/gl/gl_implementation.h"
#include "ui/gl/gl_switches.h"
#if BUILDFLAG(IS_MAC)
#include "base/mac/mac_util.h"
#endif
#if BUILDFLAG(ENABLE_PPAPI)
#include "content/public/test/ppapi_test_utils.h"
#endif
@ -269,12 +273,30 @@ void WebTestBrowserMainRunner::Initialize() {
if (!command_line.HasSwitch(switches::kEnableGpuRasterization))
command_line.AppendSwitch(switches::kDisableGpuRasterization);
#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM64)
if (base::mac::MacOSMajorVersion() == 14) {
// If Graphite is not explicitly disabled, enable it. This is to use
// Graphite as the renderer for web tests on all bots for this platform
// except those explicitly testing Ganesh.
if (!command_line.HasSwitch(switches::kDisableSkiaGraphite)) {
command_line.AppendSwitch(switches::kEnableSkiaGraphite);
}
} else {
// If Graphite is not explicitly enabled, disable it. This is to keep using
// Ganesh as renderer for web tests for now until we finish rebaselining all
// images for Graphite renderer.
if (!command_line.HasSwitch(switches::kEnableSkiaGraphite)) {
command_line.AppendSwitch(switches::kDisableSkiaGraphite);
}
}
#else
// If Graphite is not explicitly enabled, disable it. This is to keep using
// Ganesh as renderer for web tests for now until we finish rebaselining all
// images for Graphite renderer.
if (!command_line.HasSwitch(switches::kEnableSkiaGraphite)) {
command_line.AppendSwitch(switches::kDisableSkiaGraphite);
}
#endif
// If the virtual test suite didn't specify a display color space, then
// force sRGB.

@ -53,6 +53,27 @@ external/wpt/infrastructure/reftest/reftest_ref_timeout.html [ Timeout ]
external/wpt/infrastructure/reftest/reftest_timeout.html [ Timeout ]
wpt_internal/infrastructure/fail-before-timeout.html [ Timeout ]
# Graphite failures on Mac-ARM
# YUV edge sampling bug
crbug.com/329041548 [ Mac14-arm64 ] media/video-colorspace-yuv422.html [ Failure ]
crbug.com/dawn/2456 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Crash ]
crbug.com/dawn/2456 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Crash ]
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/drop-shadow-currentcolor-dynamic-003.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] external/wpt/css/filter-effects/backdrop-filter-backdrop-root-opacity.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] external/wpt/css/css-masking/mask-image/mask-opacity-1e.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] external/wpt/css/filter-effects/backdrop-filter-clip-rect-2.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] external/wpt/css/filter-effects/drop-shadow-currentcolor-dynamic-003.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/backdrop-filter-clip-rect-2.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] virtual/gpu-rasterization/external/wpt/css/css-images/cross-fade-premultiplied-alpha.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] virtual/off-main-thread-css-paint/http/tests/csspaint/transform-with-page-zoom-003.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/backdrop-filter-backdrop-root-opacity.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] external/wpt/css/filter-effects/backdrop-filter-transform.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] virtual/off-main-thread-css-paint/http/tests/csspaint/paint2d-zoom.html [ Failure ] # Reftest image failure
[ Mac14-arm64 ] virtual/scalefactor200/external/wpt/css/filter-effects/backdrop-filter-transform.html [ Failure ] # Reftest image failure
# We don't support extracting fuzzy information from .ini files, which these
# WPT infrastructure tests rely on.
crbug.com/997202 external/wpt/infrastructure/reftest/legacy/reftest_fuzzy_chain_ini.html [ Failure ]
@ -3006,7 +3027,6 @@ crbug.com/390000672 [ Mac12-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding
crbug.com/378158966 crbug.com/390000672 [ Mac13 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure Timeout ]
crbug.com/390000672 [ Mac13-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure ]
crbug.com/378158966 crbug.com/390000672 [ Mac14 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure Timeout ]
crbug.com/390000672 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure ]
crbug.com/378158966 crbug.com/390000672 [ Mac15 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.html?vp9_p2 [ Failure Timeout ]
crbug.com/390000672 [ Mac11 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
crbug.com/390000672 [ Mac11-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
@ -3015,7 +3035,6 @@ crbug.com/390000672 [ Mac12-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding
crbug.com/378158966 crbug.com/390000672 [ Mac13 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure Timeout ]
crbug.com/390000672 [ Mac13-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
crbug.com/378158966 crbug.com/390000672 [ Mac14 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure Timeout ]
crbug.com/390000672 [ Mac14-arm64 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure ]
crbug.com/378158966 crbug.com/390000672 [ Mac15 ] external/wpt/webcodecs/per-frame-qp-encoding.https.any.worker.html?vp9_p2 [ Failure Timeout ]
crbug.com/377977965 [ Linux ] external/wpt/webdriver/tests/bidi/browser/get_client_windows/get_client_windows.py [ Failure ]
crbug.com/377576485 [ Mac15 ] external/wpt/webrtc-extensions/RTCRtpParameters-adaptivePtime.html [ Timeout ]

Binary file not shown.

After

(image error) Size: 6.2 KiB

Binary file not shown.

After

(image error) Size: 18 KiB

Binary file not shown.

After

(image error) Size: 3.3 KiB

Binary file not shown.

Before

(image error) Size: 64 KiB

After

(image error) Size: 63 KiB

Binary file not shown.

After

(image error) Size: 4.6 KiB

Binary file not shown.

After

(image error) Size: 7.0 KiB

Binary file not shown.

After

(image error) Size: 157 KiB

Binary file not shown.

After

(image error) Size: 11 KiB

Binary file not shown.

After

(image error) Size: 170 KiB

Binary file not shown.

Before

(image error) Size: 100 KiB

After

(image error) Size: 100 KiB

Binary file not shown.

After

(image error) Size: 18 KiB

Binary file not shown.

After

(image error) Size: 5.6 KiB

Binary file not shown.

After

(image error) Size: 5.6 KiB

Binary file not shown.

After

(image error) Size: 8.5 KiB

Binary file not shown.

After

(image error) Size: 5.5 KiB

Binary file not shown.

After

(image error) Size: 29 KiB

Binary file not shown.

After

(image error) Size: 10 KiB

Binary file not shown.

After

(image error) Size: 5.7 KiB

Binary file not shown.

After

(image error) Size: 5.2 KiB

Binary file not shown.

After

(image error) Size: 50 KiB

File diff suppressed because one or more lines are too long

Binary file not shown.

After

(image error) Size: 5.5 KiB

Binary file not shown.

After

(image error) Size: 6.5 KiB

Binary file not shown.

After

(image error) Size: 14 KiB

Binary file not shown.

Before

(image error) Size: 116 KiB

After

(image error) Size: 116 KiB

Binary file not shown.

After

(image error) Size: 144 KiB

Binary file not shown.

Before

(image error) Size: 31 KiB

After

(image error) Size: 31 KiB

Binary file not shown.

Before

(image error) Size: 29 KiB

After

(image error) Size: 29 KiB

Binary file not shown.

Before

(image error) Size: 33 KiB

After

(image error) Size: 33 KiB

Binary file not shown.

Before

(image error) Size: 74 KiB

After

(image error) Size: 74 KiB

Binary file not shown.

After

(image error) Size: 20 KiB

Some files were not shown because too many files have changed in this diff Show More