chromium/src
0
Fork 0
Code Activity

Switch from NOTREACHED() to CHECK_OP in //pdf

Browse Source 
This follow-up to https://crrev.com/1346787 rewrites:

if (!foo) {
  NOTREACHED();
}

to CHECK(foo);

Change-Id: I57772df51ecc6e589dfdf7e2672ed34d70aab0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5813468
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1347063}
This commit is contained in:
Lei Zhang
2024-08-26 23:46:55 +00:00
committed by Chromium LUCI CQ
parent 082ead07ac
commit 844ff63776
2 changed files with 9 additions and 15 deletions

19
pdf/paint_manager.cc

@ -13,10 +13,10 @@
#include "base/auto_reset.h"
#include "base/check.h"
#include "base/check_op.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/location.h"
#include "base/notreached.h"
#include "base/task/sequenced_task_runner.h"
#include "base/task/single_thread_task_runner.h"
#include "pdf/paint_ready_rect.h"
@ -99,17 +99,14 @@ void PaintManager::SetTransform(float scale,
if (!surface_)
return;
if (scale <= 0.0f) {
NOTREACHED();
} else {
// translate_with_origin = origin - scale * origin - translate
gfx::Vector2dF translate_with_origin = origin.OffsetFromOrigin();
translate_with_origin.Scale(1.0f - scale);
translate_with_origin.Subtract(translate);
CHECK_GT(scale, 0.0f);
// translate_with_origin = origin - scale * origin - translate
gfx::Vector2dF translate_with_origin = origin.OffsetFromOrigin();
translate_with_origin.Scale(1.0f - scale);
translate_with_origin.Subtract(translate);
// TODO(crbug.com/40203030): Should update be deferred until `Flush()`?
client_->UpdateLayerTransform(scale, translate_with_origin);
}
// TODO(crbug.com/40203030): Should update be deferred until `Flush()`?
client_->UpdateLayerTransform(scale, translate_with_origin);
if (!schedule_flush)
return;

5
pdf/pdf_view_web_plugin.cc

@ -1992,10 +1992,7 @@ void PdfViewWebPlugin::UpdateScaledValues() {
}
void PdfViewWebPlugin::UpdateScale(float scale) {
if (scale <= 0.0f) {
NOTREACHED();
}
CHECK_GT(scale, 0.0f);
viewport_to_dip_scale_ = scale;
UpdateScaledValues();
}