[Blink] Enforce skipping of tests defined in TestExpectations on Android
Tests listed in NeverFixedTests were unintentionally being run on Android because they were defined in the test list. This change adds the `skipped always` flag to enforce the expected skipping behavior. Fixed: 353782184, 375011567 Change-Id: Ic1a0921651a4da31c7d9ddac6033163d2dc86381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5955520 Commit-Queue: An Sung <ansung@google.com> Reviewed-by: Haiyang Pan <hypan@google.com> Reviewed-by: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#1372971}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
55daddf681
commit
847cd01fdd
infra/config
generated
builders
ci
android-13-x64-rel
targets
android-chrome-13-x64-wpt-android-specific
targets
android-webview-13-x64-wpt-android-specific
targets
try
android-13-x64-rel
targets
android-chrome-13-x64-wpt-android-specific
targets
android-webview-13-x64-wpt-android-specific
targets
android-x64-rel
targets
targets
@ -3541,6 +3541,8 @@
|
||||
"isolated_scripts": [
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
@ -3622,6 +3624,8 @@
|
||||
},
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
|
@ -3,6 +3,8 @@
|
||||
"isolated_scripts": [
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
|
@ -3,6 +3,8 @@
|
||||
"isolated_scripts": [
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
|
@ -3541,6 +3541,8 @@
|
||||
"isolated_scripts": [
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
@ -3622,6 +3624,8 @@
|
||||
},
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
|
@ -3,6 +3,8 @@
|
||||
"isolated_scripts": [
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
|
@ -3,6 +3,8 @@
|
||||
"isolated_scripts": [
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
|
@ -3598,6 +3598,8 @@
|
||||
"isolated_scripts": [
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
@ -3679,6 +3681,8 @@
|
||||
},
|
||||
{
|
||||
"args": [
|
||||
"--skipped",
|
||||
"always",
|
||||
"--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
|
||||
],
|
||||
"description": "Run with android_33_google_apis_x64",
|
||||
|
@ -23,6 +23,8 @@ targets.tests.gtest_test(
|
||||
targets.tests.isolated_script_test(
|
||||
name = "android_blink_wpt_tests",
|
||||
args = [
|
||||
"--skipped",
|
||||
"always",
|
||||
],
|
||||
binary = "chrome_public_wpt",
|
||||
)
|
||||
@ -2886,6 +2888,8 @@ targets.tests.gtest_test(
|
||||
targets.tests.isolated_script_test(
|
||||
name = "webview_blink_wpt_tests",
|
||||
args = [
|
||||
"--skipped",
|
||||
"always",
|
||||
],
|
||||
binary = "trichrome_webview_wpt_64",
|
||||
)
|
||||
|
Reference in New Issue
Block a user