chromium/src
0
Fork 0
Code Activity

[v8] Prepare parameters for next iteration on finch experiment

Browse Source 
The initial finch experiment is finished and the parameters were chosen
according to the data.
The next iteration of the finch experiment is supposed to verify the
local maximum in the three-dimensional parameter space by modifying each
individual parameter and checking the effect on the different metrics.

This CL sets the defaults of the feature parameters to the current
defaults in V8 (see https://crrev.com/c/5412938) and prepares the field
trial config for the next iteration of the experiment.

R=leszeks@chromium.org

Bug: 40945417
Change-Id: I82b637ec59c0a7a4e426224bcd1f96293f5e67e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5600266
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1310646}
This commit is contained in:
Clemens Backes
2024-06-05 15:44:54 +00:00
committed by Chromium LUCI CQ
parent ac51b05f32
commit 859c9697d8
2 changed files with 29 additions and 30 deletions

8
gin/gin_features.cc

@ -316,8 +316,8 @@ BASE_FEATURE(kWebAssemblyTurboshaftInstructionSelection,
"WebAssemblyTurboshaftInstructionSelection",
base::FEATURE_DISABLED_BY_DEFAULT);
// Feature for more aggressive code caching (https://crbug.com/v8/14411) and
// three parameters to control caching behavior.
// Feature for more aggressive code caching (https://crbug.com/v8/14411,
// https://crbug.com/40945417) and three parameters to control caching behavior.
BASE_FEATURE(kWebAssemblyMoreAggressiveCodeCaching,
"WebAssemblyMoreAggressiveCodeCaching",
base::FEATURE_DISABLED_BY_DEFAULT);
@ -326,10 +326,10 @@ const base::FeatureParam<int> kWebAssemblyMoreAggressiveCodeCachingThreshold{
1'000};
const base::FeatureParam<int> kWebAssemblyMoreAggressiveCodeCachingTimeoutMs{
&kWebAssemblyMoreAggressiveCodeCaching, "WebAssemblyCodeCachingTimeoutMs",
5000};
2000};
const base::FeatureParam<int>
kWebAssemblyMoreAggressiveCodeCachingHardThreshold{
&kWebAssemblyMoreAggressiveCodeCaching,
"WebAssemblyCodeCachingHardThreshold", 100'000};
"WebAssemblyCodeCachingHardThreshold", 1'000'000};
} // namespace features

51
testing/variations/fieldtrial_testing_config.json

@ -23017,56 +23017,55 @@
"windows"
],
"experiments": [
{
"name": "3_CacheAfter5Sec",
"params": {
"WebAssemblyCodeCachingHardThreshold": "100000",
"WebAssemblyCodeCachingThreshold": "1000",
"WebAssemblyCodeCachingTimeoutMs": "5000"
},
"enable_features": [
"WebAssemblyMoreAggressiveCodeCaching"
]
},
{
"name": "1_ReducedThreshold",
"params": {
"WebAssemblyCodeCachingHardThreshold": "100000",
"WebAssemblyCodeCachingThreshold": "100000",
"WebAssemblyCodeCachingTimeoutMs": "0"
"WebAssemblyCodeCachingThreshold": "200"
},
"enable_features": [
"WebAssemblyMoreAggressiveCodeCaching"
]
},
{
"name": "2_CacheAfter30Sec",
"name": "2_IncreasedThreshold",
"params": {
"WebAssemblyCodeCachingHardThreshold": "1000000",
"WebAssemblyCodeCachingThreshold": "1000",
"WebAssemblyCodeCachingTimeoutMs": "30000"
"WebAssemblyCodeCachingThreshold": "10000"
},
"enable_features": [
"WebAssemblyMoreAggressiveCodeCaching"
]
},
{
"name": "4_CacheAfter2Sec",
"name": "3_ReducedHardThreshold",
"params": {
"WebAssemblyCodeCachingHardThreshold": "1000000",
"WebAssemblyCodeCachingThreshold": "1",
"WebAssemblyCodeCachingTimeoutMs": "2000"
"WebAssemblyCodeCachingHardThreshold": "200000"
},
"enable_features": [
"WebAssemblyMoreAggressiveCodeCaching"
]
},
{
"name": "5_CacheAfter1Sec",
"name": "4_IncreasedHardThreshold",
"params": {
"WebAssemblyCodeCachingHardThreshold": "10000",
"WebAssemblyCodeCachingThreshold": "1",
"WebAssemblyCodeCachingTimeoutMs": "1000"
"WebAssemblyCodeCachingHardThreshold": "10000000"
},
"enable_features": [
"WebAssemblyMoreAggressiveCodeCaching"
]
},
{
"name": "5_ReducedTimeout",
"params": {
"WebAssemblyCodeCachingTimeoutMs": "500"
},
"enable_features": [
"WebAssemblyMoreAggressiveCodeCaching"
]
},
{
"name": "6_IncreasedTimeout",
"params": {
"WebAssemblyCodeCachingTimeoutMs": "10000"
},
"enable_features": [
"WebAssemblyMoreAggressiveCodeCaching"