fixup! [iOS Blink] Support the preparation for decoupling creation/initialization of context
As the review comment[1], this CL simply uses `!use_blink` variable for has_tight_factory_registration and has_tight_context_initialization variables. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5716588/4/components/keyed_service/core/BUILD.gn#90 Bug: 342112724 Change-Id: Ia570260a40e8f8e4fb35a8bbe14076c5f254df71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5724728 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/main@{#1331523}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
6396fdbaa6
commit
885e636ea3
@@ -60,7 +60,7 @@ buildflag_header("features") {
|
||||
# embedders. This will requires fixing the registration of all factories
|
||||
# to happen before the creation of the first context (i.e. by listing all
|
||||
# factories in the `Ensure.*KeyedServiceFactoriesBuilt` free functions).
|
||||
has_tight_factory_registration = is_ios && !use_blink
|
||||
has_tight_factory_registration = !use_blink
|
||||
|
||||
# If this flag is set to `true`, then `KeyedServiceTemplatedFactory` will
|
||||
# be allowed to rely on the fact that the lifetime of the context and the
|
||||
@@ -75,7 +75,7 @@ buildflag_header("features") {
|
||||
# in the correct order. Additionally, this requires changing the factories of
|
||||
# services created before CreateContextServices to override the method
|
||||
# `ServiceIsRequiredForContextInitializatio`n to return true.
|
||||
has_tight_context_initialization = is_ios && !use_blink
|
||||
has_tight_context_initialization = !use_blink
|
||||
|
||||
# If this flag is set to `true`, then `KeyedServiceTemplatedFactory` will
|
||||
# expose the deprecated `Associate`/`Disassociate`API. Those API can break
|
||||
|
Reference in New Issue
Block a user