0

Start shipping the public devtools

[ahead of time CL; will land after blockers get removed]

 - We remove the switch that causes devtools-internal to be built;

 - As we will no longer build devtools-internal we will need to make sure that we no longer bundle the internal paths, therefore land [1] . For more context: we were not able to add paths that do not exist to the archive configuration see [2], [3], [4];

 - To make sure the next run of chrome/release/linux64 builder will be correctly configured we will force roll the revision where the src-internal CL landed [1];

 - And finally as the archive will no longer contain devtools-internal files we need to remove the switch for the remote debug URL inside devtools_http_handler.cc;

For details see: http://go/chrome-devtools:remove-internal-plan

[1] https://crrev.com/i/7837866
[2] https://crrev.com/i/7833986
[3] https://ci.chromium.org/ui/p/chrome/builders/official/linux64/8516/overview
[4] http://go/chrome-devtools:remove-internal-plan?tab=t.0#heading=h.bgii89t5c32j

Bug: 379040628
Change-Id: I703d322271c2b9b568cfcfdeb13a1894f18b469b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6031797
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1391516}
This commit is contained in:
Liviu Rau
2024-12-04 08:36:22 +00:00
committed by Chromium LUCI CQ
parent 42d1d454df
commit 8971a5fc17
4 changed files with 6 additions and 19 deletions
DEPS
build/config
content/browser/devtools
internal

2
DEPS

@ -276,7 +276,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling V8
# and whatever else without interference from each other.
'src_internal_revision': '4acc02cf1a68120636a7d31b3a54c8280a284c4e',
'src_internal_revision': '1e958d0d8b59fef6eaee70124cafdf4f89c6d8ae',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling Skia
# and whatever else without interference from each other.

@ -17,17 +17,10 @@ declare_args() {
# of the Chromium version when is_chrome_branded is false.
# devtools_grd_location is the location of the GRD file listing all DevTools
# resources.
if (is_chrome_branded) {
devtools_root_location = "third_party/devtools-frontend-internal"
devtools_location = "$devtools_root_location/devtools-frontend/"
devtools_grd_location =
"$devtools_root_location/chrome_devtools_resources.grd"
} else {
devtools_root_location = "third_party/devtools-frontend/src"
devtools_location = "third_party/devtools-frontend/src/"
devtools_grd_location =
"$devtools_root_location/front_end/devtools_resources.grd"
}
devtools_root_location = "third_party/devtools-frontend/src"
devtools_location = "third_party/devtools-frontend/src/"
devtools_grd_location =
"$devtools_root_location/front_end/devtools_resources.grd"
} else {
# DevTools is building a standalone version
devtools_location = ""

@ -39,7 +39,6 @@
#include "base/threading/thread.h"
#include "base/uuid.h"
#include "base/values.h"
#include "build/branding_buildflags.h"
#include "build/build_config.h"
#include "content/browser/devtools/devtools_manager.h"
#include "content/public/browser/browser_task_traits.h"
@ -99,12 +98,7 @@ const int32_t kSendBufferSizeForDevTools = 256 * 1024 * 1024; // 256Mb
const int32_t kReceiveBufferSizeForDevTools = 100 * 1024 * 1024; // 100Mb
const char kRemoteUrlPattern[] =
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
"https://chrome-devtools-frontend.appspot.com/serve_internal_file/%s/"
"%s.html";
#else
"https://chrome-devtools-frontend.appspot.com/serve_rev/%s/%s.html";
#endif
constexpr net::NetworkTrafficAnnotationTag
kDevtoolsHttpHandlerTrafficAnnotation =