chromium/src
0
Fork 0
Code Activity

[CrOS Cellular] Fix eSIM setup dialog size regression

Browse Source 
This CL fixes issue with eSIM dialog size in the final screen.
This was introduced in https://crrev.com/c/2966178 which removed
the page body height since sub-elements were all sized correctly
but the image in the final screen is set as a background and
does not set height. Fixed by adding a min-height for the page
body.

Fixed eSIM setup screens:
http://screen/4mfYCFHgeSsvhpq.png
http://screen/3curk6CujzpEqkU.png
http://screen/7hb5i8WS3RM6afk.png
http://screen/9M7csBHacjs9RBT.png
http://screen/ATfUskeQN5M3xte.png
http://screen/7Mai9nPvbcCrscb.png

pSIM screen size is maintained:
http://screen/C6Y3gDqnVpKxaBC.png
http://screen/9WV4j5Q9NnWhwbC.png

Bug: 1221558
Change-Id: Ic4f1a5433da594e4f29ba04ec270d2710cd31d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2971616
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894035}
This commit is contained in:
Azeem Arshad
2021-06-19 00:18:52 +00:00
committed by Chromium LUCI CQ
parent 397644afe3
commit 8a59acd160
2 changed files with 2 additions and 0 deletions
ui/webui/resources/cr_components/chromeos/cellular_setup
confirmation_code_page.htmlfinal_page.html

1
ui/webui/resources/cr_components/chromeos/cellular_setup/confirmation_code_page.html

@ -9,6 +9,7 @@
<template>
<style include="iron-flex iron-positioning">
[slot='page-body'] {
height: 282px;
margin-top: -20px;
}

1
ui/webui/resources/cr_components/chromeos/cellular_setup/final_page.html

@ -14,6 +14,7 @@
background-position: center center;
background-repeat: no-repeat;
background-size: contain;
height: 242px;
}
.error[slot='page-body'] {