0

Migrate TODOs referencing old crbug IDs to the new issue tracker IDs

The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:

- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)

Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.

#crbug-todo-migration

Bug: b/321899722
Change-Id: Ia2d67c29664238bee7a06b2f0a22fa438c2cd0e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457736
Commit-Queue: Alison Gale <agale@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1288140}
This commit is contained in:
Alison Gale
2024-04-16 17:15:12 +00:00
committed by Chromium LUCI CQ
parent 4602cd75ff
commit 8a79976564
102 changed files with 123 additions and 123 deletions
ash
app_list
capture_mode
clipboard
components
constants
display
drag_drop
fast_ink
host
keyboard
login
multi_capture
public
rotator
shelf
shortcut_viewer
style
system
test
utility
wallpaper
webui
common
resources
eche_app_ui
media_app_ui
projector_app
public
settings
public
constants
wm

@ -681,7 +681,7 @@ bool AppListControllerImpl::GoHome(int64_t display_id) {
// animation can interfere with WindowTransformToHomeScreenAnimation
// visuals.
//
// TODO(https://crbug.com/1019531): This can be removed once transitions
// TODO(crbug.com/40656009): This can be removed once transitions
// between in-app state and home do not cause work area updates.
std::vector<std::unique_ptr<wm::ScopedAnimationDisabler>>
animation_disablers;
@ -1775,7 +1775,7 @@ void AppListControllerImpl::ResetHomeLauncherIfShown() {
fullscreen_presenter_->GetView()->CloseOpenedPage();
// Refresh the suggestion chips with empty query.
// TODO(crbug.com/1269115): Switch to client_->StartZeroStateSearch()?
// TODO(crbug.com/40204937): Switch to client_->StartZeroStateSearch()?
StartSearch(std::u16string());
}

@ -358,7 +358,7 @@ TEST_P(AppListControllerImplTest, VirtualKeyboardNotShownWhenUserStartsTyping) {
// Verifies that closing notification by gesture should not dismiss the AppList.
// (see https://crbug.com/948344)
// TODO(crbug.com/1120501): Test is flaky on ASAN builds.
// TODO(crbug.com/40714854): Test is flaky on ASAN builds.
TEST_P(AppListControllerImplTest, MAYBE_CloseNotificationWithAppListShown) {
ShowAppListNow(AppListViewState::kFullscreenAllApps);

@ -4306,7 +4306,7 @@ TEST_F(AppListPresenterHomeLauncherTest, HomeButtonDismissesSearchResults) {
// Enable accessibility feature that forces home button to be shown even with
// kHideShelfControlsInTabletMode enabled.
// TODO(https://crbug.com/1050544) Use the a11y feature specific to showing
// TODO(crbug.com/40673209) Use the a11y feature specific to showing
// navigation buttons in tablet mode once it lands.
Shell::Get()->accessibility_controller()->autoclick().SetEnabled(true);

@ -38,7 +38,7 @@ AppListItem* AppListItemList::FindItem(const std::string& id) {
return nullptr;
}
// TODO(https://crbug.com/883971): Make it return iterator to avoid unnecessary
// TODO(crbug.com/40593633): Make it return iterator to avoid unnecessary
// check in this code.
bool AppListItemList::FindItemIndex(const std::string& id, size_t* index) {
for (size_t i = 0; i < app_list_items_.size(); ++i) {

@ -68,7 +68,7 @@ class APP_LIST_MODEL_EXPORT AppListItemList {
// item position) but the consumer. If `AppListItemList` wants to trigger the
// update on app list item positions, it should always use the APIs provided
// by `app_list_model_delegate_`.
// TODO(https://crbug.com/125779): It is confusing to have a method that
// TODO(crbug.com/40200822): It is confusing to have a method that
// shares the similar functionality with a delegate but is only available to
// external classes. Fixing this issue can eliminate such confusion.
bool SetItemPosition(AppListItem* item, syncer::StringOrdinal new_position);

@ -345,7 +345,7 @@ void AppListSearchView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
base::NumberToString16(last_search_result_count_), query);
}
} else {
// TODO(crbug.com/1204551): New(?) accessibility announcement. We used to
// TODO(crbug.com/40180065): New(?) accessibility announcement. We used to
// have a zero state A11Y announcement but zero state is removed for the
// bubble launcher.
value = std::u16string();

@ -307,7 +307,7 @@ TEST_F(SearchBoxViewTest, CloseButtonVisibleInZeroStateSearchBox) {
EXPECT_FALSE(view()->filter_and_close_button_container()->GetVisible());
}
// TODO(crbug.com/1446550): Re-enable this test
// TODO(crbug.com/40913066): Re-enable this test
TEST_F(SearchBoxViewTest,
DISABLED_AccessibilityHintRemovedWhenSearchBoxActive) {
EXPECT_TRUE(IsValidSearchBoxAccessibilityHint(
@ -935,7 +935,7 @@ TEST_F(SearchBoxViewAutocompleteTest, SearchBoxAutocompletesNotHandledForIME) {
EXPECT_EQ("", view()->GetSearchBoxGhostTextForTest());
}
// TODO(crbug.com/1216082): Refactor the above tests to use AshTestBase.
// TODO(crbug.com/40184650): Refactor the above tests to use AshTestBase.
class SearchBoxViewAppListBubbleTest : public AshTestBase {
public:
SearchBoxViewAppListBubbleTest() = default;

@ -1329,7 +1329,7 @@ gfx::Rect SearchResultView::GetIconBadgeViewBounds(
}
void SearchResultView::Layout(PassKey) {
// TODO(crbug/1311101) add test coverage for search result view layout.
// TODO(crbug.com/40220083) add test coverage for search result view layout.
gfx::Rect rect(GetContentsBounds());
if (rect.IsEmpty()) {
return;

@ -53,7 +53,7 @@ namespace {
// |
// + Projector bar widget
//
// TODO(https://crbug.com/1253011): Revise this parenting and z-ordering once
// TODO(crbug.com/40199022): Revise this parenting and z-ordering once
// the deprecated Projector toolbar is removed and replaced by the shelf-pod
// based new tools.
aura::Window* GetWidgetParent(aura::Window* window_being_recorded) {

@ -1125,7 +1125,7 @@ gfx::Rect ClipboardHistoryControllerImpl::CalculateAnchorRect() const {
// Some web apps render the caret in an IFrame, and we will not get the
// bounds in that case.
// TODO(https://crbug.com/1099930): Show the menu in the middle of the
// TODO(crbug.com/40137728): Show the menu in the middle of the
// webview if the bounds are empty.
ui::TextInputClient* text_input_client =
host->GetInputMethod()->GetTextInputClient();

@ -635,7 +635,7 @@ TEST_F(ClipboardHistoryControllerObserverTest,
WriteTextToClipboardAndConfirm(u"A");
}
// TODO(crbug.com/1459385): Re-enable this test
// TODO(crbug.com/40274291): Re-enable this test
#if BUILDFLAG(IS_CHROMEOS)
#define MAYBE_ChangeSessionStateWithNonEmptyHistory \
DISABLED_ChangeSessionStateWithNonEmptyHistory

@ -33,7 +33,7 @@ ClipboardHistoryMainButton::ClipboardHistoryMainButton(
// Let the parent handle accessibility features.
GetViewAccessibility().SetIsIgnored(true);
// TODO(crbug.com/1205227): Revisit if this comment makes sense still. It was
// TODO(crbug.com/40764470): Revisit if this comment makes sense still. It was
// attached to CreateInkDrop() but sounds more about talking about a null
// CreateInkDropHighlight(), but at the time of writing the class inherited
// from Button and had no other InkDrop-related override than CreateInkDrop().

@ -66,7 +66,7 @@ class ArcAudioBridge : public KeyedService,
bool muted_ = false;
// Avoids sending requests when the instance is unavailable.
// TODO(crbug.com/549195): Remove once the root cause is fixed.
// TODO(crbug.com/41213400): Remove once the root cause is fixed.
bool available_ = false;
};

@ -615,7 +615,7 @@ gfx::Range ArcImeService::GetAutocorrectRange() const {
}
gfx::Rect ArcImeService::GetAutocorrectCharacterBounds() const {
// TODO(https://crbug.com/952757): Implement this method.
// TODO(crbug.com/40623107): Implement this method.
NOTIMPLEMENTED_LOG_ONCE();
return gfx::Rect();
}

@ -41,7 +41,7 @@ struct Buffer {
// Next ordinal: 2
union DecoderBuffer {
Buffer buffer@0;
// TODO(https://crbug.com/999900): Replace with actual placeholder type.
// TODO(crbug.com/40643013): Replace with actual placeholder type.
uint8 end_of_stream@1;
};

@ -131,7 +131,7 @@ class ConnectionHolderImpl {
if (!instance_ || !host_)
return;
// When both the instance and host are ready, start connection.
// TODO(crbug.com/750563): Fix the race issue.
// TODO(crbug.com/40532557): Fix the race issue.
auto receiver = std::make_unique<mojo::Receiver<HostType>>(host_);
mojo::PendingRemote<HostType> host_proxy;
receiver->Bind(host_proxy.InitWithNewPipeAndPassReceiver());

@ -18,7 +18,7 @@ enum class AppType {
ARC_APP,
CROSTINI_APP,
SYSTEM_APP,
// TODO(crbug.com/1090663): Migrate this into BROWSER.
// TODO(crbug.com/40133859): Migrate this into BROWSER.
LACROS,
kMaxValue = LACROS,

@ -1270,7 +1270,7 @@ BASE_FEATURE(kFullscreenAfterUnlockAllowed,
// When enabled, there will be an alert bubble showing up when the device
// returns from low brightness (e.g., sleep, closed cover) without a lock screen
// and the active window is in fullscreen.
// TODO(https://crbug.com/1107185): Remove this after the feature is launched.
// TODO(crbug.com/40140761): Remove this after the feature is launched.
BASE_FEATURE(kFullscreenAlertBubble,
"EnableFullscreenBubble",
base::FEATURE_DISABLED_BY_DEFAULT);
@ -2266,8 +2266,8 @@ BASE_FEATURE(kPasswordlessGaiaForConsumers,
// Enables a notification warning users that their Thunderbolt device is not
// supported on their CrOS device.
// TODO(crbug/1254930): Revisit this flag when there is a way to query billboard
// devices correctly.
// TODO(crbug.com/40199811): Revisit this flag when there is a way to query
// billboard devices correctly.
BASE_FEATURE(kPcieBillboardNotification,
"PcieBillboardNotification",
base::FEATURE_DISABLED_BY_DEFAULT);

@ -473,7 +473,7 @@ const char kDisableRollbackOption[] = "disable-rollback-option";
// Disables client certificate authentication on the sign-in frame on the Chrome
// OS sign-in profile.
// TODO(https://crbug.com/844022): Remove this flag when reaching endpoints that
// TODO(crbug.com/41389560): Remove this flag when reaching endpoints that
// request client certs does not hang anymore when there is no system token yet.
const char kDisableSigninFrameClientCerts[] =
"disable-signin-frame-client-certs";
@ -1042,7 +1042,7 @@ const char kRmaNotAllowed[] = "rma-not-allowed";
const char kSafeMode[] = "safe-mode";
// Password change url for SAML users.
// TODO(941489): Remove when the bug is fixed.
// TODO(crbug.com/40618074): Remove when the bug is fixed.
const char kSamlPasswordChangeUrl[] = "saml-password-change-url";
// New modular design for the shelf with apps separated into a hotseat UI and

@ -55,7 +55,7 @@ SkBitmap GetColorAdjustedBitmap(const gfx::ImageSkiaRep& image_rep,
// cursor_color_. Do not recolor pure white or tinted portions of the image,
// this ensures we do not impact the colored portions of cursors or the
// transition between the colored portion and white outline.
// TODO(crbug.com/1085442): Programmatically find a way to recolor the white
// TODO(crbug.com/40693635): Programmatically find a way to recolor the white
// parts in order to draw a black outline, but without impacting cursors
// like noDrop which contained tinted portions. Or, add new assets with
// black and white inverted for easier re-coloring.

@ -1956,7 +1956,7 @@ TEST_F(DisplayManagerTest, TestNativeDisplaysChangedNoInternal) {
Shell::GetPrimaryRootWindow()->GetHost()->GetBoundsInPixels().size());
}
// TODO(crbug.com/1431416): Fix the test flakiness on MSan.
// TODO(crbug.com/40902297): Fix the test flakiness on MSan.
#if defined(MEMORY_SANITIZER)
#define MAYBE_NativeDisplaysChangedAfterPrimaryChange \
DISABLED_NativeDisplaysChangedAfterPrimaryChange

@ -1065,7 +1065,7 @@ AshWindowTreeHost* WindowTreeHostManager::AddWindowTreeHostForDisplay(
params_with_bounds.display_id = display.id();
params_with_bounds.device_scale_factor = display.device_scale_factor();
// TODO(crbug/1261776): Temporarily increase compositor memory limit for
// TODO(crbug.com/40799092): Temporarily increase compositor memory limit for
// 4K+ displays to avoid rendering corruption.
// Check both width and height in case of rotated display.
if (std::max(display.GetSizeInPixel().width(),

@ -106,7 +106,7 @@ using DragDropTest = AshInteractiveUITestBase;
// Test if the mouse gets moved properly to another display
// during drag & drop operation.
// TODO(https://crbug.com/1491759): Consistently failing on Chrome OS builds.
// TODO(crbug.com/40935905): Consistently failing on Chrome OS builds.
#if BUILDFLAG(IS_CHROMEOS)
#define MAYBE_DragDropAcrossMultiDisplay DISABLED_DragDropAcrossMultiDisplay
#else

@ -40,7 +40,7 @@ namespace ash {
namespace {
// The following distances are copied from tablet_mode_window_drag_delegate.cc.
// TODO(https://crbug.com/1069869): share these constants.
// TODO(crbug.com/40126106): share these constants.
// Items dragged to within |kDistanceFromEdgeDp| of the screen will get snapped
// even if they have not moved by |kMinimumDragToSnapDistanceDp|.

@ -161,7 +161,7 @@ std::unique_ptr<viz::CompositorFrame> CreateCompositorFrame(
host_window.GetHost()->GetRootTransform();
gfx::Size window_size_in_dip = host_window.GetBoundsInScreen().size();
// TODO(crbug.com/1131619): Should this be ceil? Why do we choose floor?
// TODO(crbug.com/40150283): Should this be ceil? Why do we choose floor?
const gfx::Size window_size_in_pixel = gfx::ToFlooredSize(
gfx::ConvertSizeToPixels(window_size_in_dip, device_scale_factor));

@ -177,7 +177,7 @@ ViewTreeHostRootViewFrameFactory::CreateCompositorFrame(
frame->metadata.begin_frame_ack.has_damage = true;
frame->metadata.device_scale_factor = device_scale_factor;
// TODO(crbug.com/1131623): Should this be ceil? Why do we choose floor?
// TODO(crbug.com/40150287): Should this be ceil? Why do we choose floor?
gfx::Size size_in_pixel = gfx::ToFlooredSize(
gfx::ConvertSizeToPixels(content_rect.size(), device_scale_factor));

@ -62,7 +62,7 @@ TEST_F(AshWindowTreeHostUnifiedTest, RotatedMouseMovement) {
// Verify the old config is removed when display is updated.
gfx::AcceleratedWidget old_widget1 = widget1;
// TODO(crbug.com/1297396): Just updating the display rotation doesn't update
// TODO(crbug.com/40215149): Just updating the display rotation doesn't update
// the cursor config, so need to remove and re-add the display for it to
// re-register a new cursor config. After the bug is fixed, change to just
// update to the new rotation directly. In that case, the widget id may stay

@ -242,7 +242,7 @@ void KeyboardControllerImpl::SetKeyboardLocked(bool locked) {
void KeyboardControllerImpl::SetOccludedBounds(
const std::vector<gfx::Rect>& bounds) {
// TODO(https://crbug.com/826617): Support occluded bounds with multiple
// TODO(crbug.com/41379402): Support occluded bounds with multiple
// rectangles.
keyboard_ui_controller_->SetOccludedBounds(bounds.empty() ? gfx::Rect()
: bounds[0]);

@ -18,7 +18,7 @@ ASH_EXPORT bool IsArrowKeyCode(const ui::KeyboardCode key_code);
// Closes the active (Chrome OS or Android VK). Returns false if no keyboard was
// active.
// TODO(crbug.com/1060272): Move this to KeyboardControllerImpl once that class
// TODO(crbug.com/40121961): Move this to KeyboardControllerImpl once that class
// handles both VKs.
bool CloseKeyboardIfActive();

@ -238,7 +238,7 @@ void KeyboardUIController::DisableKeyboard() {
if (model_.state() != KeyboardUIState::kInitial)
ChangeState(KeyboardUIState::kInitial);
// TODO(https://crbug.com/731537): Move KeyboardUIController members into a
// TODO(crbug.com/40524972): Move KeyboardUIController members into a
// subobject so we can just put this code into the subobject destructor.
queued_display_change_.reset();
queued_container_type_.reset();

@ -1099,9 +1099,9 @@ void LockContentsView::OnSystemInfoChanged(
LayoutTopHeader();
// TODO(crbug.com/1141348): Separate ADB sideloading from system info changed.
// Note that if ADB is enabled and the device is enrolled, only the ADB
// warning message will be displayed.
// TODO(crbug.com/40727114): Separate ADB sideloading from system info
// changed. Note that if ADB is enabled and the device is enrolled, only the
// ADB warning message will be displayed.
if (adb_sideloading_enabled) {
ShowAdbEnabled();
}

@ -892,7 +892,7 @@ void LoginAuthUserView::ApplyAnimationPostLayout(bool animate) {
auto transition = std::make_unique<PinKeyboardAnimation>(
current_state.has_pinpad /*grow*/, pin_view_->height(),
// TODO(https://crbug.com/955119): Implement proper animation.
// TODO(crbug.com/41454201): Implement proper animation.
base::Milliseconds(login::kChangeUserAnimationDurationMs / 2.0f),
gfx::Tween::FAST_OUT_SLOW_IN);
auto* sequence = new ui::LayerAnimationSequence(std::move(transition));

@ -270,8 +270,8 @@ class ASH_EXPORT LoginAuthUserView : public NonAccessibleView {
// Whether the authentication attempt should use the user's PIN.
bool ShouldAuthenticateWithPin() const;
// TODO(crbug/899812): remove this and pass a handler in via the Callbacks
// struct instead.
// TODO(crbug.com/41423180): remove this and pass a handler in via the
// Callbacks struct instead.
void AttemptAuthenticateWithExternalBinary();
// Called when the user triggered the challenge-response authentication. It

@ -157,7 +157,7 @@ PinRequestViewState PinRequestView::TestApi::state() const {
return view_->state_;
}
// TODO(crbug.com/1061008): Make dialog look good on small screens with high
// TODO(crbug.com/40679369): Make dialog look good on small screens with high
// zoom factor.
PinRequestView::PinRequestView(PinRequest request, Delegate* delegate)
: delegate_(delegate),

@ -28,7 +28,7 @@ class ASH_EXPORT MultiCaptureServiceClient
// Event to inform about a started multi capture. The `label` is a unique
// identifier that can be used to connect started / stopped events.
// The `origin` is the capturer's origin.
// TODO(crbug.com/1325750): Consider transferred tracks by either adding
// TODO(crbug.com/40225619): Consider transferred tracks by either adding
// a MultiCaptureTransferred event or by making sure the label remains
// constant throughout the lifetime of the capture.
virtual void MultiCaptureStarted(const std::string& label,

@ -112,7 +112,7 @@ class ASH_PUBLIC_EXPORT SharedAppListConfig {
const int default_grid_icon_dimension_ = 64;
// The badge icon dimension of a shortcut in apps grid view.
// TODO(crbug.com/1480423): Update the size after the effects visual done.
// TODO(crbug.com/40281395): Update the size after the effects visual done.
const int shortcut_badge_icon_dimension_ = 42;
// Maximum number of results to show in the launcher Search UI.

@ -516,7 +516,7 @@ ASH_PUBLIC_EXPORT std::string GetAppListControlCategoryName(
struct ASH_PUBLIC_EXPORT SearchResultIconInfo {
SearchResultIconInfo();
// TODO(crbug.com/1232897): Make the search backend explicitly set the shape
// TODO(crbug.com/40191300): Make the search backend explicitly set the shape
// for all icons by removing the two-argument version of the constructor.
SearchResultIconInfo(ui::ImageModel icon, int dimension);
SearchResultIconInfo(ui::ImageModel icon,
@ -861,7 +861,7 @@ struct ASH_PUBLIC_EXPORT SearchResultMetadata {
// The icon of this result in a smaller dimension to be rendered in suggestion
// chip view.
// TODO(crbug.com/1225161): Remove this and replace it with |icon| and an
// TODO(crbug.com/40188285): Remove this and replace it with |icon| and an
// appropriately set |icon_dimension|.
gfx::ImageSkia chip_icon;

@ -44,7 +44,7 @@ class ASH_EXPORT EventRewriterController {
virtual void SetArrowToTabRewritingEnabled(bool enabled) = 0;
// Continue dispatch of key events that were unhandled by ChromeVox.
// TODO(crbug.com/839541): ChromeVox should not repost unhandled events.
// TODO(crbug.com/41386990): ChromeVox should not repost unhandled events.
virtual void OnUnhandledSpokenFeedbackEvent(
std::unique_ptr<ui::Event> event) = 0;

@ -271,7 +271,7 @@ TEST_F(ArcNotificationViewTest, SlideOut) {
EXPECT_TRUE(IsPopupRemovedAfterIdle(notification_id));
}
// TODO(crbug.com/1410724): Flaky on MSAN bots.
// TODO(crbug.com/40889858): Flaky on MSAN bots.
#if defined(MEMORY_SANITIZER)
#define MAYBE_SlideOutNested DISABLED_SlideOutNested
#else

@ -18,7 +18,7 @@
namespace ash {
// TODO(crbug.com/1189945): Rename and move to more generic location.
// TODO(crbug.com/40173943): Rename and move to more generic location.
// A wrapper around a `gfx::ImageSkia` that supports dynamic updates.
class ASH_PUBLIC_EXPORT HoldingSpaceImage {
public:

@ -40,8 +40,8 @@ class ASH_PUBLIC_EXPORT ImeControllerClient {
// accelerator (e.g. pressing Alt + Search), or from the debug UI (i.e.
// toggling the caps lock button), propagate the change to the client without
// sending a change notification back.
// TODO(crbug/759435): Ideally this interaction should only be to disable the
// caps lock.
// TODO(crbug.com/40537240): Ideally this interaction should only be to
// disable the caps lock.
virtual void SetCapsLockEnabled(bool enabled) = 0;
// Overrides the keyboard keyset (emoji, handwriting or voice). If keyset is

@ -13,7 +13,7 @@ class Transform;
namespace ash {
// TODO(crbug.com/756161): This method will need to be moved to
// TODO(crbug.com/40535513): This method will need to be moved to
// gfx/geometry/dip_utils.h for M62 and later. This method computes the scale
// required to convert DIP coordinates to the coordinate space of the
// |transform|. It deduces the scale from the transform by applying it to a pair

@ -35,7 +35,7 @@ class ASH_PUBLIC_EXPORT WallpaperControllerObserver {
virtual void OnWallpaperColorsChanged() {}
// Invoked when the blur state of the wallpaper changes.
// TODO(crbug.com/875128): Remove this after web-ui login code is completely
// TODO(crbug.com/41408561): Remove this after web-ui login code is completely
// removed.
virtual void OnWallpaperBlurChanged() {}

@ -357,7 +357,7 @@ std::unique_ptr<ui::LayerTreeOwner> ScreenRotationAnimator::CopyLayerTree(
DCHECK_EQ(copy_layer->size(),
GetScreenRotationContainer(root_window_)->layer()->size());
// TODO(crbug.com/1040279): This is a workaround and should be removed once
// TODO(crbug.com/40113966): This is a workaround and should be removed once
// the issue is fixed.
copy_layer->SetFillsBoundsOpaquely(false);
return std::make_unique<ui::LayerTreeOwner>(std::move(copy_layer));

@ -2843,7 +2843,7 @@ INSTANTIATE_TEST_SUITE_P(RTL, HotseatWidgetRTLTest, testing::Bool());
// The test to verify the hotseat transition animation from the extended state
// to the home launcher state.
// TODO(https://crbug.com/1210530): Disable this test due to flakiness.
// TODO(crbug.com/40182469): Disable this test due to flakiness.
TEST_P(HotseatWidgetRTLTest,
DISABLED_VerifyTransitionFromExtendedModeToHomeLauncher) {
TabletModeControllerTestApi().EnterTabletMode();
@ -2860,7 +2860,7 @@ TEST_P(HotseatWidgetRTLTest,
EXPECT_EQ(HotseatState::kExtended, GetShelfLayoutManager()->hotseat_state());
// Animation should be long enough in order to collect sufficient data.
// TODO(https://crbug.com/1208651): remove this line when we solve that issue.
// TODO(crbug.com/40181827): remove this line when we solve that issue.
ui::ScopedAnimationDurationScaleMode animation_duration(
ui::ScopedAnimationDurationScaleMode::NORMAL_DURATION);

@ -447,7 +447,7 @@ gfx::Rect ScrollableShelfView::GetTargetScreenBoundsOfItemIcon(
// Return a dummy value if the item specified by `id` does not exist in the
// shelf model.
// TODO(https://crbug.com/1270498): it is a quick fixing. We should
// TODO(crbug.com/40057927): it is a quick fixing. We should
// investigate the root cause.
if (item_index_in_model < 0)
return gfx::Rect();

@ -308,7 +308,7 @@ TEST_F(ScrollableShelfViewTest, CorrectUIAfterDisplayRotationShortToLong) {
EXPECT_FALSE(scrollable_shelf_view_->ShouldAdjustForTest());
}
// TODO(crbug.com/1366645): Enable when the bug is fixed.
// TODO(crbug.com/40867071): Enable when the bug is fixed.
// Verifies that the display rotation from the long side to the short side
// should not break the scrollable shelf's UI behavior
// (https://crbug.com/1000764).

@ -31,7 +31,7 @@ class ASH_EXPORT ShelfContainerView : public views::View {
gfx::Size CalculateIdealSize(int button_size) const;
// Translate |shelf_view_| by |offset|.
// TODO(https://crbug.com/973481): now we implement ShelfView scrolling
// TODO(crbug.com/40631809): now we implement ShelfView scrolling
// through view translation, which is not as efficient as ScrollView. Redesign
// this class with ScrollView.
virtual void TranslateShelfView(const gfx::Vector2dF& offset);

@ -2025,7 +2025,7 @@ void ShelfLayoutManager::UpdateTargetBoundsForGesture(
if (hotseat_target_state == HotseatState::kShownHomeLauncher)
return;
// TODO(https://crbug.com/1002132): Add tests for the hotseat bounds logic.
// TODO(crbug.com/40646496): Add tests for the hotseat bounds logic.
CHECK_EQ(kDragInProgress, drag_status_);
bool shelf_hidden_at_start = false;
@ -2205,7 +2205,7 @@ ShelfAutoHideState ShelfLayoutManager::CalculateAutoHideState(
return state_.auto_hide_state;
// Shelf is not available before login.
// TODO(crbug.com/701157): Remove this when the login webui fake-shelf is
// TODO(crbug.com/40510582): Remove this when the login webui fake-shelf is
// replaced with views.
if (!Shell::Get()->session_controller()->IsActiveUserSessionStarted())
return SHELF_AUTO_HIDE_HIDDEN;

@ -3073,7 +3073,7 @@ TEST_F(ShelfLayoutManagerTest, NoBackgroundChange) {
// Tests that tapping the home button is successful on the autohidden shelf.
//
// TODO(crbug.com/1418325): Test is flaky.
// TODO(crbug.com/40894666): Test is flaky.
TEST_F(ShelfLayoutManagerTest,
DISABLED_NoTemporaryAutoHideStateWhileOpeningLauncher) {
// Enable animations and simulate the zero state search called when showing
@ -3728,7 +3728,7 @@ TEST_F(ShelfLayoutManagerWindowDraggingTest,
// Test that if shelf if hidden or auto-hide hidden, drag window from shelf is a
// no-op.
// TODO(1024163): This test consistently crashes.
// TODO(crbug.com/40107332): This test consistently crashes.
TEST_F(ShelfLayoutManagerWindowDraggingTest, DISABLED_NoOpForHiddenShelf) {
std::unique_ptr<aura::Window> window =
AshTestBase::CreateTestWindow(gfx::Rect(0, 0, 400, 400));

@ -146,7 +146,7 @@ ShelfShutdownConfirmationBubble::ShelfShutdownConfirmationBubble(
GetBubbleFrameView()->SetBackgroundColor(GetBackgroundColor());
// The bubble content size changes after border setting, therefore resize
// the widget to its content.
// TODO(crbug.com/1520953): widget should autoresize to its content.
// TODO(crbug.com/41493925): widget should autoresize to its content.
SizeToContents();
GetWidget()->Show();

@ -996,7 +996,7 @@ void ShelfWidget::OnSessionStateChanged(session_manager::SessionState state) {
// be painted over the hotseat/navigation buttons/status area). Make sure
// the shelf widget is restacked at the bottom of the shelf container when
// the session state changes.
// TODO(https://crbug.com/1057207): Ideally, the shelf widget position at
// TODO(crbug.com/40120650): Ideally, the shelf widget position at
// the bottom of window stack would be maintained using a "stacked at
// bottom" window property - switch to that approach once it's ready for
// usage.

@ -329,7 +329,7 @@ TEST_F(KeyboardShortcutViewTest, FrameAndBackgroundColorUpdates) {
EXPECT_EQ(kTitleAndFrameColorDark, GetView()->GetBackground()->get_color());
}
// TODO(https://crbug.com/1439747): Flaky on ASAN and chromeos, probably due to
// TODO(crbug.com/40909012): Flaky on ASAN and chromeos, probably due to
// hard-coded timeout.
#if (BUILDFLAG(IS_LINUX) && defined(ADDRESS_SANITIZER)) || \
BUILDFLAG(IS_CHROMEOS)

@ -120,7 +120,7 @@ TEST_F(SystemComponentsTest, PillButtonTooltip) {
EXPECT_EQ(pill_button->GetTooltipText(gfx::Point()), u"Tooltip");
}
// TODO(crbug/1384370): Disable for constant failure.
// TODO(crbug.com/40878458): Disable for constant failure.
TEST_F(SystemComponentsTest,
DISABLED_IconButtonWithBackgroundColorIdDoesNotCrash) {
// Create an IconButton with an explicit background color ID.

@ -109,7 +109,7 @@ TEST_F(AsyncLogTest, WriteMultipleLines) {
EXPECT_EQ(lines, GetLogLines(log.GetContents()));
}
// TODO(crbug.com/1457442): reenable this.
// TODO(crbug.com/40918364): reenable this.
TEST_F(AsyncLogTest, DISABLED_NoUseAfterFreeCrash) {
const std::string new_line = "Line\n";

@ -74,7 +74,7 @@ SnoopingProtectionController::SnoopingProtectionController()
SnoopingProtectionController::~SnoopingProtectionController() {
// This is a no-op if the service isn't available or isn't enabled.
// TODO(crbug.com/1241704): only disable if the service is enabled.
// TODO(crbug.com/40194784): only disable if the service is enabled.
//
// Might not exist in unit tests.
if (HumanPresenceDBusClient::Get())

@ -164,7 +164,7 @@ TEST_F(IMEFeaturePodControllerTest, ButtonVisibilityPolicy) {
EXPECT_TRUE(IsButtonVisible());
}
// TODO(crbug.com/1416179): Test is failing on "Linux ChromiumOS MSan Tests".
// TODO(crbug.com/40893381): Test is failing on "Linux ChromiumOS MSan Tests".
#if defined(MEMORY_SANITIZER)
#define MAYBE_IconUMATracking DISABLED_IconUMATracking
#else

@ -53,7 +53,7 @@ void UpdateModel::SetShowExtendedUpdatesNotice(bool show) {
}
UpdateSeverity UpdateModel::GetSeverity() const {
// TODO(https://crbug.com/927010): adjust severity according the amount of
// TODO(crbug.com/41438408): adjust severity according the amount of
// time passing after update is available over cellular connection. Use low
// severity for update available over cellular connection.
return update_over_cellular_available_ ? UpdateSeverity::kLow : severity_;

@ -135,7 +135,7 @@ bool AshNotificationDragController::CanStartDragForView(
drag_area && drag_area->Contains(press_pt));
// Assume that the drag on `sender` will start when `can_start_drag` is true.
// TODO(https://crbug.com/1410276): in some edge cases, the view drag does not
// TODO(crbug.com/40254274): in some edge cases, the view drag does not
// start when `CanStartDragForView()` returns true. We should come up with a
// general solution to observe drag start.
if (can_start_drag) {

@ -152,8 +152,8 @@ void NotificationGroupingController::PopulateGroupParent(
->GetMessageViewForNotificationId(notification_id)
: nullptr;
// TODO(crbug/1277765) Need this check to fix crbug/1275765. However, this
// should not be necessary if the message center bubble is initialized
// TODO(crbug.com/40809802) Need this check to fix crbug/1275765. However,
// this should not be necessary if the message center bubble is initialized
// properly. Need to monitor for empty group notifications if this check is
// hit and fix the root cause.
if (!parent_view) {

@ -40,7 +40,7 @@ gfx::ImageSkia CreateNotificationAppIcon(
cros_tokens::kCrosSysOnPrimary);
SkColor icon_background_color = CalculateIconBackgroundColor(notification);
// TODO(crbug.com/768748): figure out if this has a performance impact and
// TODO(crbug.com/40541732): figure out if this has a performance impact and
// cache images if so.
gfx::Image masked_small_icon = notification->GenerateMaskedSmallIcon(
kNotificationAppIconImageSize, icon_color, icon_background_color,

@ -454,7 +454,7 @@ AshNotificationView::AshNotificationView(
}
message_center_observer_.Observe(message_center::MessageCenter::Get());
// TODO(crbug/1232197): fix views and layout to match spec.
// TODO(crbug.com/40780100): fix views and layout to match spec.
// Instantiate view instances and define layout and view hierarchy.
SetLayoutManager(std::make_unique<views::BoxLayout>(
views::BoxLayout::Orientation::kVertical,

@ -883,7 +883,7 @@ TEST_F(AshNotificationViewTest, ExpandCollapseAnimationsRecordSmoothness) {
"Ash.NotificationView.ActionsRow.FadeIn.AnimationSmoothness");
}
// TODO(crbug.com/1522231): Re-enable this test
// TODO(crbug.com/41495194): Re-enable this test
TEST_F(AshNotificationViewTest, ImageExpandCollapseAnimationsRecordSmoothness) {
// Enable animations.
ui::ScopedAnimationDurationScaleMode duration(

@ -106,8 +106,8 @@ void OverviewButtonTray::OnGestureEvent(ui::GestureEvent* event) {
// TODO(crbug/1374368): React to long press via `OnButtonPressed()` once this
// is enabled.
if (event->type() == ui::ET_GESTURE_LONG_PRESS) {
// TODO(crbug.com/970013): Properly implement the multi-display behavior (in
// tablet position with an external pointing device).
// TODO(crbug.com/40630467): Properly implement the multi-display behavior
// (in tablet position with an external pointing device).
SplitViewController::Get(Shell::GetPrimaryRootWindow())
->OnOverviewButtonTrayLongPressed(event->location());
}

@ -44,7 +44,7 @@ class ASH_EXPORT OverviewButtonTray : public TrayBackgroundView,
// Second taps within this time will be counted as double taps. Use this
// instead of ui::Event's click_count and tap_count as those have a minimum
// time bewtween events before the second tap counts as a double tap.
// TODO(crbug.com/817883): We should the gesture detector double tap time or
// TODO(crbug.com/40565331): We should the gesture detector double tap time or
// overview enter animation time, once ux decides which one to match (both are
// 300ms currently).
static constexpr base::TimeDelta kDoubleTapThresholdMs =

@ -1180,7 +1180,7 @@ class PowerButtonControllerWithPositionTest
PowerButtonPosition power_button_position_;
};
// TODO(crbug.com/1010194).
// TODO(crbug.com/40101364).
TEST_P(PowerButtonControllerWithPositionTest,
DISABLED_MenuNextToPowerButtonInTabletMode) {
std::string display =

@ -713,7 +713,7 @@ TEST_F(LockOnSuspendUsageTest, LockOnSuspendUsage) {
1)));
}
// TODO(crbug.com/1425006): Test is failing on "Linux ChromiumOS MSan Tests".
// TODO(crbug.com/40898491): Test is failing on "Linux ChromiumOS MSan Tests".
#if defined(MEMORY_SANITIZER)
#define MAYBE_No_ShouldLockScreenAutomatically \
DISABLED_No_ShouldLockScreenAutomatically

@ -754,7 +754,7 @@ TEST_F(ScheduledFeatureTest, ExplicitUserTogglesWhileScheduleIsActive) {
// Tests that changing the custom start and end times, in such a way that
// shouldn't change the current status, only updates the timer but doesn't
// change the status.
// TODO(crbug.com/1410064): Fix test failure and re-enable on ChromeOS.
// TODO(crbug.com/40889492): Fix test failure and re-enable on ChromeOS.
#if BUILDFLAG(IS_CHROMEOS)
#define MAYBE_ChangingStartTimesThatDontChangeTheStatus \
DISABLED_ChangingStartTimesThatDontChangeTheStatus

@ -142,7 +142,7 @@ TEST_P(StatusAreaParameterizedPixelTest, DateTrayTest) {
date_tray));
}
// TODO(https://crbug.com/1487311): Disaled due to flakiness.
// TODO(crbug.com/40934062): Disaled due to flakiness.
TEST_P(StatusAreaParameterizedPixelTest,
DISABLED_NotificationTrayCounterWithSingleCount) {
GetPrimaryShelf()->SetAlignment(GetShelfAlignment());
@ -173,7 +173,7 @@ INSTANTIATE_TEST_SUITE_P(All,
StatusAreaParamerterizedAlignmentPixelTest,
testing::ValuesIn(kShelfAlignments));
// TODO(https://crbug.com/1487336): Disabled due to excessive flakiness.
// TODO(crbug.com/40934073): Disabled due to excessive flakiness.
TEST_P(StatusAreaParamerterizedAlignmentPixelTest, DISABLED_OverflowTray) {
UpdateDisplay("500x600");
GetPrimaryShelf()->SetAlignment(GetShelfAlignment());

@ -456,7 +456,7 @@ CalendarMonthView::CalendarMonthView(
const bool should_fetch_calendar_data =
calendar_utils::ShouldFetchCalendarData();
// TODO(https://crbug.com/1236276): Extract the following 3 parts (while
// TODO(crbug.com/40192677): Extract the following 3 parts (while
// loops) into a method.
int column = 0;
int safe_index = 0;

@ -22,7 +22,7 @@ class SystemNudge;
// and out after a short period of time. While nudge behavior is covered by this
// abstract class, Subclasses must implement CreateSystemNudge() in order to
// create a custom label and icon for their nudge's UI.
// TODO(crbug.com/1232525): Duration and positioning should be configurable.
// TODO(crbug.com/40780307): Duration and positioning should be configurable.
class ASH_EXPORT SystemNudgeController
: public SystemNudgePauseManagerImpl::Observer {
public:

@ -319,7 +319,7 @@ TrayBubbleView::TrayBubbleView(const InitParams& init_params)
: gfx::Insets());
if (init_params.translucent) {
// TODO(crbug/1313073): In the dark light mode feature, remove layer
// TODO(crbug.com/40832096): In the dark light mode feature, remove layer
// creation in children views of this view to improve performance.
SetPaintToLayer(ui::LAYER_TEXTURED);
layer()->SetFillsBoundsOpaquely(false);

@ -22,7 +22,7 @@ namespace ash {
class FeaturePodControllerBase;
// TODO(crbug/1276545): Remove FeaturePodIconButton after the migration.
// TODO(crbug.com/40808951): Remove FeaturePodIconButton after the migration.
// A toggle button with an icon used by feature pods and in other places.
class ASH_EXPORT FeaturePodIconButton : public IconButton {
METADATA_HEADER(FeaturePodIconButton, IconButton)

@ -77,7 +77,7 @@ TEST_F(UnifiedSliderViewPixelTest, DefaultSlider) {
/*revision_number=*/0, widget_.get()));
}
// TODO(crbug.com/1486954): Flaky.
// TODO(crbug.com/40283113): Flaky.
TEST_F(UnifiedSliderViewPixelTest, DISABLED_DefaultSliderMuted) {
// Creates a `UnifiedVolumeView` that's on the main page. This slider is in
// `QuickSettingsSlider::Style::kDefault` style.

@ -12,7 +12,7 @@ namespace ash {
// A significant number of ash_unittests are overriding the feature list after
// the GPU thread is started so allowlist the whole test binary.
// TODO(crbug.com/1241161): Fix racy tests and remove this.
// TODO(crbug.com/40785850): Fix racy tests and remove this.
class AshScopedAllowRacyFeatureListOverrides {
private:
viz::TestGpuServiceHolder::ScopedAllowRacyFeatureListOverrides

@ -23,7 +23,7 @@ namespace ash {
// The helper class to verify a layer animation on the following things:
// (1) The observed view should not go back and forth during the animation.
// (2) TODO(https://crbug.com/1209000): The animation should progress to the end
// (2) TODO(crbug.com/40181947): The animation should progress to the end
// rather than get interrupted.
// (3) TODO(https://crbug.com/1209001): The observed view should move smoothly
// during the animation. In other words, the view should not move in a janky

@ -26,7 +26,7 @@ bool RoundedWindowTargeter::EventLocationInsideBounds(
gfx::Point point = ConvertEventLocationToWindowCoordinates(target, event);
// Assumes a rectangle with height and width one is a point. This may match
// 1px off at the bottom-right corner.
// TODO(crbug/1220713): Expose SkRRect::ContainsPoint() instead.
// TODO(crbug.com/40773093): Expose SkRRect::ContainsPoint() instead.
gfx::RectF rectf_point(point.x(), point.y(), 1, 1);
return rrectf_.Contains(rectf_point);
}

@ -2298,7 +2298,7 @@ TEST_P(WallpaperControllerTest, LoadsSeaPenWallpaperWithInvalidUserFilePath) {
/*max_deviation=*/1));
}
// TODO(https://crbug.com/1511896): Flaky on linux-chromeos-rel.
// TODO(crbug.com/41484478): Flaky on linux-chromeos-rel.
TEST_P(WallpaperControllerTest, DISABLED_SetSeaPenWallpaperFromFile) {
SimulateUserLogin(kAccountId1);
TestWallpaperControllerObserver observer(controller_);

@ -298,8 +298,8 @@ export class CrInputElement extends PolymerElement {
/**
* Focuses the input element.
* TODO(crbug.com/882612): Replace this with focus() after resolving the text
* selection issue described in onFocus_().
* TODO(crbug.com/40593040): Replace this with focus() after resolving the
* text selection issue described in onFocus_().
* @return Whether the <input> element was focused.
*/
focusInput(): boolean {

@ -42,7 +42,7 @@
/* Disable browser touch actions so that dragging via touch works
correctly. */
/* TODO(crbug/1068914): For reasons I don't understand we need to set
/* TODO(crbug.com/40125694): For reasons I don't understand we need to set
touch-action: none on the container for sliders inside dialogs and on
the host for sliders not in dialogs. If we don't, then you can't drag
the slider via touch (mouse works fine).*/
@ -149,7 +149,7 @@
font-size: 12px;
line-height: 1.5em;
opacity: 0;
/* TODO(crbug.com/980856): Remove workaround after rendering bug is
/* TODO(crbug.com/40634687): Remove workaround after rendering bug is
* fixed. */
outline: 1px transparent solid;
padding: 0 .67em;

@ -52,7 +52,7 @@
@media (forced-colors: active) {
:host {
/* TODO(crbug.com/1176612): cr-toggle heavily relies on
/* TODO(crbug.com/40168415): cr-toggle heavily relies on
background-color to convey various states (on/off,
enabled/disabled). Until proper specs for HCM exist, turn off
forced-colors automatic adjustments so that the cr-toggle is at

@ -108,7 +108,7 @@ export const CrScrollableBehavior = {
ironList.notifyResize();
}
// TODO(crbug.com/1121679): Add UI Test for this behavior.
// TODO(crbug.com/40146300): Add UI Test for this behavior.
if (scrollHeight <= 1 &&
window.getComputedStyle(node.parentNode).display !== 'none') {
checkAgain.push({

@ -292,6 +292,6 @@
</div>
</div>
<!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out
<!-- TODO(crbug.com/40464949): Use i18n instead of string literals. Figure out
what i18n to use for keypad, ie, does 1 ABC make
sense in every scenario? -->

@ -33,7 +33,7 @@ const char kEcheAppToastId[] = "eche_app_toast_id";
const char kEcheAppNetworkSettingNotifierId[] =
"eche_app_notification_ids.network_settings";
// TODO(crbug.com/1241352): This should probably have a ?p=<FEATURE_NAME> at
// TODO(crbug.com/40785967): This should probably have a ?p=<FEATURE_NAME> at
// some point.
const char kEcheAppLearnMoreUrl[] = "https://support.google.com/chromebook";

@ -176,7 +176,7 @@ content::WebUIDataSource* CreateAndAddMediaAppUntrustedDataSource(
// so allow resources in the guest to be loaded cross-origin.
source->OverrideCrossOriginResourcePolicy("cross-origin");
// TODO(crbug.com/1098685): Trusted Type remaining WebUI.
// TODO(crbug.com/40137141): Trusted Type remaining WebUI.
source->DisableTrustedTypesCSP();
return source;
}

@ -92,8 +92,8 @@ function reportCrashError(...errors: any[]) {
columnNumber: errorObject?.columnNumber || 0,
};
// TODO(crbug/996088): Add useful callback when the error is reported, handle
// if it crashes while reporting an error.
// TODO(crbug.com/40641337): Add useful callback when the error is reported,
// handle if it crashes while reporting an error.
chrome.crashReportPrivate.reportError(params, () => {});
}

@ -121,7 +121,7 @@ let appTitle: string|undefined;
/**
* The current sort order.
* TODO(crbug/414789): Match the file manager order when launched that way.
* TODO(crbug.com/40384768): Match the file manager order when launched that way.
* Note currently this is reassigned in tests.
*/
// eslint-disable-next-line prefer-const

@ -57,7 +57,7 @@ GUEST_TEST('GuestLoadsLoadTimeData', () => {
// Test can load files with CSP restrictions. We expect `error` to be called
// as these tests are loading resources that don't exist. Note: we can't violate
// CSP in tests or Js Errors will cause test failures.
// TODO(crbug/1148090): PDF loading tests should also appear here, they are
// TODO(crbug.com/40156902): PDF loading tests should also appear here, they are
// currently in media_app_integration_browsertest.cc due to 'wasm-eval' JS
// errors.
GUEST_TEST('GuestCanLoadWithCspRestrictions', async () => {

@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# TODO(https://crbug.com/1271537): add assert(is_chromeos_ash) when fixed.
# TODO(crbug.com/40805620): add assert(is_chromeos_ash) when fixed.
assert(is_chromeos, "Projector App is Chrome OS only")
source_set("cpp") {

@ -245,7 +245,7 @@ enum Setting {
kSpellCheckOnOff = 1207,
// Note: Value 1208 was for deprecated kShowPredictiveWriting.
// Do not reuse.
// TODO(crbug/1058552): Add [Deprecated] attribute once implemented.
// TODO(crbug.com/40121199): Add [Deprecated] attribute once implemented.
kShowPKAutoCorrection = 1209,
kShowVKAutoCorrection = 1210,
kShowDiacritic = 1211,

@ -432,7 +432,7 @@ int RootWindowDeskSwitchAnimator::GetIndexOfMostVisibleDeskScreenshot() const {
}
}
// TODO(crbug.com/1134390): Convert back to DCHECK when the issue is fixed.
// TODO(crbug.com/40151430): Convert back to DCHECK when the issue is fixed.
CHECK_GE(index, 0);
CHECK_LT(index, static_cast<int>(DesksController::Get()->desks().size()));
return index;

@ -128,7 +128,7 @@ void DragWindowResizer::EndDragImpl() {
// Adjust the size and position so that it doesn't exceed the size of work
// area.
display::Display dst_display;
// TODO(crbug.com/1131071): It's possible that |dst_display_id| returned from
// TODO(crbug.com/40721205): It's possible that |dst_display_id| returned from
// CursorManager::GetDisplay().id() is an invalid display id thus
// |dst_display| may be invalid as well. This may cause crash later. To avoid
// crash, we early return here. However, |dst_display_id| should never be

@ -87,8 +87,8 @@ std::unique_ptr<views::Widget> CreateWidget() {
kShellWindowId_OverlayContainer);
widget->Init(std::move(params));
// TODO(crbug.com/1009005): Get the bounds of the display that should show the
// nudge, which may based on the conditions to show the nudge.
// TODO(crbug.com/40100889): Get the bounds of the display that should show
// the nudge, which may based on the conditions to show the nudge.
const gfx::Rect display_bounds =
display::Screen::GetScreen()->GetPrimaryDisplay().bounds();
gfx::Rect widget_bounds;

@ -39,7 +39,7 @@ using WindowList = MruWindowTracker::WindowList;
// A class that observes a window that should not be destroyed inside a certain
// scope. This class is added to investigate crbug.com/937381 to see if it's
// possible that a window is destroyed while building up the mru window list.
// TODO(crbug.com/937381): Remove this class once we figure out the reason.
// TODO(crbug.com/41444457): Remove this class once we figure out the reason.
class ScopedWindowClosingObserver : public aura::WindowObserver {
public:
explicit ScopedWindowClosingObserver(aura::Window* window) : window_(window) {

@ -117,7 +117,7 @@ OverviewController::OverviewController()
: occlusion_pause_duration_for_start_(kOcclusionPauseDurationForStart),
occlusion_pause_duration_for_end_(kOcclusionPauseDurationForEnd),
delayed_animation_task_delay_(kTransition),
// TODO(crbug.com/1278648): Lacros windows now have a snapshot, but their
// TODO(crbug.com/40208263): Lacros windows now have a snapshot, but their
// behavior may be a bit worse than ash windows. Keep this snapshot code
// until we confirm it is fine to show lacros snapshotted windows all the
// time.

@ -2303,7 +2303,7 @@ void OverviewGrid::RefreshGridBounds(bool animate) {
}
void OverviewGrid::UpdateSaveDeskButtons() {
// TODO(crbug.com/1275282): The button should be updated whenever the
// TODO(crbug.com/40207000): The button should be updated whenever the
// overview grid changes, i.e. switches between active desks and/or the
// saved desk grid. This will be needed when we make it so that switching
// desks keeps us in overview mode.

@ -1393,7 +1393,7 @@ void OverviewSession::OnKeyEvent(ui::KeyEvent* event) {
// mode, when we snap an overview window to one side of the screen and then
// open the app list to select an app to snap to the other side), in this case
// we let the app list to handle the key event.
// TODO(crbug.com/952315): Explore better ways to handle this splitview +
// TODO(crbug.com/40622922): Explore better ways to handle this splitview +
// overview + applist case.
if (!display::Screen::GetScreen()->InTabletMode() &&
Shell::Get()->app_list_controller()->IsVisible()) {

@ -1058,7 +1058,7 @@ TEST_P(OverviewSessionTest, DISABLED_TabletModeHistograms) {
// Tests that entering overview when a fullscreen window is active in maximized
// mode correctly applies the transformations to the window and correctly
// updates the window bounds on exiting overview mode: http://crbug.com/401664.
// TODO(crbug.com/1523918): Fix flaky test.
// TODO(crbug.com/41496866): Fix flaky test.
TEST_P(OverviewSessionTest, DISABLED_FullscreenWindowTabletMode) {
ui::ScopedAnimationDurationScaleMode animation_scale(
ui::ScopedAnimationDurationScaleMode::FAST_DURATION);
@ -5143,7 +5143,7 @@ TEST_P(OverviewRasterScaleTest,
}
// Tests raster scale changes work in tablet mode.
// TODO(crbug.com/1508655): Fix flaky test.
// TODO(crbug.com/40949385): Fix flaky test.
TEST_P(OverviewRasterScaleTest, DISABLED_RasterScaleTabletMode) {
EnterTabletMode();

@ -646,7 +646,7 @@ bool IsLayoutHorizontal(const display::Display& display) {
return IsCurrentScreenOrientationLandscape();
}
// TODO(crbug.com/1233192): add DCHECK to avoid square size display.
// TODO(crbug.com/40191408): add DCHECK to avoid square size display.
DCHECK(display.is_valid());
return chromeos::IsLandscapeOrientation(GetSnapDisplayOrientation(display));
}

@ -1634,7 +1634,7 @@ TEST_F(TabletModeControllerTest, TabletModeTransitionHistogramsNotLogged) {
histogram_tester.ExpectTotalCount(kExitHistogram, 0);
}
// TODO(crbug.com/1382272): Flaky on Linux Chromium OS ASan LSan Tests.
// TODO(crbug.com/40877227): Flaky on Linux Chromium OS ASan LSan Tests.
TEST_F(TabletModeControllerTest,
DISABLED_TabletModeTransitionHistogramsLogged) {
ui::ScopedAnimationDurationScaleMode test_duration_mode(

Some files were not shown because too many files have changed in this diff Show More