chromium/src
0
Fork 0
Code Activity

Remove stale feature SharedZstd

Browse Source 
Fixed: 362247901
Change-Id: I3a6868f39d8084ca4b6590882457243b1abf7e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532442
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1460132}
This commit is contained in:
Nan Lin
2025-05-14 08:42:15 -07:00
committed by Chromium LUCI CQ
parent a28e4b3d79
commit 8b5d4ce8e0
9 changed files with 3 additions and 41 deletions

4
chrome/browser/about_flags.cc

@ -10097,10 +10097,6 @@ const FeatureEntry kFeatureEntries[] = {
kOsAll,
FEATURE_VALUE_TYPE(features::kComputePressureBreakCalibrationMitigation)},
{"enable-shared-zstd", flag_descriptions::kSharedZstdName,
flag_descriptions::kSharedZstdDescription, kOsAll,
FEATURE_VALUE_TYPE(network::features::kSharedZstd)},
#if BUILDFLAG(IS_ANDROID)
{"android-extended-keyboard-shortcuts",
flag_descriptions::kAndroidExtendedKeyboardShortcutsName,

5
chrome/browser/flag-metadata.json

@ -4131,11 +4131,6 @@
"owners": [ "haileywang@google.com", "wychen@chromium.org" ],
"expiry_milestone": 135
},
{
"name": "enable-shared-zstd",
"owners": [ "nidhijaju@chromium.org", "net-dev@chromium.org" ],
"expiry_milestone": 130
},
{
"name": "enable-shortcut-customization",
"owners": [

5
chrome/browser/flag_descriptions.cc

@ -3737,11 +3737,6 @@ const char kServiceWorkerAutoPreloadDescription[] =
"worker. See "
"https://github.com/explainers-by-googlers/service-worker-auto-preload";
const char kSharedZstdName[] = "Shared Zstd";
const char kSharedZstdDescription[] =
"Enables compression dictionary transport with Zstandard (aka Shared "
"Zstd).";
const char kSharingDesktopScreenshotsName[] = "Desktop Screenshots";
const char kSharingDesktopScreenshotsDescription[] =
"Enables taking"

3
chrome/browser/flag_descriptions.h

@ -2139,9 +2139,6 @@ extern const char kSegmentationSurveyPageDescription[];
extern const char kServiceWorkerAutoPreloadName[];
extern const char kServiceWorkerAutoPreloadDescription[];
extern const char kSharedZstdName[];
extern const char kSharedZstdDescription[];
extern const char kSharingDesktopScreenshotsName[];
extern const char kSharingDesktopScreenshotsDescription[];

3
chrome/browser/net/chrome_shared_dictionary_browsertest.cc

@ -206,8 +206,7 @@ class ChromeSharedDictionaryBrowserTest : public InProcessBrowserTest {
scoped_feature_list_.InitWithFeatures(
/*enabled_features=*/
{network::features::kCompressionDictionaryTransportBackend,
network::features::kCompressionDictionaryTransport,
network::features::kSharedZstd},
network::features::kCompressionDictionaryTransport},
/*disabled_features=*/{});
embedded_test_server()->RegisterRequestHandler(

14
content/browser/network/shared_dictionary_browsertest.cc

@ -365,11 +365,7 @@ bool HasSharedDictionaryAcceptEncoding(
if (it == headers.end()) {
return false;
}
if (base::FeatureList::IsEnabled(network::features::kSharedZstd)) {
return it->second == "dcb, dcz" || base::EndsWith(it->second, ", dcb, dcz");
} else {
return it->second == "dcb" || base::EndsWith(it->second, ", dcb");
}
}
// A dummy ContentBrowserClient for testing HTTP Auth.
@ -711,17 +707,10 @@ class SharedDictionaryBrowserTestBase : public ContentBrowserTest {
if (dict_hash) {
if (*dict_hash == kExpectedDictionaryHashBase64) {
if (HasSharedDictionaryAcceptEncoding(request.headers)) {
if (base::FeatureList::IsEnabled(network::features::kSharedZstd)) {
response->AddCustomHeader(
"content-encoding",
net::shared_dictionary::kSharedZstdContentEncodingName);
response->set_content(kZstdCompressedDataString);
} else {
response->AddCustomHeader(
"content-encoding",
net::shared_dictionary::kSharedBrotliContentEncodingName);
response->set_content(kBrotliCompressedDataString);
}
} else {
response->set_content(kErrorNoSharedDictionaryAcceptEncodingString);
}
@ -746,8 +735,7 @@ class SharedDictionaryBrowserTest
scoped_feature_list_.InitWithFeatures(
/*enabled_features=*/
{network::features::kCompressionDictionaryTransportBackend,
network::features::kCompressionDictionaryTransport,
network::features::kSharedZstd},
network::features::kCompressionDictionaryTransport},
/*disabled_features=*/{});
}
SharedDictionaryBrowserTest(const SharedDictionaryBrowserTest&) = delete;

4
services/network/network_context.cc

@ -127,7 +127,6 @@
#include "services/network/proxy_resolving_socket_factory_mojo.h"
#include "services/network/public/cpp/cert_verifier/mojo_cert_verifier.h"
#include "services/network/public/cpp/content_security_policy/content_security_policy.h"
#include "services/network/public/cpp/features.h"
#include "services/network/public/cpp/network_switches.h"
#include "services/network/public/cpp/parsed_headers.h"
#include "services/network/public/cpp/resource_request.h"
@ -2921,8 +2920,7 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext(
if (params_->shared_dictionary_enabled) {
builder.set_enable_shared_dictionary(true);
builder.set_enable_shared_zstd(
base::FeatureList::IsEnabled(network::features::kSharedZstd));
builder.set_enable_shared_zstd(true);
}
builder.SetWrapHttpNetworkLayerCallback(

2
services/network/public/cpp/features.cc

@ -287,8 +287,6 @@ BASE_FEATURE(kVisibilityAwareResourceScheduler,
"VisibilityAwareResourceScheduler",
base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kSharedZstd, "SharedZstd", base::FEATURE_ENABLED_BY_DEFAULT);
// This feature will reduce TransferSizeUpdated IPC from the network service.
// When enabled, the network service will send the IPC only when DevTools is
// attached or the request is for an ad request.

4
services/network/public/cpp/features.h

@ -118,10 +118,6 @@ BASE_DECLARE_FEATURE(kIntegrityPolicyScript);
COMPONENT_EXPORT(NETWORK_CPP_FLAGS_AND_SWITCHES)
BASE_DECLARE_FEATURE(kVisibilityAwareResourceScheduler);
// Enables Compression Dictionary Transport with Zstandard (aka Shared Zstd).
COMPONENT_EXPORT(NETWORK_CPP_FLAGS_AND_SWITCHES)
BASE_DECLARE_FEATURE(kSharedZstd);
COMPONENT_EXPORT(NETWORK_CPP_FLAGS_AND_SWITCHES)
BASE_DECLARE_FEATURE(kReduceTransferSizeUpdatedIPC);