Use a named namespace in BarrierCallback header, to avoid code bloat.
Change-Id: I325522e65289c6a9c85501059624a69ba1788f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3065824 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#908133}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
298dc7535d
commit
8c677a13cd
@ -16,7 +16,7 @@
|
||||
|
||||
namespace base {
|
||||
|
||||
namespace {
|
||||
namespace internal {
|
||||
|
||||
template <typename T>
|
||||
class BarrierCallbackInfo {
|
||||
@ -53,7 +53,7 @@ void ShouldNeverRun(T t) {
|
||||
CHECK(false);
|
||||
}
|
||||
|
||||
} // namespace
|
||||
} // namespace internal
|
||||
|
||||
// BarrierCallback<T> is an analog of BarrierClosure for which each `Run()`
|
||||
// invocation takes a `T` as an argument. After `num_callbacks` such
|
||||
@ -76,11 +76,11 @@ RepeatingCallback<void(T)> BarrierCallback(
|
||||
OnceCallback<void(std::vector<T>)> done_callback) {
|
||||
if (num_callbacks == 0) {
|
||||
std::move(done_callback).Run({});
|
||||
return BindRepeating(&ShouldNeverRun<T>);
|
||||
return BindRepeating(&internal::ShouldNeverRun<T>);
|
||||
}
|
||||
|
||||
return BindRepeating(&BarrierCallbackInfo<T>::Run,
|
||||
std::make_unique<BarrierCallbackInfo<T>>(
|
||||
return BindRepeating(&internal::BarrierCallbackInfo<T>::Run,
|
||||
std::make_unique<internal::BarrierCallbackInfo<T>>(
|
||||
num_callbacks, std::move(done_callback)));
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user