chromium/src
0
Fork 0
Code Activity

[fuchsia] Replace CRLF on Fuchsia

Browse Source 
On POSIX platforms, we convert from CRLF to LF. This applies that code
path on Fuchsia too.

Bug: 1402825
Change-Id: Iae548e1c9d8d1ba4a012f533cad39248e6110683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4159013
Auto-Submit: Fabrice de Gans <fdegans@chromium.org>
Quick-Run: Fabrice de Gans <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans <fdegans@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091609}
This commit is contained in:
Fabrice de Gans
2023-01-12 00:56:10 +00:00
committed by Chromium LUCI CQ
parent 885b94e54e
commit 8d04d47484
2 changed files with 2 additions and 5 deletions
pdf/pdfium
pdfium_engine.cc
testing/buildbot/filters
fuchsia.browser_tests.filter

4
pdf/pdfium/pdfium_engine.cc

@ -204,9 +204,9 @@ void FormatStringWithHyphens(std::u16string* text) {
base::ReplaceSubstringsAfterOffset(text, 0, kSpaceCrCn, kCrCn);
}
// Replace CR/LF with just LF on POSIX.
// Replace CR/LF with just LF on POSIX and Fuchsia.
void FormatStringForOS(std::u16string* text) {
#if BUILDFLAG(IS_POSIX)
#if BUILDFLAG(IS_POSIX) || BUILDFLAG(IS_FUCHSIA)
static constexpr char16_t kCr[] = {L'\r', L'\0'};
static constexpr char16_t kBlank[] = {L'\0'};
base::ReplaceChars(*text, kCr, kBlank, text);

3
testing/buildbot/filters/fuchsia.browser_tests.filter

@ -592,9 +592,6 @@
# the Chrome policy schema.
-Chunked/ChunkedPolicyPrefsTest.PolicyToPrefsMapping*
# TODO(crbug.com/1402825): Why is Fuchsia using "\r\n" as the line break?
-PDFExtensionTest.SelectAllShortcut
# TODO(crbug.com/1402824):
# Expected equality of these values:
# expect_success