chromium/src
0
Fork 0
Code Activity

Renable gn check for chrome/browser/policy/

Browse Source 
This involves adding a few missing deps.

gn check output for changes:
ERROR at //chrome/browser/policy/policy_path_parser_win.cc:17:11: Can't include this header from here.
#include "chrome/install_static/policy_path_parser.h"
          ^-----------------------------------------
The target:
  //chrome/browser/policy:path_parser
is including a file from the target:
  //chrome/install_static:install_static_util

ERROR at //chrome/browser/policy/policy_path_parser_mac.mm:21:11: Can't include this header from here.
#include "build/branding_buildflags.h"
          ^--------------------------
The target:
  //chrome/browser/policy:path_parser
is including a file from the target:
  //build:branding_buildflags

Change-Id: If70fc54a85ee31089a51aff2c0d08d5af5d8558a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140414
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757867}
This commit is contained in:
Chris Sharp
2020-04-09 15:59:46 +00:00
committed by Commit Bot
parent 96907f0f8c
commit 8d097452a1
2 changed files with 7 additions and 2 deletions
.gn
chrome/browser/policy
BUILD.gn

3
.gn

@ -159,8 +159,7 @@ check_targets = [
"//chrome/browser/permissions/*",
"//chrome/browser/picture_in_picture/*",
"//chrome/browser/plugins/*",
# "//chrome/browser/policy/*", # 1 error on Windows
"//chrome/browser/policy/*",
"//chrome/browser/predictors/*",
"//chrome/browser/prefetch/*",
"//chrome/browser/prefs/*",

6
chrome/browser/policy/BUILD.gn

@ -19,6 +19,12 @@ source_set("path_parser") {
]
if (is_win) {
deps += [ "//chrome/install_static:install_static_util" ]
libs = [ "wtsapi32.lib" ]
}
if (is_mac) {
deps += [ "//build:branding_buildflags" ]
}
}