chromium/src
0
Fork 0
Code Activity

[PDF Ink Signatures] Simplify some gmock WillByDefault() usage

Browse Source 
When the WillByDefault() action is to just return a constant, do that
with Return(), instead of writing a lambda that does the same thing.

Change-Id: I8ca6d1e419b309c0cb7ff1e532009f1fed26c640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312342
Reviewed-by: Alan Screen <awscreen@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1426675}
This commit is contained in:
Lei Zhang
2025-02-28 19:28:49 -08:00
committed by Chromium LUCI CQ
parent cf6ad02602
commit 8dffc449da
1 changed files with 6 additions and 11 deletions

17
pdf/pdf_view_web_plugin_unittest.cc

@ -2622,15 +2622,13 @@ class PdfViewWebPluginInkTest : public PdfViewWebPluginTest {
// not matter.
EXPECT_CALL(*engine_ptr_, HandleInputEvent).Times(0);
ON_CALL(*engine_ptr_, GetPageContentsRect)
.WillByDefault([](int page_index) -> gfx::Rect {
return gfx::Rect(/*x=*/0, /*y=*/0, /*width=*/100, /*height=*/50);
});
.WillByDefault(
Return(gfx::Rect(/*x=*/0, /*y=*/0, /*width=*/100, /*height=*/50)));
ON_CALL(*engine_ptr_, GetPageSizeInPoints)
.WillByDefault(Return(gfx::SizeF(/*width=*/75.0f, /*height=*/37.5f)));
.WillByDefault(Return(gfx::SizeF(75.0f, 37.5f)));
ON_CALL(*engine_ptr_, GetThumbnailSize)
.WillByDefault(Return(gfx::Size(50, 25)));
ON_CALL(*engine_ptr_, IsPageVisible)
.WillByDefault([](int page_index) -> bool { return true; });
ON_CALL(*engine_ptr_, IsPageVisible).WillByDefault(Return(true));
// Draw some trivial strokes.
plugin_->OnMessage(
@ -2970,15 +2968,12 @@ TEST_F(PdfViewWebPluginInkTest, DrawInProgressStroke) {
constexpr gfx::SizeF kPageSizeInPoints(
kCanvasSize.width() * kUnitConversionFactorPixelsToPoints,
kCanvasSize.height() * kUnitConversionFactorPixelsToPoints);
ON_CALL(*engine_ptr_, GetPageContentsRect)
.WillByDefault(
[kScreenRect](int page_index) -> gfx::Rect { return kScreenRect; });
ON_CALL(*engine_ptr_, GetPageContentsRect).WillByDefault(Return(kScreenRect));
ON_CALL(*engine_ptr_, GetPageSizeInPoints)
.WillByDefault(Return(kPageSizeInPoints));
ON_CALL(*engine_ptr_, GetThumbnailSize)
.WillByDefault(Return(gfx::Size(50, 50)));
ON_CALL(*engine_ptr_, IsPageVisible)
.WillByDefault([](int page_index) -> bool { return true; });
ON_CALL(*engine_ptr_, IsPageVisible).WillByDefault(Return(true));
UpdatePluginGeometry(/*device_scale=*/1.0f, kScreenRect);