Update .gitmodules after settings_internal was moved to
settings/internal This change should have been part of https://chromium-review.googlesource.com/c/chromium/src/+/5225481 Here's the full history: * The goal is b/319118045, adding an icon in Chrome Settings. * I wasn't able to access path `src/chrome/browser/resources/settings_internal` from `src/chrome/browser/resources/settings`, but I can reference it if `internal` is a subfolder of `settings`. * So I moved `settings_internal` to be `settings/internal` in https://chromium-review.googlesource.com/c/chromium/src/+/5225481. Note that the repo itself [chrome-internal/chrome/browser/resources/settings_internal](https://chrome-internal.googlesource.com/chrome/browser/resources/settings_internal) has not been renamed. It's just mapped to a different path in the main repo. * But I missed the reference in `.gitmodules` because it's not visible in Code Search. I'm fixing that in this CL. * The icon itself was added to the `settings_internal` repo in https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/settings_internal/+/6893127 * After this CL is submitted, I'll run `roll-dep` to pull the latest changes from repo `settings_internal` into `main` at the new `settings/internal` path. * I also rolled the dependencies of `third_party/dawn` repo in https://dawn-review.googlesource.com/c/dawn/+/172900. I doubt this matters, but the `settings_internal` reference showed up in Code Search. * The reference to the icon will be added in https://chromium-review.googlesource.com/c/chromium/src/+/5218772 (already approved). Bug: 1467623, b/319118045 Change-Id: I404ca6e1bea8408a06d4dc332a981a946ecf2ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258672 Reviewed-by: Matt Reichhoff <mreichhoff@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rusty Sammon <sammon@google.com> Cr-Commit-Position: refs/heads/main@{#1256181}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
856e63dffa
commit
8e239473e5
4
.gitmodules
vendored
4
.gitmodules
vendored
@ -607,8 +607,8 @@
|
||||
path = chrome/browser/resources/chromeos/quickoffice
|
||||
url = https://chrome-internal.googlesource.com/quickoffice/crx
|
||||
gclient-condition = (checkout_chromeos or checkout_linux) and checkout_src_internal
|
||||
[submodule "chrome/browser/resources/settings_internal"]
|
||||
path = chrome/browser/resources/settings_internal
|
||||
[submodule "chrome/browser/resources/settings/internal"]
|
||||
path = chrome/browser/resources/settings/internal
|
||||
url = https://chrome-internal.googlesource.com/chrome/browser/resources/settings_internal
|
||||
gclient-condition = checkout_src_internal
|
||||
[submodule "chrome/browser/spellchecker/internal"]
|
||||
|
Reference in New Issue
Block a user