chromium/src
0
Fork 0
Code Activity

Start formalizing set noparent policy

Browse Source 
The goal is to be able to eventually check this in a presubmit step.

Bug: 1018108
Change-Id: Idab1b13ccd8725f0839811f315ad700b4eb7af57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879252
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709557}
This commit is contained in:
Jochen Eisinger
2019-10-25 18:28:27 +00:00
committed by Commit Bot
parent c6a5f907c7
commit 8f0c8d83c9
3 changed files with 40 additions and 3 deletions

2
build/OWNERS

@ -19,6 +19,8 @@ per-file package_mac_toolchain.py=erikchen@chromium.org
per-file package_mac_toolchain.py=justincohen@chromium.org
per-file whitespace_file.txt=*
per-file OWNERS.status=*
per-file OWNERS.setnoparent=set noparent
per-file OWNERS.setnoparent=file://ENG_REVIEW_OWNERS
# gn-dev is probably a better team here, but the tooling won't let us
# have more than one team per component, and infra-dev is a catch-all

28
build/OWNERS.setnoparent Normal file

@ -0,0 +1,28 @@
# List of OWNERS files that can be used together with "set noparent". See
# docs/code_reviews.md#owners-file-details for more details.
# Overall project governance.
file://ENG_REVIEW_OWNERS
# Third-party dependency review, see //docs/adding_to_third_party.md
file://third_party/OWNERS
# Security reviews
file://chromeos/SECURITY_OWNERS
file://ipc/SECURITY_OWNERS
file://sandbox/linux/OWNERS
file://sandbox/mac/OWNERS
file://sandbox/OWNERS
file://sandbox/win/OWNERS
file://third_party/blink/SECURITY_OWNERS
# Privacy reviews
file://tools/metrics/ukm/PRIVACY_OWNERS
file://base/metrics/OWNERS
# Blink API owners are responsible for decisions about what APIs Blink should
# expose to the open web.
file://third_party/blink/API_OWNERS
# Extension API related files.
file://extensions/common/api/API_OWNERS

13
docs/code_reviews.md

@ -125,11 +125,18 @@ The text `set noparent` will stop owner propagation from parent directories.
This should be rarely used. If you want to use `set noparent` except for IPC
related files, please first reach out to chrome-eng-review@google.com.
In this example, only the two listed people are owners:
You have to use `set noparent` together with a reference to a file that lists
the owners for the given use case. Approved use cases are listed in
`//build/OWNERS.setnoparent`. Owners listed in those files are expected to
execute special governance functions such as eng review or ipc security review.
Every set of owners should implement their own means of auditing membership. The
minimum expectation is that membership in those files is reevaluated on
project, or affiliation changes.
In this example, only the eng reviewers are owners:
```
set noparent
a@chromium.org
b@chromium.org
file://ENG_REVIEW_OWNERS
```
The `per-file` directive allows owners to be added that apply only to files