0

Revert "[gn check] Enable //chrome/test:browser_tests"

This reverts commit 3f8634363f.

Reason for revert: suspect of breaking the build
https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/14902

Original change's description:
> [gn check] Enable //chrome/test:browser_tests
>
> This involves the following:
>
> - Eliminating many unneeded includes that cause unnecessary "gn check"
>   problems
> - Adding "nogncheck" to some conditionally-included headers in
>   //content. This was a pre-existing issue (the relevant targets are
>   conditionally depended on in GN, which doesn't take into account
>   conditionality when analyzing includes); it's unclear why GN check
>   started complaining about it with the changes in this CL, but the fix
>   is correct in any case given the problem.
> - Allow //chrome/test:browser_tests to depend on //pdf:pdf_internal.
>   This is due to a real dependence of
>   //chrome/browser/chrome_find_request_manager_browsertest.cc on
>   //pdf/document_loader_impl.h for a constant defined in that header
>   file.
>
> Bug: 1158929
> Change-Id: I87a082a1312306b918cfb730695cd3fada617ae3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2905653
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#886224}

Bug: 1158929
Change-Id: I6f9d3f80f957ebe3cf00b62c5a174259958cdaa8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2909586
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Mikel Astiz <mastiz@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886234}
This commit is contained in:
Mikel Astiz
2021-05-25 10:36:41 +00:00
committed by Chromium LUCI CQ
parent 9a8e1c0ce5
commit 8f984dbb5f
20 changed files with 22 additions and 317 deletions

1
.gn

@ -63,6 +63,7 @@ default_args = {
# their includes checked for proper dependencies when you run either
# "gn check" or "gn gen --check".
no_check_targets = [
"//chrome/test:browser_tests",
"//chrome/test:browser_tests_runner",
"//chrome/test:interactive_ui_tests",
"//chrome/test:unit_tests",

@ -25,7 +25,6 @@ component("ash") {
friend = [
":*",
"//ash/app_list:*",
"//chrome/test:browser_tests",
"//components/exo:*",
"//components/exo/wayland:*",
]
@ -2628,7 +2627,6 @@ static_library("test_support") {
"//ash/app_list:*",
"//ash/shortcut_viewer:*",
"//chrome/test:accessibility_live_site_tests",
"//chrome/test:browser_tests",
"//chrome/test:captured_sites_interactive_tests",
"//chrome/test:test_support",
"//chrome/test:test_support_ui",

@ -20,6 +20,7 @@
#include "chrome/browser/ash/arc/arc_util.h"
#include "chrome/browser/ash/arc/session/arc_session_manager.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/arc/arc_app_test.h"
#include "chrome/browser/ui/ash/shelf/chrome_shelf_controller.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/web_applications/components/app_registrar.h"

@ -29,6 +29,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/search_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/history/core/browser/history_service.h"

@ -24,6 +24,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/test_launcher_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/browsing_data/content/cookie_helper.h"

@ -16,6 +16,7 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/view_ids.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/blocked_content/popup_blocker_tab_helper.h"
#include "components/embedder_support/switches.h"

@ -5,6 +5,7 @@
#include "ash/public/cpp/test/shell_test_api.h"
#include "base/values.h"
#include "chrome/browser/policy/policy_test_utils.h"
#include "chrome/test/base/chrome_ash_test_base.h"
#include "components/policy/core/common/policy_map.h"
#include "components/policy/core/common/policy_types.h"
#include "components/policy/policy_constants.h"

@ -12,6 +12,7 @@
#include "chrome/browser/renderer_context_menu/mock_render_view_context_menu.h"
#include "chrome/test/base/chrome_test_utils.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chromeos/components/quick_answers/test/test_helpers.h"
#include "content/public/browser/context_menu_params.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"

@ -37,6 +37,7 @@
#include "chrome/common/chrome_features.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/performance_manager/public/features.h"
#include "content/public/browser/navigation_details.h"

@ -18,6 +18,7 @@
#include "chrome/test/base/ui_test_utils.h"
#include "components/prefs/testing_pref_service.h"
#include "components/safe_browsing/content/triggers/ad_redirect_trigger.h"
#include "components/safe_browsing/content/triggers/mock_trigger_manager.h"
#include "components/safe_browsing/core/common/safe_browsing_prefs.h"
#include "components/safe_browsing/core/features.h"
#include "content/public/browser/render_frame_host.h"

@ -8,6 +8,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/navigation_metrics/navigation_metrics.h"
#include "components/site_engagement/content/site_engagement_score.h"

@ -13,6 +13,7 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/sessions/core/tab_restore_service.h"
#include "content/public/browser/navigation_controller.h"

@ -21,6 +21,7 @@
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "components/password_manager/core/browser/mock_password_form_manager_for_ui.h"
#include "components/password_manager/core/browser/password_form.h"
#include "components/password_manager/core/browser/password_form_manager.h"

@ -13,6 +13,7 @@
#include "chrome/browser/ui/startup/credential_provider_signin_dialog_win_test_data.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/credential_provider/common/gcp_strings.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"

@ -19,6 +19,7 @@
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/common/bookmark_pref_names.h"

@ -14,6 +14,7 @@
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "chrome/browser/ui/views/webauthn/webauthn_icon_view.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/network_session_configurator/common/network_switches.h"
#include "content/public/browser/authenticator_environment.h"

@ -29,13 +29,11 @@ import("//components/nacl/features.gni")
import("//components/offline_pages/buildflags/features.gni")
import("//components/optimization_guide/features.gni")
import("//components/os_crypt/features.gni")
import("//components/safe_browsing/buildflags.gni")
import("//components/signin/features.gni")
import("//components/spellcheck/spellcheck_build_features.gni")
import("//extensions/buildflags/buildflags.gni")
import("//mojo/public/tools/bindings/mojom.gni")
import("//net/features.gni")
import("//pdf/features.gni")
import("//ppapi/buildflags/buildflags.gni")
import("//printing/buildflags/buildflags.gni")
import("//rlz/buildflags/buildflags.gni")
@ -903,7 +901,6 @@ if (!is_android) {
":test_support_ui",
"//base",
"//base:i18n",
"//base/allocator:buildflags",
"//base/test:test_support",
"//base/util/memory_pressure:test_support",
"//build:branding_buildflags",
@ -911,253 +908,88 @@ if (!is_android) {
"//chrome:packed_resources",
"//chrome:resources",
"//chrome:strings",
"//chrome/app:command_ids",
"//chrome/app/vector_icons",
"//chrome/browser",
"//chrome/browser:buildflags",
"//chrome/browser:cart_db_content_proto",
"//chrome/browser:theme_properties",
"//chrome/browser/apps/app_service:test_support",
"//chrome/browser/browsing_data:constants",
"//chrome/browser/devtools",
"//chrome/browser/devtools:test_support",
"//chrome/browser/extensions:test_support",
"//chrome/browser/image_decoder:browser_tests",
"//chrome/browser/media/router:media_router_feature",
"//chrome/browser/media/router:test_support",
"//chrome/browser/metrics:test_support",
"//chrome/browser/notifications/scheduler:factory",
"//chrome/browser/notifications/scheduler/public",
"//chrome/browser/notifications/scheduler/test:test_support",
"//chrome/browser/payments:browser_tests",
"//chrome/browser/persisted_state_db",
"//chrome/browser/privacy_budget:browser_tests",
"//chrome/browser/profiling_host:profiling_browsertests",
"//chrome/browser/resource_coordinator:tab_manager_features",
"//chrome/browser/resource_coordinator:tab_metrics_event_proto",
"//chrome/browser/resources/pdf/ink:buildflags",
"//chrome/browser/safe_browsing:verdict_cache_manager_factory",
"//chrome/browser/sharing/proto",
"//chrome/browser/web_applications:browser_tests",
"//chrome/browser/web_applications:web_applications_test_support",
"//chrome/browser/web_applications/extensions",
"//chrome/browser/webaudio:browser_tests",
"//chrome/common/privacy_budget:test_support",
"//chrome/renderer",
"//chrome/services/removable_storage_writer:lib",
"//chrome/test/data:web_ui_test_bindings",
"//chrome/test/data:webui_test_resources",
"//chrome/test/payments:test_support",
"//components/android_autofill/browser",
"//components/android_autofill/browser:test_support",
"//components/autofill/content/browser:risk_proto",
"//components/autofill/content/common/mojom",
"//components/autofill/content/renderer:test_support",
"//components/back_forward_cache",
"//components/background_fetch",
"//components/background_sync",
"//components/base32",
"//components/blocked_content",
"//components/bookmarks/browser",
"//components/bookmarks/common",
"//components/bookmarks/managed",
"//components/browser_sync",
"//components/browsing_data/content",
"//components/browsing_data/core",
"//components/captive_portal/content",
"//components/captive_portal/core",
"//components/captive_portal/core:buildflags",
"//components/captive_portal/core:test_support",
"//components/cast_channel",
"//components/cbor",
"//components/certificate_transparency",
"//components/constrained_window",
"//components/content_settings/browser",
"//components/content_settings/common:mojom",
"//components/cookie_config",
"//components/country_codes",
"//components/crash/content/browser/error_reporting:mock_crash_endpoint",
"//components/data_reduction_proxy/core/browser:test_support",
"//components/data_use_measurement/core",
"//components/data_use_measurement/core:ascriber",
"//components/dom_distiller/content/browser",
"//components/dom_distiller/content/browser:test_support",
"//components/dom_distiller/content/renderer",
"//components/dom_distiller/core:test_support",
"//components/drive:test_support",
"//components/embedder_support",
"//components/embedder_support:browser_util",
"//components/enterprise",
"//components/enterprise:test_support",
"//components/enterprise/common/proto:connectors_proto",
"//components/error_page/content/browser",
"//components/favicon/content",
"//components/favicon/core",
"//components/feature_engagement/public",
"//components/feature_engagement/test:test_support",
"//components/flags_ui",
"//components/heavy_ad_intervention",
"//components/history/content/browser",
"//components/history/core/common",
"//components/image_fetcher/core",
"//components/infobars/content",
"//components/invalidation/impl",
"//components/invalidation/impl:test_support",
"//components/javascript_dialogs",
"//components/language/core/browser",
"//components/language/core/common",
"//components/live_caption:constants",
"//components/lookalikes/core",
"//components/lookalikes/core:features",
"//components/metrics:content",
"//components/metrics/demographics",
"//components/metrics/demographics:test_support",
"//components/metrics_services_manager",
"//components/nacl/common:buildflags",
"//components/navigation_metrics",
"//components/no_state_prefetch/browser",
"//components/no_state_prefetch/common",
"//components/no_state_prefetch/renderer",
"//components/offline_items_collection/core/test_support",
"//components/optimization_guide/content/browser",
"//components/optimization_guide/content/mojom:mojo_interfaces",
"//components/optimization_guide/content/renderer",
"//components/optimization_guide/core",
"//components/optimization_guide/core:test_support",
"//components/optimization_guide/proto:optimization_guide_proto",
"//components/page_load_metrics/browser",
"//components/page_load_metrics/browser:test_support",
"//components/page_load_metrics/browser/observers/ad_metrics",
"//components/page_load_metrics/browser/observers/ad_metrics:test_support",
"//components/page_load_metrics/common",
"//components/page_load_metrics/common:test_support",
"//components/password_manager/content/browser",
"//components/password_manager/core/browser:proto",
"//components/password_manager/core/browser/form_parsing",
"//components/payments/content",
"//components/payments/content:utils",
"//components/pdf/browser",
"//components/performance_manager",
"//components/policy:chrome_settings_proto_generated_compile",
"//components/policy/core/browser:test_support",
"//components/policy/test_support",
"//components/privacy_sandbox:privacy_sandbox_prefs",
"//components/proxy_config",
"//components/reading_list/core",
"//components/reading_list/features:flags",
"//components/renderer_context_menu",
"//components/reputation/core",
"//components/reputation/core:proto",
"//components/resources",
"//components/safe_browsing:buildflags",
"//components/safe_browsing/content/browser",
"//components/safe_browsing/content/browser:client_side_detection",
"//components/safe_browsing/content/common:interfaces",
"//components/safe_browsing/content/common:interfaces_shared_cpp_sources",
"//components/safe_browsing/content/password_protection",
"//components/safe_browsing/content/password_protection:test_support",
"//components/safe_browsing/content/renderer",
"//components/safe_browsing/content/renderer/phishing_classifier",
"//components/safe_browsing/content/renderer/phishing_classifier:unit_tests_support",
"//components/safe_browsing/content/triggers:ad_redirect_trigger",
"//components/safe_browsing/content/web_ui",
"//components/safe_browsing/core:client_model_proto",
"//components/safe_browsing/core:features",
"//components/safe_browsing/core:public",
"//components/safe_browsing/core:verdict_cache_manager",
"//components/safe_browsing/core/db:metadata_proto",
"//components/safe_browsing/core/db:test_database_manager",
"//components/safe_browsing/core/db:v4_database",
"//components/safe_browsing/core/db:v4_get_hash_protocol_manager",
"//components/safe_browsing/core/password_protection:password_protection_metrics_util",
"//components/search",
"//components/security_interstitials/content:proto",
"//components/security_interstitials/content:security_interstitial_page",
"//components/security_interstitials/core:unsafe_resource",
"//components/security_state/content",
"//components/services/app_service/public/cpp:app_url_handling",
"//components/services/app_service/public/cpp:protocol_handling",
"//components/services/language_detection/public/cpp",
"//components/services/patch/content",
"//components/services/patch/public/cpp",
"//components/services/patch/public/mojom",
"//components/services/quarantine:test_support",
"//components/signin/core/browser",
"//components/signin/public/base:signin_buildflags",
"//components/signin/public/identity_manager",
"//components/site_engagement/content",
"//components/site_isolation",
"//components/soda",
"//components/soda:constants",
"//components/spellcheck:buildflags",
"//components/spellcheck/browser",
"//components/spellcheck/common",
"//components/spellcheck/common:interfaces",
"//components/spellcheck/common:spellcheck_result",
"//components/spellcheck/renderer",
"//components/ssl_errors",
"//components/strings",
"//components/subresource_filter/core/browser",
"//components/subresource_filter/core/browser:test_support",
"//components/subresource_filter/core/common:test_support",
"//components/subresource_redirect/common",
"//components/subresource_redirect/proto",
"//components/sync",
"//components/sync:test_support_model",
"//components/sync/test/fake_server",
"//components/sync_device_info:test_support",
"//components/tab_count_metrics",
"//components/tab_groups",
"//components/translate/content/browser:test_support",
"//components/translate/content/renderer",
"//components/translate/core/common",
"//components/translate/core/language_detection",
"//components/ukm/content",
"//components/unified_consent",
"//components/user_manager",
"//components/variations/service",
"//components/webapps/browser",
"//components/webrtc",
"//components/webrtc_logging/browser",
"//content/test:browsertest_support",
"//content/test:test_support",
"//courgette:bsdiff",
"//courgette:courgette_lib",
"//crypto:platform",
"//crypto:test_support",
"//device/bluetooth:mocks",
"//device/fido:cablev2_test_util",
"//device/fido:test_support",
"//extensions/browser/updater",
"//extensions/buildflags",
"//extensions/renderer",
"//google_apis:test_support",
"//media:media_buildflags",
"//media:test_support",
"//media/cast:test_support",
"//media/cdm:cdm_paths",
"//media/mojo/services",
"//mojo/core/embedder",
"//mojo/public/cpp/system",
"//net",
"//net:extras",
"//net:test_support",
"//pdf:features",
"//ppapi/buildflags",
"//ppapi/shared_impl:test_support",
"//printing/buildflags",
"//rlz/buildflags",
"//services/device/public/cpp:test_support",
"//services/device/public/mojom",
"//services/image_annotation/public/cpp",
"//services/network/public/cpp",
"//services/network/public/proto:sct_audit_report_proto",
"//services/preferences/public/cpp",
"//services/preferences/public/cpp/tracked",
"//services/service_manager/public/cpp",
"//services/strings",
"//skia",
"//storage/browser:test_support",
"//testing/gmock",
"//testing/gtest",
"//testing/perf",
@ -1171,20 +1003,15 @@ if (!is_android) {
"//third_party/webrtc_overrides:webrtc_component",
"//third_party/widevine/cdm:buildflags",
"//third_party/widevine/cdm:headers",
"//third_party/zlib/google:zip",
"//ui/accessibility:test_support",
"//ui/base:test_support",
"//ui/base/clipboard:clipboard_test_support",
"//ui/base/dragdrop/mojom",
"//ui/compositor:test_support",
"//ui/display:display_manager_test_api",
"//ui/display:test_support",
"//ui/display/manager",
"//ui/native_theme:test_support",
"//ui/resources",
"//ui/shell_dialogs:test_support",
"//ui/web_dialogs:test_support",
"//ui/webui",
"//ui/webui:test_support",
"//v8",
]
@ -1769,7 +1596,6 @@ if (!is_android) {
"../browser/ui/native_window_tracker_browsertest.cc",
"../browser/ui/omnibox/alternate_nav_infobar_delegate_browsertest.cc",
"../browser/ui/passwords/manage_passwords_test.cc",
"../browser/ui/passwords/manage_passwords_test.h",
"../browser/ui/passwords/password_generation_popup_view_browsertest.cc",
"../browser/ui/passwords/password_generation_popup_view_tester.h",
"../browser/ui/passwords/well_known_change_password_navigation_throttle_browsertest.cc",
@ -1805,7 +1631,6 @@ if (!is_android) {
"../browser/ui/update_chrome_dialog_browsertest.cc",
"../browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc",
"../browser/ui/views/bookmarks/bookmark_bar_view_browsertest.cc",
"../browser/ui/views/bookmarks/bookmark_bar_view_test_helper.h",
"../browser/ui/views/content_setting_bubble_contents_browsertest.cc",
"../browser/ui/views/content_test_utils.cc",
"../browser/ui/views/content_test_utils.h",
@ -1953,14 +1778,6 @@ if (!is_android) {
]
deps += [ "//services/audio/public/cpp:test_support" ]
if (enable_pdf) {
deps += [ "//pdf:internal" ]
}
if (safe_browsing_mode != 0) {
deps += [ "//components/safe_browsing/core:download_file_types_proto" ]
}
if (is_mac) {
sources += [
"../browser/app_controller_mac_browsertest.mm",
@ -1975,14 +1792,6 @@ if (!is_android) {
"../common/mac/mock_launchd.h",
"../common/mac/mock_launchd.mm",
]
deps += [
"//chrome/app_shim",
"//chrome/browser/apps/app_shim",
"//components/onc",
"//components/remote_cocoa/app_shim",
"//ui/accelerated_widget_mac",
]
}
if (is_linux || is_chromeos) {
@ -2015,16 +1824,7 @@ if (!is_android) {
]
data_deps += [ "//chrome/browser/web_applications/chrome_pwa_launcher" ]
data += [ "$root_out_dir/chrome_200_percent.pak" ]
deps += [
"//chrome/app:chrome_dll_resources",
"//chrome/browser/safe_browsing/chrome_cleaner",
"//chrome/browser/safe_browsing/chrome_cleaner:public",
"//chrome/browser/ui/startup:buildflags",
"//chrome/credential_provider/common:common_constants",
"//components/chrome_cleaner/public/constants",
"//components/onc",
"//sandbox/win:sandbox",
]
deps += [ "//chrome/app:chrome_dll_resources" ]
}
if (enable_soda) {
@ -2098,121 +1898,33 @@ if (!is_android) {
deps += [
"//ash:test_support",
"//ash/app_list",
"//ash/app_list:test_support",
"//ash/app_list/model:app_list_model",
"//ash/components/audio",
"//ash/components/os_feedback_ui:os_feedback_ui",
"//ash/content/scanning",
"//ash/content/shimless_rma",
"//ash/content/shortcut_customization_ui",
"//ash/keyboard/ui:test_support",
"//ash/public/cpp/external_arc",
"//chrome/browser/ash/system_extensions:browser_tests",
"//chrome/browser/ash/wilco_dtc_supportd:mojo_utils",
"//chrome/browser/chromeos:arc_test_support",
"//chrome/browser/chromeos:dlp_policy_event_proto",
"//chrome/browser/chromeos:key_permissions_proto",
"//chrome/browser/chromeos:test_support",
"//chrome/browser/image_decoder",
"//chrome/browser/media/router:test_support",
"//chrome/browser/nearby_sharing/common",
"//chrome/browser/resources/chromeos/accessibility:browser_tests",
"//chrome/browser/ui:ash_test_support",
"//chrome/browser/ui/ash/holding_space:browser_tests",
"//chrome/browser/ui/webui/chromeos/add_supervision:mojo_bindings",
"//chrome/browser/ui/webui/chromeos/crostini_upgrader:mojo_bindings",
"//chrome/browser/ui/webui/settings/chromeos/constants:mojom",
"//chrome/services/file_util/public/cpp:browser_tests",
"//chrome/services/keymaster/public/mojom",
"//chrome/services/wilco_dtc_supportd/public/mojom",
"//chromeos:test_support",
"//chromeos/assistant:buildflags",
"//chromeos/attestation",
"//chromeos/attestation:test_support",
"//chromeos/components/demo_mode_app_ui",
"//chromeos/components/diagnostics_ui",
"//chromeos/components/drivefs",
"//chromeos/components/drivefs:test_support",
"//chromeos/components/drivefs/mojom",
"//chromeos/components/eche_app_ui",
"//chromeos/components/help_app_ui",
"//chromeos/components/media_app_ui",
"//chromeos/components/media_app_ui:browser_test_support",
"//chromeos/components/print_management",
"//chromeos/components/sample_system_web_app_ui",
"//chromeos/components/smbfs",
"//chromeos/components/telemetry_extension_ui",
"//chromeos/components/web_applications/test:test_support",
"//chromeos/cryptohome",
"//chromeos/dbus:test_support",
"//chromeos/dbus/attestation",
"//chromeos/dbus/attestation:attestation_proto",
"//chromeos/dbus/authpolicy",
"//chromeos/dbus/biod",
"//chromeos/dbus/cros_healthd",
"//chromeos/dbus/cryptohome",
"//chromeos/dbus/cryptohome:cryptohome_proto",
"//chromeos/dbus/power",
"//chromeos/dbus/services:test_support",
"//chromeos/dbus/session_manager",
"//chromeos/dbus/system_clock",
"//chromeos/dbus/system_proxy",
"//chromeos/dbus/system_proxy:system_proxy_proto",
"//chromeos/dbus/upstart",
"//chromeos/disks",
"//chromeos/disks:test_support",
"//chromeos/geolocation",
"//chromeos/login/auth",
"//chromeos/login/auth:challenge_response_key",
"//chromeos/login/auth:test_support",
"//chromeos/login/login_state:test_support",
"//chromeos/process_proxy",
"//chromeos/services/assistant:lib",
"//chromeos/services/assistant/public/cpp",
"//chromeos/services/assistant/public/proto",
"//chromeos/services/machine_learning/public/cpp:stub",
"//chromeos/services/multidevice_setup/public/cpp:test_support",
"//chromeos/services/tts",
"//chromeos/system",
"//chromeos/timezone",
"//chromeos/ui/base",
"//chromeos/ui/frame",
"//components/arc:arc_test_support",
"//components/arc/enterprise",
"//components/device_event_log",
"//components/drive",
"//components/exo:test_support",
"//components/full_restore",
"//components/onc",
"//components/prefs",
"//components/quirks",
"//components/reporting/client:test_support",
"//components/rlz",
"//components/services/app_service/public/cpp:icon_loader",
"//components/services/app_service/public/cpp:instance_update",
"//components/services/app_service/public/cpp:intents",
"//components/services/app_service/public/cpp:test_support",
"//components/session_manager/core",
"//components/upload_list",
"//components/user_manager:test_support",
"//components/web_resource",
"//extensions/components/native_app_window",
"//mojo/core/embedder",
"//services/audio/public/cpp",
"//services/audio/public/cpp:test_support",
"//services/device/public/cpp/hid",
"//services/network/public/mojom",
"//services/preferences/public/cpp",
"//services/preferences/public/mojom",
"//services/service_manager/public/cpp",
"//third_party/blink/public/common",
"//ui/base/idle",
"//ui/base/idle:test_support",
"//ui/base/ime/chromeos",
"//ui/chromeos",
"//ui/events/devices:test_support",
"//ui/wm/public",
"//url",
]
@ -2252,12 +1964,6 @@ if (!is_android) {
sources += [
"../browser/apps/app_service/web_apps_publisher_host_browsertest.cc",
]
deps += [
"//chromeos/crosapi/mojom",
"//chromeos/lacros",
"//chromeos/ui/base",
"//chromeos/ui/frame:test_support",
]
}
if (!is_chromeos) {
@ -2360,11 +2066,7 @@ if (!is_android) {
"nacl/pnacl_header_test.cc",
"nacl/pnacl_header_test.h",
]
deps += [
"//components/nacl/browser",
"//components/nacl/renderer",
"//components/nacl/renderer/plugin:nacl_trusted_plugin",
]
deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]
data_deps += [
"//chrome/test/data/nacl",
@ -2961,7 +2663,6 @@ if (!is_android) {
"../browser/ash/child_accounts/parent_access_code/parent_access_test_utils.h",
"../browser/ash/child_accounts/screen_time_controller_browsertest.cc",
"../browser/ash/child_accounts/time_limit_test_utils.cc",
"../browser/ash/child_accounts/time_limit_test_utils.h",
"../browser/ash/child_accounts/time_limits/app_time_browsertest.cc",
"../browser/ash/child_accounts/time_limits/app_time_limits_allowlist_policy_test_utils.cc",
"../browser/ash/child_accounts/time_limits/app_time_limits_allowlist_policy_test_utils.h",
@ -3129,7 +2830,6 @@ if (!is_android) {
"../browser/ash/login/webview_login_browsertest.cc",
"../browser/ash/login/wizard_controller_browsertest.cc",
"../browser/ash/plugin_vm/plugin_vm_test_helper.cc",
"../browser/ash/plugin_vm/plugin_vm_test_helper.h",
"../browser/ash/profiles/profile_helper_browsertest.cc",
"../browser/ash/remote_apps/remote_apps_impl_browsertest.cc",
"../browser/ash/remote_apps/remote_apps_manager_browsertest.cc",
@ -3639,8 +3339,6 @@ if (!is_android) {
sources += [ "../browser/printing/print_backend_browsertest.cc" ]
deps += [
"//chrome/services/printing:lib",
"//components/printing/browser",
"//components/printing/common:mojo_interfaces",
"//printing:test_support",
]
}

@ -16,8 +16,8 @@
#include "base/logging.h"
#include "base/strings/strcat.h"
#include "base/strings/utf_string_conversions.h"
#include "components/crash/content/browser/error_reporting/javascript_error_report.h" // nogncheck
#include "components/crash/content/browser/error_reporting/js_error_report_processor.h" // nogncheck
#include "components/crash/content/browser/error_reporting/javascript_error_report.h"
#include "components/crash/content/browser/error_reporting/js_error_report_processor.h"
#include "content/browser/renderer_host/render_frame_host_impl.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/web_contents.h"

@ -10,8 +10,8 @@
#include "base/metrics/field_trial_params.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "components/crash/content/browser/error_reporting/javascript_error_report.h" // nogncheck
#include "components/crash/content/browser/error_reporting/js_error_report_processor.h" // nogncheck
#include "components/crash/content/browser/error_reporting/javascript_error_report.h"
#include "components/crash/content/browser/error_reporting/js_error_report_processor.h"
#include "content/public/browser/site_instance.h"
#include "content/public/browser/web_ui_controller.h"
#include "content/public/common/content_features.h"

@ -83,13 +83,7 @@ if (enable_pdf) {
}
source_set("internal") {
visibility = [
":*",
# TODO(crbug.com/1158929): Eliminate chrome_find_request_manager_browsertest.cc's dependence
# on document_loader_impl.h.
"//chrome/test:browser_tests",
]
visibility = [ ":*" ]
sources = [
"accessibility.cc",