chromium/src
0
Fork 0
Code Activity

Fix findbugs issues

Browse Source 
Constants should be private static final.
Since I'm there, renamed TAG to LOGTAG so it is obvious it is only used for logging.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11827057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176288 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
kristianm@chromium.org
2013-01-11 08:53:33 +00:00
parent cff7b7b50c
commit 90a2dfbe6b
2 changed files with 3 additions and 5 deletions
build/android/findbugs_filter
findbugs_known_bugs.txt
testing/android/java/src/org/chromium/native_test
ChromeNativeTestActivity.java

2
build/android/findbugs_filter/findbugs_known_bugs.txt

@@ -109,8 +109,6 @@ M P SIC: Should org.chromium.content.browser.JavaBridgeReturnValuesTest$CustomTy
M P SIC: Should org.chromium.content.browser.PopupZoomerTest$CustomCanvasPopupZoomer be a _static_ inner class? At PopupZoomerTest.java
M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.IMAGE_PREFIX; should this field be static? At ImagePageGenerator.java
M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.IMAGE_SUFFIX; should this field be static? At ImagePageGenerator.java
M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.EXTRA_RUN_IN_SUB_THREAD; should this field be static? At ChromeNativeTestActivity.java
M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.TAG; should this field be static? At ChromeNativeTestActivity.java
M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastFling2 At ContentViewGestureHandlerTest.java
M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll1 At ContentViewGestureHandlerTest.java
M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll2 At ContentViewGestureHandlerTest.java

6
testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java

@@ -21,10 +21,10 @@ import java.io.File;
// Our tests need to go up to our own java classes, which is not possible using
// the native activity class loader.
public class ChromeNativeTestActivity extends ChromiumActivity {
private final String TAG = "ChromeNativeTestActivity";
private final String EXTRA_RUN_IN_SUB_THREAD = "RunInSubThread";
private static final String TAG = "ChromeNativeTestActivity";
private static final String EXTRA_RUN_IN_SUB_THREAD = "RunInSubThread";
// We post a delayed task to run tests so that we do not block onCreate().
private static long RUN_TESTS_DELAY_IN_MS = 300;
private static final long RUN_TESTS_DELAY_IN_MS = 300;
// Name of our shlib as obtained from a string resource.
private String mLibrary;