chromium/src
0
Fork 0
Code Activity

Revert "Revert "Add presubmit checks to look for BUG= and TEST= tags in change list description.""

Browse Source 
This reverts commit fb3644d302ea26efbe2a2e761beea2d3f26bac59.

Review URL: http://codereview.chromium.org/115577


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16612 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
kuchhal@chromium.org
2009-05-21 17:04:56 +00:00
parent a79cd3fb99
commit 917f58b57b
1 changed files with 6 additions and 2 deletions

8
PRESUBMIT.py

@ -40,14 +40,18 @@ def ReadFile(path):
def CheckChangeOnUpload(input_api, output_api):
# TODO(maruel): max_cols is temporarily disabled. Reenable once the source
# tree is in better shape.
return LocalChecks(input_api, output_api, max_cols=0)
return (LocalChecks(input_api, output_api, max_cols=0) +
input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) +
input_api.canned_checks.CheckChangeHasTestField(input_api, output_api))
def CheckChangeOnCommit(input_api, output_api):
# TODO(maruel): max_cols is temporarily disabled. Reenable once the source
# tree is in better shape.
return (LocalChecks(input_api, output_api, max_cols=0) +
input_api.canned_checks.CheckDoNotSubmit(input_api, output_api))
input_api.canned_checks.CheckDoNotSubmit(input_api, output_api) +
input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) +
input_api.canned_checks.CheckChangeHasTestField(input_api, output_api))
def LocalChecks(input_api, output_api, max_cols=80):