0

[MappableSI] New build component for GpuMemoryBufferManager.

Currently gpu/ipc/common/ipc_common_sources depends on
gpu/command_buffer/client:client_sources only to include/use
gpu/command_buffer/client/gpu_memory_buffer_manager.h. Hence move that
single file to its own component.

This is because in future gpu/command_buffer/client:client_sources will
want to depend on gpu/ipc/common/ipc_common_sources and will create a
circular dependency.

Bug: 1433317, 1433318
Change-Id: Ifb871cd76e8ac1417a3a5df74ddc880971065e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4776118
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: vikas soni <vikassoni@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1184775}
This commit is contained in:
Vikas Soni
2023-08-17 17:12:34 +00:00
committed by Chromium LUCI CQ
parent 3d618916b4
commit 93c643a9ce
2 changed files with 26 additions and 3 deletions
gpu
command_buffer
client
ipc
common

@ -25,6 +25,10 @@ group("client") {
}
}
group("client_gmb_manager") {
public_deps = [ ":client_gmb_manager_sources" ]
}
group("gles2_cmd_helper") {
if (is_component_build) {
public_deps = [ "//gpu:gles2" ]
@ -68,7 +72,6 @@ source_set("client_sources") {
"gl_helper_scaling.cc",
"gl_helper_scaling.h",
"gpu_control.h",
"gpu_memory_buffer_manager.h",
"image_decode_accelerator_interface.h",
"mapped_memory.cc",
"mapped_memory.h",
@ -82,7 +85,10 @@ source_set("client_sources") {
all_dependent_configs = [ "//third_party/khronos:khronos_headers" ]
public_deps = [ "//base" ]
public_deps = [
":client_gmb_manager",
"//base",
]
deps = [
":gles2_interface",
"//gpu/command_buffer/common:common_sources",
@ -110,6 +116,23 @@ source_set("client_sources") {
}
}
source_set("client_gmb_manager_sources") {
# External code should depend on this via //gpu/client_gmb_manager above
# rather than depending on this directly or the component build will break.
visibility = [ "//gpu/*" ]
sources = [ "gpu_memory_buffer_manager.h" ]
configs += [ "//gpu:gpu_implementation" ]
all_dependent_configs = [ "//third_party/khronos:khronos_headers" ]
deps = [
"//base",
"//ui/gfx:memory_buffer",
"//ui/gfx/geometry",
]
if (!is_nacl) {
deps += [ "//gpu/ipc/common:surface_handle_type" ]
}
}
source_set("gles2_cmd_helper_sources") {
visibility = [ "//gpu/*" ]
sources = [

@ -137,7 +137,7 @@ source_set("ipc_common_sources") {
deps = [
"//base",
"//components/viz/common:shared_image_format",
"//gpu/command_buffer/client:client_sources",
"//gpu/command_buffer/client:client_gmb_manager",
"//gpu/command_buffer/common:common_sources",
"//gpu/config:config_sources",
"//third_party/libyuv",