chromium/src
0
Fork 0
Code Activity

Only report GURL metrics/traces on the UI thread.

Browse Source 
If GURL is used from a background thread during startup, we don't care
about the time it takes to load GURL as it's not blocking startup.

See https://crbug.com/1065377, the initial stack trace reports are all
coming from background threads.

Bug: 783819
Change-Id: Ifa9b998dbeda974f644aa70686761b366460fd2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124297
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754037}
This commit is contained in:
Michael Thiessen
2020-03-27 16:22:23 +00:00
committed by Commit Bot
parent 957f13cefe
commit 945bef095c
1 changed files with 14 additions and 9 deletions

23
url/android/java/src/org/chromium/url/GURL.java

@ -10,6 +10,7 @@ import android.text.TextUtils;
import androidx.annotation.Nullable;
import org.chromium.base.Log;
import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.MainDex;
@ -98,17 +99,21 @@ public class GURL {
*/
public static void ensureNativeInitializedForGURL() {
if (LibraryLoader.getInstance().isInitialized()) return;
if (sReportCallback != null && new Random().nextInt(100) < DEBUG_REPORT_PERCENTAGE) {
final Throwable throwable = new Throwable("This is not a crash, please ignore.");
// This isn't an assert, because by design this is possible, but this path is getting
// hit much more than expected and getting stack traces from the wild will help debug.
PostTask.postTask(
TaskTraits.BEST_EFFORT_MAY_BLOCK, () -> { sReportCallback.run(throwable); });
}
long time = SystemClock.elapsedRealtime();
LibraryLoader.getInstance().ensureMainDexInitialized();
RecordHistogram.recordTimesHistogram("Startup.Android.GURLEnsureMainDexInitialized",
SystemClock.elapsedRealtime() - time);
// Record metrics only for the UI thread where the delay in loading the library is relevant.
if (ThreadUtils.runningOnUiThread()) {
RecordHistogram.recordTimesHistogram("Startup.Android.GURLEnsureMainDexInitialized",
SystemClock.elapsedRealtime() - time);
if (sReportCallback != null && new Random().nextInt(100) < DEBUG_REPORT_PERCENTAGE) {
final Throwable throwable = new Throwable("This is not a crash, please ignore.");
// This isn't an assert, because by design this is possible, but we would prefer
// this path does not get hit more than necessary and getting stack traces from the
// wild will help find issues.
PostTask.postTask(TaskTraits.BEST_EFFORT_MAY_BLOCK,
() -> { sReportCallback.run(throwable); });
}
}
}
@CalledByNative