0

[reclient] Add Win Builder (reclient shadow)

Currently reclient release is blocked on a dependency scanner issue. Issue was discovered on Win Builder and not reproducible elsewhere. Create a shadow builder running on reclient_experimental to investigate the root cause of the failure.

Bug: 352206623
Change-Id: Id1c2cc73bec4d78846f114e5e2c73919cea7e329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5742418
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andus Yu <andusyu@google.com>
Reviewed-by: Ben Segall <bentekkie@google.com>
Cr-Commit-Position: refs/heads/main@{#1334379}
This commit is contained in:
Andus Yu
2024-07-29 19:09:57 +00:00
committed by Chromium LUCI CQ
parent 57c25ea05a
commit 94f59ad4f1
10 changed files with 232 additions and 0 deletions

@ -0,0 +1 @@
reclient/Win Builder (reclient shadow)

@ -442,6 +442,7 @@
"Simple Chrome Builder reclient staging untrusted": "reclient/Simple Chrome Builder reclient staging untrusted/gn-args.json",
"Simple Chrome Builder reclient test": "reclient/Simple Chrome Builder reclient test/gn-args.json",
"Simple Chrome Builder reclient test untrusted": "reclient/Simple Chrome Builder reclient test untrusted/gn-args.json",
"Win Builder (reclient shadow)": "reclient/Win Builder (reclient shadow)/gn-args.json",
"Win x64 Builder reclient staging": "reclient/Win x64 Builder reclient staging/gn-args.json",
"Win x64 Builder reclient staging untrusted": "reclient/Win x64 Builder reclient staging untrusted/gn-args.json",
"Win x64 Builder reclient test": "reclient/Win x64 Builder reclient test/gn-args.json",

@ -0,0 +1,14 @@
{
"gn_args": {
"dcheck_always_on": false,
"ffmpeg_branding": "Chrome",
"is_component_build": false,
"is_debug": false,
"proprietary_codecs": true,
"symbol_level": 0,
"target_cpu": "x86",
"target_os": "win",
"use_remoteexec": true,
"use_siso": true
}
}

@ -0,0 +1,71 @@
{
"$build/chromium_tests_builder_config": {
"builder_config": {
"additional_exclusions": [
"infra/config/generated/builders/reclient/Win Builder (reclient shadow)/gn-args.json"
],
"builder_db": {
"entries": [
{
"builder_id": {
"bucket": "reclient",
"builder": "Win Builder (reclient shadow)",
"project": "chromium"
},
"builder_spec": {
"build_gs_bucket": "chromium-win-archive",
"builder_group": "chromium.reclient.fyi",
"execution_mode": "COMPILE_AND_TEST",
"legacy_chromium_config": {
"apply_configs": [
"mb"
],
"build_config": "Release",
"config": "chromium",
"target_bits": 32,
"target_platform": "win"
},
"legacy_gclient_config": {
"apply_configs": [
"reclient_experimental"
],
"config": "chromium"
}
}
}
]
},
"builder_ids": [
{
"bucket": "reclient",
"builder": "Win Builder (reclient shadow)",
"project": "chromium"
}
]
}
},
"$build/reclient": {
"instance": "rbe-chromium-trusted",
"metrics_project": "chromium-reclient-metrics",
"scandeps_server": true
},
"$build/siso": {
"configs": [
"builder"
],
"enable_cloud_profiler": true,
"enable_cloud_trace": true,
"experiments": [],
"project": "rbe-chromium-trusted",
"remote_jobs": 250
},
"$recipe_engine/resultdb/test_presentation": {
"column_keys": [],
"grouping_keys": [
"status",
"v.test_suite"
]
},
"builder_group": "chromium.reclient.fyi",
"recipe": "chromium"
}

@ -64561,6 +64561,97 @@ buckets {
dimensions: "pool:luci.chromium.try"
}
}
builders {
name: "Win Builder (reclient shadow)"
swarming_host: "chromium-swarm.appspot.com"
dimensions: "builder:Win Builder (reclient shadow)"
dimensions: "cores:32"
dimensions: "cpu:x86-64"
dimensions: "os:Windows"
dimensions: "pool:luci.chromium.ci"
exe {
cipd_package: "infra/chromium/bootstrapper/${platform}"
cipd_version: "latest"
cmd: "bootstrapper"
}
properties:
'{'
' "$bootstrap/exe": {'
' "exe": {'
' "cipd_package": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build",'
' "cipd_version": "refs/heads/main",'
' "cmd": ['
' "luciexe"'
' ]'
' }'
' },'
' "$bootstrap/properties": {'
' "properties_file": "infra/config/generated/builders/reclient/Win Builder (reclient shadow)/properties.json",'
' "top_level_project": {'
' "ref": "refs/heads/main",'
' "repo": {'
' "host": "chromium.googlesource.com",'
' "project": "chromium/src"'
' }'
' }'
' },'
' "builder_group": "chromium.reclient.fyi",'
' "led_builder_is_bootstrapped": true,'
' "recipe": "chromium"'
'}'
execution_timeout_secs: 10800
build_numbers: YES
service_account: "chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
experiments {
key: "chromium_swarming.expose_merge_script_failures"
value: 100
}
experiments {
key: "luci.recipes.use_python3"
value: 100
}
resultdb {
enable: true
bq_exports {
project: "chrome-luci-data"
dataset: "chromium"
table: "ci_test_results"
test_results {}
}
bq_exports {
project: "chrome-luci-data"
dataset: "chromium"
table: "gpu_ci_test_results"
test_results {
predicate {
test_id_regexp: "ninja://(chrome|content)/test:telemetry_gpu_integration_test[^/]*/.+"
}
}
}
bq_exports {
project: "chrome-luci-data"
dataset: "chromium"
table: "blink_web_tests_ci_test_results"
test_results {
predicate {
test_id_regexp: "(ninja://[^/]*blink_web_tests/.+)|(ninja://[^/]*_wpt_tests/.+)"
}
}
}
history_options {
use_invocation_timestamp: true
}
}
description_html: "This builder mirrors Win Builder in order to debug an reclient dependency scanner issue (crbug.com/352206623)."
shadow_builder_adjustments {
service_account: "chromium-try-builder@chops-service-accounts.iam.gserviceaccount.com"
pool: "luci.chromium.try"
dimensions: "builder:"
dimensions: "builderless:1"
dimensions: "pool:luci.chromium.try"
}
contact_team_email: "git-build-tools@google.com"
}
builders {
name: "Win x64 Builder reclient staging"
swarming_host: "chromium-swarm.appspot.com"

@ -13431,6 +13431,11 @@ consoles {
category: "rbecq|win"
short_name: "rcs"
}
builders {
name: "buildbucket/luci.chromium.reclient/Win Builder (reclient shadow)"
category: "release|builder"
short_name: "32"
}
builders {
name: "buildbucket/luci.chromium.reclient/Win x64 Cross Builder (reclient compare)"
category: "win"

@ -3032,6 +3032,15 @@ job {
builder: "Win Builder (dbg)"
}
}
job {
id: "Win Builder (reclient shadow)"
realm: "reclient"
buildbucket {
server: "cr-buildbucket.appspot.com"
bucket: "reclient"
builder: "Win Builder (reclient shadow)"
}
}
job {
id: "Win x64 Builder"
realm: "ci"
@ -6836,6 +6845,7 @@ trigger {
triggers: "Simple Chrome Builder reclient staging untrusted"
triggers: "Simple Chrome Builder reclient test"
triggers: "Simple Chrome Builder reclient test untrusted"
triggers: "Win Builder (reclient shadow)"
triggers: "Win x64 Builder reclient staging"
triggers: "Win x64 Builder reclient staging untrusted"
triggers: "Win x64 Builder reclient test"

@ -840,3 +840,32 @@ The bot specs should be in sync with <a href="https://ci.chromium.org/p/chromium
siso_project = siso.project.TEST_UNTRUSTED,
siso_remote_jobs = siso.remote_jobs.HIGH_JOBS_FOR_CQ,
)
# TODO(crbug.com/352206623) Turn down builder once reclient depscan issue has been resolved.
ci.builder(
name = "Win Builder (reclient shadow)",
description_html = "This builder mirrors Win Builder in order to debug an reclient dependency scanner issue (crbug.com/352206623).",
builder_spec = builder_config.copy_from(
"ci/Win Builder",
lambda spec: structs.evolve(
spec,
gclient_config = structs.extend(
spec.gclient_config,
apply_configs = ["reclient_experimental"],
),
),
),
gn_args = "ci/Win Builder",
builderless = False,
cores = 32,
os = os.WINDOWS_ANY,
tree_closing = False,
console_view_entry = consoles.console_view_entry(
category = "release|builder",
short_name = "32",
),
contact_team_email = "git-build-tools@google.com",
siso_enabled = True,
siso_project = siso.project.DEFAULT_TRUSTED,
siso_remote_jobs = siso.remote_jobs.DEFAULT,
)

@ -76,6 +76,11 @@
"chromiumos_preflight"
]
},
"Win Builder (reclient shadow)": {
"additional_compile_targets": [
"all"
]
},
"ios-simulator reclient staging": {
"additional_compile_targets": [
"all"

@ -5471,6 +5471,11 @@
'chromiumos_preflight',
],
},
'Win Builder (reclient shadow)': {
'additional_compile_targets': [
'all'
],
},
'ios-simulator reclient staging': {
'additional_compile_targets': [
'all',