chromium/src
0
Fork 0
Code Activity

Revert "gardener: disable SupervisedUserIframeFilterTest.BlockedMainFrameFromBlockListIsStrippedInRemoteApproval"

Browse Source 
This reverts commit 743a4e52a7.

Reason for revert: Restoring tests (they appear to no longer flake)
Bug: 356676072, 356793540
Cq-Include-Trybots: luci.chromium.try:linux-chromeos-dbg

Original change's description:
> gardener: disable SupervisedUserIframeFilterTest.BlockedMainFrameFromBlockListIsStrippedInRemoteApproval
>
> This test is flaky on ChromeOS since 2024-07-30. See example build:
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/37120
>
> Bug: 356676072
> Change-Id: I54b5a9500b6fdfe03070475a1598121499a4a6a0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783842
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1342283}

Bug: 356676072
Change-Id: If602ca065567b8b17d9868ba91f766ffe9879df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5967233
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tomek Jurkiewicz <tju@google.com>
Cr-Commit-Position: refs/heads/main@{#1374770}
This commit is contained in:
Tomek Jurkiewicz
2024-10-28 18:56:26 +00:00
committed by Chromium LUCI CQ
parent c4c5dc93a6
commit 95c0d87b14
1 changed files with 1 additions and 9 deletions

10
chrome/browser/supervised_user/supervised_user_navigation_throttle_browsertest.cc

@ -853,17 +853,9 @@ IN_PROC_BROWSER_TEST_P(SupervisedUserIframeFilterTest,
// Tests that the trivial www-subdomain stripping is applied on the url
// of the interstitial. Blocked urls without further conflicts will be
// unblocked by a remote approval.
// TODO(crbug.com/356676072): flaky on ChromeOS.
#if BUILDFLAG(IS_CHROMEOS)
#define MAYBE_BlockedMainFrameFromClassifyUrlForUnstripedHostIsStrippedInRemoteApproval \
DISABLED_BlockedMainFrameFromClassifyUrlForUnstripedHostIsStrippedInRemoteApproval
#else
#define MAYBE_BlockedMainFrameFromClassifyUrlForUnstripedHostIsStrippedInRemoteApproval \
BlockedMainFrameFromClassifyUrlForUnstripedHostIsStrippedInRemoteApproval
#endif
IN_PROC_BROWSER_TEST_P(
SupervisedUserIframeFilterTest,
MAYBE_BlockedMainFrameFromClassifyUrlForUnstripedHostIsStrippedInRemoteApproval) {
BlockedMainFrameFromClassifyUrlForUnstripedHostIsStrippedInRemoteApproval) {
// Classify url blocks the navigation to the target url.
// No matching blocklist entry exists for the host of the target url.
kids_management_api_mock().RestrictSubsequentClassifyUrl();