chromium/src
0
Fork 0
Code Activity

Revert "Re-enable Mojo Core tests on MSAN"

Browse Source 
This reverts commit 28de45f199.

Reason for revert: Breaks Linux and ChromeOS MSan tests.
BUG: 1154170

Original change's description:
> Re-enable Mojo Core tests on MSAN
>
> Fixed: 902135
> Change-Id: I9aeb13d6606ed2cf89185bd7380e621b1dc22caf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565656
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Auto-Submit: Ken Rockot <rockot@google.com>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#832010}

TBR=rockot@google.com,rsesek@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I0aa5917e91b753ef6764237cf45f4286c3ae4f79
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567211
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832252}
This commit is contained in:
Tim Schumann
2020-12-01 08:37:32 +00:00
committed by Chromium LUCI CQ
parent 53f1bcefea
commit 96031a95c9
1 changed files with 7 additions and 0 deletions

7
mojo/core/mojo_core_unittest.cc

@ -28,6 +28,11 @@ const char kMojoUseExplicitLibraryPath[] = "mojo-use-explicit-library-path";
namespace {
// TODO(https://crbug.com/902135): Re-enable this on MSAN. Currently hangs
// because of an apparent deadlock in MSAN's fork() in multithreaded
// environments.
#if !defined(MEMORY_SANITIZER)
uint64_t kTestPipeName = 0;
const char kTestMessage[] = "hai";
const char kTestReply[] = "bai";
@ -136,4 +141,6 @@ INSTANTIATE_TEST_SUITE_P(
InitializationMode::kLoadBeforeInit),
::testing::Values(LoadPathSpec::kImplicit, LoadPathSpec::kExplicit)));
#endif // !defined(MEMORY_SANITIZER)
} // namespace