chromium/src
0
Fork 0
Code Activity

[PDF Ink Signatures] Add regression test for stroke stroke undo stroke

Browse Source 
Add a test for drawing two strokes, undoing a stroke, and drawing a new
stroke.

This is a follow-up to https://crrev.com/c/6019206.

Fixed: 378724153
Change-Id: I0a621f92304fc695b5cf86f98b498203a07e7109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019341
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382632}
This commit is contained in:
Andy Phan
2024-11-13 22:42:02 +00:00
committed by Chromium LUCI CQ
parent a2370de376
commit 96083bcbe3
1 changed files with 57 additions and 0 deletions

57
pdf/pdf_ink_module_unittest.cc

@ -1834,6 +1834,63 @@ TEST_F(PdfInkModuleUndoRedoTest, UndoRedoEraseLoadedV2Shapes) {
PerformRedo();
}
// Regression test for crbug.com/378724153.
TEST_F(PdfInkModuleUndoRedoTest, StrokeStrokeUndoStroke) {
InitializeSimpleSinglePageBasicLayout();
// Draw stroke 1.
RunStrokeCheckTest(/*annotation_mode_enabled=*/true);
// Draw stroke 2.
constexpr gfx::PointF kMouseDownPoint2 = gfx::PointF(11.0f, 15.0f);
constexpr gfx::PointF kMouseMovePoint2 = gfx::PointF(21.0f, 25.0f);
constexpr gfx::PointF kMouseUpPoint2 = gfx::PointF(31.0f, 17.0f);
ApplyStrokeWithMouseAtPoints(
kMouseDownPoint2, base::span_from_ref(kMouseMovePoint2), kMouseUpPoint2);
// Strokes 1 and 2 should be visible.
const auto kInitialStrokeMatchers = {
ElementsAre(kMouseDownPoint, kMouseMovePoint, kMouseUpPoint),
ElementsAre(kMouseDownPoint2, kMouseMovePoint2, kMouseUpPoint2)};
const auto kInitialStrokeMatchersSpan =
base::make_span(kInitialStrokeMatchers);
EXPECT_THAT(
StrokeInputPositions(),
ElementsAre(Pair(0, ElementsAreArray(kInitialStrokeMatchersSpan))));
EXPECT_THAT(
VisibleStrokeInputPositions(),
ElementsAre(Pair(0, ElementsAreArray(kInitialStrokeMatchersSpan))));
// Undo makes 1 stroke visible.
PerformUndo();
EXPECT_THAT(
StrokeInputPositions(),
ElementsAre(Pair(0, ElementsAreArray(kInitialStrokeMatchersSpan))));
EXPECT_THAT(VisibleStrokeInputPositions(),
ElementsAre(Pair(
0, ElementsAreArray(kInitialStrokeMatchersSpan.first(1u)))));
// Stroke IDs are 0-indexed, so stroke 2 has a stroke ID of 1.
EXPECT_CALL(client(), DiscardStroke(/*page_index=*/0, InkStrokeId(1)));
// Draw stroke 3. Stroke 2 was undone and should be discarded.
constexpr gfx::PointF kMouseDownPoint3 = gfx::PointF(12.0f, 15.0f);
constexpr gfx::PointF kMouseMovePoint3 = gfx::PointF(22.0f, 25.0f);
constexpr gfx::PointF kMouseUpPoint3 = gfx::PointF(32.0f, 17.0f);
ApplyStrokeWithMouseAtPoints(
kMouseDownPoint3, base::span_from_ref(kMouseMovePoint3), kMouseUpPoint3);
// Strokes 1 and 3 should be visible.
const auto kNextStrokeMatchers = {
ElementsAre(kMouseDownPoint, kMouseMovePoint, kMouseUpPoint),
ElementsAre(kMouseDownPoint3, kMouseMovePoint3, kMouseUpPoint3)};
const auto kNextStrokeMatchersSpan = base::make_span(kNextStrokeMatchers);
EXPECT_THAT(StrokeInputPositions(),
ElementsAre(Pair(0, ElementsAreArray(kNextStrokeMatchersSpan))));
EXPECT_THAT(VisibleStrokeInputPositions(),
ElementsAre(Pair(0, ElementsAreArray(kNextStrokeMatchersSpan))));
}
using PdfInkModuleGetVisibleStrokesTest = PdfInkModuleStrokeTest;
TEST_F(PdfInkModuleGetVisibleStrokesTest, NoPageStrokes) {