Document that Merge-Approved should be removed.

After a change has been merged a bot will generally add the
merge-merged-## label. However, the Merge-Approved-## label must be
manually removed at this point to indicate that there are no further
changes planned for this approval. Add this step to the documentation to
clarify that the one doing the merge should remove the Merge-Approved-##
label.

Change-Id: Id2fcc79ce3d5e2456658c89d19924e6a39bc6666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857564
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1039824}

This commit is contained in:

Ben Wagner

2022-08-26 16:53:09 +00:00

committed by

Chromium LUCI CQ

parent a41681338d

commit 96babd4c88

1 changed files with 5 additions and 0 deletions

									
										5

docs/process/merge_request.md
									
				@ -159,6 +159,11 @@ ASAP so that it can be included in the next release built from the branch; if

				you don't merge your cherry-pick soon after approval, it will eventually be

				rejected for merge.

				Once the cherry-pick has landed a bot will apply the *merge-merged-##* label if

				the commit references the issue. If for some reason the commit did not

				reference the issue, add the *Merge-Merged-##* label to the issue. After the

				merge is completed the *Merge-Approved-##* label should be manually removed.

				### Using Gerrit UI

				Select the "..." button in the Gerrit UI, then choose "Cherry Pick". When

Document that Merge-Approved should be removed.

5 docs/process/merge_request.md

5

docs/process/merge_request.md