0

Remove Origin trial requirement for PA Bidding and Auction feaure

This feature is still disabled by default, but is no longer behind
an additional Origin trial flag. This change is to allow us to more
easily launch this feature in M130.

Change-Id: I3888150a6fdff6867ed3e17652027b3bf4c9104e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5853906
Commit-Queue: Russ Hamilton <behamilton@google.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1356136}
This commit is contained in:
Russ Hamilton
2024-09-16 21:14:33 +00:00
committed by Chromium LUCI CQ
parent 1d4a759327
commit 9776da0599
14 changed files with 33 additions and 32 deletions

@ -10987,7 +10987,6 @@ class AdAuctionServiceImplBAndATest : public AdAuctionServiceImplTest {
feature_list_.InitWithFeaturesAndParameters(
{{blink::features::kFledgeBiddingAndAuctionServer,
{{"FledgeBiddingAndAuctionKeyURL", kKeyUrl.spec()}}},
{blink::features::kFledgeBiddingAndAuctionServerAPI, {}},
{blink::features::kPrivateAggregationApi,
{{"enabled_in_fledge", "true"}}}},
{});

@ -20889,8 +20889,7 @@ class InterestGroupBiddingAndAuctionServerBrowserTest
InterestGroupBiddingAndAuctionServerBrowserTest() {
feature_list_.InitWithFeaturesAndParameters(
{{blink::features::kFledgeBiddingAndAuctionServer,
{{"FledgeBiddingAndAuctionKeyURL", kKeyUrl.spec()}}},
{blink::features::kFledgeBiddingAndAuctionServerAPI, {}}},
{{"FledgeBiddingAndAuctionKeyURL", kKeyUrl.spec()}}}},
{});
}

@ -381,6 +381,8 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
kSetOnlyIfOverridden},
{"Fledge", raw_ref(features::kPrivacySandboxAdsAPIsM1Override),
kSetOnlyIfOverridden},
{"FledgeBiddingAndAuctionServerAPI",
raw_ref(blink::features::kFledgeBiddingAndAuctionServer), kDefault},
{"FontationsFontBackend",
raw_ref(blink::features::kFontationsFontBackend)},
{"FontSrcLocalMatching", raw_ref(features::kFontSrcLocalMatching)},

@ -1980,6 +1980,7 @@
name: "FledgeBiddingAndAuctionServerAPI",
origin_trial_feature_name: "FledgeBiddingAndAuctionServer",
origin_trial_allows_third_party: true,
base_feature: "none",
},
{
name: "FledgeCustomMaxAuctionAdComponents",

@ -1561,7 +1561,7 @@
"external/wpt/fledge/tentative/server-response.https.window.js"
],
"args": [
"--enable-features=FledgeBiddingAndAuctionServerAPI,FledgeBiddingAndAuctionServer:FledgeBiddingAndAuctionKeyConfig/{\"https%3A%2F%2Fpublickeyservice.gcp.privacysandboxservices.com%22%3A%22https%3A%2F%2Fweb-platform.test%3A8444%2Ffledge%2Ftentative%2Fresources%2Fba-public-keys\"}"
"--enable-features=FledgeBiddingAndAuctionServer:FledgeBiddingAndAuctionKeyConfig/{\"https%3A%2F%2Fpublickeyservice.gcp.privacysandboxservices.com%22%3A%22https%3A%2F%2Fweb-platform.test%3A8444%2Ffledge%2Ftentative%2Fresources%2Fba-public-keys\"}"
],
"expires": "Jan 14, 2025"
},

@ -1,11 +1,7 @@
This is a testharness.js-based test.
[FAIL] getInterestGroupAdAuctionData() with no interest groups returns a zero length result.
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
[FAIL] getInterestGroupAdAuctionData() config checks
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
[FAIL] getInterestGroupAdAuctionData() with one interest group returns a valid result.
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() with one interest group with two ads w/renderIds.
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
Harness: the test ran to completion.

@ -1,7 +1,7 @@
This is a testharness.js-based test.
[FAIL] getInterestGroupAdAuctionData() with multiple buyers
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() uses perBuyerConfig to select buyers
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
Harness: the test ran to completion.

@ -1,11 +1,11 @@
This is a testharness.js-based test.
[FAIL] getInterestGroupAdAuctionData() with one interest group with two ads w/renderIds and omit-ads.
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() with one interest group with two ads w/renderIds and include-full-ads.
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() all IG data fields, with include-full-ads
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() all IG data fields, w/o include-full-ads
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
Harness: the test ran to completion.

@ -1,11 +1,11 @@
This is a testharness.js-based test.
[FAIL] getInterestGroupAdAuctionData() all IG data fields, with omit-user-bidding-signals
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() browserSignals
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() browserSignals with include-full-ads
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] getInterestGroupAdAuctionData() with multiple interest groups
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
Harness: the test ran to completion.

@ -255,7 +255,10 @@ BA.decodeInterestGroupData = async function(igData) {
assert_equals(header.version, 0);
// Test config uses keyId = 0x12 only
assert_equals(header.keyId, 0x12);
// If the feature is not set up properly we may get a different, non-test key.
// We can't use assert_equals because it includes the (random) non-test key
// in the error message if testing support for this feature is not present.
assert_true(header.keyId === 0x12, "valid key Id");
// Current cipher config.
assert_equals(header.kemId, hpke.KemId.DhkemX25519HkdfSha256);

@ -1,11 +1,11 @@
This is a testharness.js-based test.
[FAIL] Basic B&A auction
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Basic B&A auction with reporting URLs
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Hybrid B&A auction
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Hybrid B&A auction with reporting URLs
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
Harness: the test ran to completion.

@ -1,11 +1,11 @@
This is a testharness.js-based test.
[FAIL] Basic B&A auction - fault inject at CBOR
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Basic B&A auction - fault inject at gzip
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Basic B&A auction - fault inject at framing
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Basic B&A auction - fault inject at encryption
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
Harness: the test ran to completion.

@ -1,9 +1,9 @@
This is a testharness.js-based test.
[FAIL] Basic B&A auction - Wrong authorization
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Basic B&A auction - Wrong seller
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
[FAIL] Basic B&A auction - Wrong request Id
promise_test: Unhandled rejection with value: object "TypeError: navigator.getInterestGroupAdAuctionData is not a function"
assert_true: valid key Id expected true got false
Harness: the test ran to completion.

@ -6813,6 +6813,7 @@ interface Navigator
method getBattery
method getGamepads
method getInstalledRelatedApps
method getInterestGroupAdAuctionData
method getUserMedia
method install
method javaEnabled