chromium/src
0
Fork 0
Code Activity

Remove chrome_public_common_apk_or_module_tmpl

Browse Source 
Template was refactored and is no longer used.

Bug: 1427610
Change-Id: I6701fd89d5cb216e0c22936e28f9d59b909c0c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5159327
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1241961}
This commit is contained in:
Andrew Grieve
2024-01-02 16:41:51 +00:00
committed by Chromium LUCI CQ
parent 60698bf687
commit 982fe8a2db
2 changed files with 5 additions and 17 deletions

6
chrome/android/chrome_public_apk_tmpl.gni

@ -768,9 +768,3 @@ template("chrome_public_test_apk_tmpl") {
forward_variables_from(invoker, "*", TESTONLY_AND_VISIBILITY)
}
}
template("chrome_public_common_apk_or_module_tmpl") {
chrome_common_apk_or_module_tmpl(target_name) {
forward_variables_from(invoker, "*")
}
}

16
docs/android_dynamic_feature_modules.md

@ -957,19 +957,13 @@ metrics:
### chrome_public_apk and Integration Tests
To make the Foo feature available in the non-bundle `chrome_public_apk`
target, add the `java` target to the `chrome_public_common_apk_or_module_tmpl`
in `//chrome/android/chrome_public_apk_tmpl.gni` like so:
target, add the `java` target to the template in
`//chrome/android/chrome_public_apk_tmpl.gni` like so:
```gn
template("chrome_public_common_apk_or_module_tmpl") {
...
target(_target_type, target_name) {
...
if (_target_type != "android_app_bundle_module") {
deps += [
"//chrome/browser/foo/internal:java",
]
}
# Add to where "chrome_all_java" is added:
if (!_is_bundle) {
deps += [ "//chrome/browser/foo/internal:java" ]
}
}
```