Clarify that when adding a third_party dependency the size increase should be from official builds.

Change-Id: I791ecbaa3541dfbff9ae636d9737e2e1cbd175ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360426
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798985}

This commit is contained in:

John Abd-El-Malek

2020-08-18 04:49:24 +00:00

committed by

Commit Bot

parent 4f0531b460

commit 988e2c0f74

1 changed files with 3 additions and 1 deletions

									
										4

docs/adding_to_third_party.md
									
				@ -24,7 +24,9 @@ To make sure the inclusion of a new third_party project makes sense for the

				Chromium project, you should first obtain Chrome Eng Review approval.

				Googlers should see go/chrome-eng-review and review existing topics in

				g/chrome-eng-review. Please include information about the additional checkout

				size, build times, and binary sizes. Please also make sure that the motivation

				size, build times, and binary size increase of

				[official](https://www.chromium.org/developers/gn-build-configuration) builds

				on Android and one desktop platform. Please also make sure that the motivation

				for your project is clear, e.g., a design doc has been circulated.

				## Get the code

Clarify that when adding a third_party dependency the size increase should be from official builds.

4 docs/adding_to_third_party.md

4

docs/adding_to_third_party.md