chromium/src
0
Fork 0
Code Activity

[fuchsia] Disable CacheStorageManagerTest.GetAllOriginsUsageWithOldIndex

Browse Source 
The test is still flaky but the extra bot output has allowed to find a
way to reproduce the failure locally.

Bug: 760687
Change-Id: I8ee78da2a174937bd6b668f94efb48a8b87290b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611205
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659570}
This commit is contained in:
Fabrice de Gans-Riberi
2019-05-14 17:52:15 +00:00
committed by Commit Bot
parent 36be26f31a
commit 9a9f4771de
1 changed files with 8 additions and 10 deletions

18
content/browser/cache_storage/cache_storage_manager_unittest.cc

@ -163,14 +163,8 @@ bool IsIndexFileCurrent(const base::FilePath& cache_dir) {
file_path = enumerator.Next()) {
if (!GetFileInfo(file_path, &info))
return false;
if (index_last_modified < info.last_modified) {
#if defined(OS_FUCHSIA)
// TODO(crbug.com/760687): Extra logging for bot debugging.
LOG(ERROR) << "index_last_modified: " << index_last_modified
<< " info.last_modified: " << info.last_modified;
#endif // OS_FUCHSIA
if (index_last_modified < info.last_modified)
return false;
}
}
return true;
@ -1576,9 +1570,13 @@ TEST_P(CacheStorageManagerTestP, GetAllOriginsUsageDifferentOwners) {
}
}
// TODO(crbug.com/760687): Flaky on Fuchsia. Temporarily enabled with extra
// logging to help debug.
TEST_F(CacheStorageManagerTest, GetAllOriginsUsageWithOldIndex) {
// TODO(crbug.com/760687): Flaky on Fuchsia.
#if defined(OS_FUCHSIA)
#define MAYBE_GetAllOriginsUsageWithOldIndex DISABLED_GetAllOriginsUsageWithOldIndex
#else
#define MAYBE_GetAllOriginsUsageWithOldIndex GetAllOriginsUsageWithOldIndex
#endif
TEST_F(CacheStorageManagerTest, MAYBE_GetAllOriginsUsageWithOldIndex) {
// Write a single value (V1) to the cache.
const GURL kFooURL = origin1_.GetURL().Resolve("foo");
const std::string kCacheName = "foo";