chromium/src
0
Fork 0
Code Activity

Remove WebXRReflectionEstimation flag

Browse Source 
WebXRReflectionEstimation is part of the WebXRLightEstimation API;
however, it was less stable than the rest of the API. The flag was split
out to enable shipping the rest of the Light Estimation API separately.
However, there were delays in shipping the rest of the Light Estimation
API, and the reflection code paths have now stabalized. This change
remvoes and replaces the reflection-only flag with the general lighting
estimation flag.

Bug: 1070819
Change-Id: Ica8ddc47a0eff9cc85876b5a4818650ea9159edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518449
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824470}
This commit is contained in:
Alexander Cooper
2020-11-05 17:31:18 +00:00
committed by Commit Bot
parent 6cae3c8750
commit 9ce875fa69
5 changed files with 3 additions and 14 deletions
content/child
runtime_features.cc
third_party/blink
public
platform
web_runtime_features.h
renderer
modules
xr
xr_webgl_binding.idl
platform
exported
web_runtime_features.cc
runtime_enabled_features.json5

1
content/child/runtime_features.cc

@ -211,7 +211,6 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
{wf::EnableWebXRImageTracking, features::kWebXrIncubations},
{wf::EnableWebXRLightEstimation, features::kWebXrIncubations},
{wf::EnableWebXRPlaneDetection, features::kWebXrIncubations},
{wf::EnableWebXRReflectionEstimation, features::kWebXrIncubations},
{wf::EnableWebXRViewportScale, features::kWebXrIncubations},
{wf::EnableUserActivationSameOriginVisibility,
features::kUserActivationSameOriginVisibility},

1
third_party/blink/public/platform/web_runtime_features.h vendored

@ -193,7 +193,6 @@ class WebRuntimeFeatures {
BLINK_PLATFORM_EXPORT static void EnableWebXRImageTracking(bool);
BLINK_PLATFORM_EXPORT static void EnableWebXRLightEstimation(bool);
BLINK_PLATFORM_EXPORT static void EnableWebXRPlaneDetection(bool);
BLINK_PLATFORM_EXPORT static void EnableWebXRReflectionEstimation(bool);
BLINK_PLATFORM_EXPORT static void EnableWebXRViewportScale(bool);
BLINK_PLATFORM_EXPORT static void EnableXSLT(bool);
BLINK_PLATFORM_EXPORT static void ForceOverlayFullscreenVideo(bool);

6
third_party/blink/renderer/modules/xr/xr_webgl_binding.idl vendored

@ -6,13 +6,13 @@
[
SecureContext,
Exposed=Window,
RuntimeEnabled=WebXRReflectionEstimation
RuntimeEnabled=WebXRLightEstimation
] interface XRWebGLBinding {
[RaisesException] constructor(XRSession session, XRWebGLRenderingContext context);
// Lighting Estimation API
[RuntimeEnabled=WebXRReflectionEstimation, RaisesException]
[RuntimeEnabled=WebXRLightEstimation, RaisesException]
WebGLTexture? getReflectionCubeMap(XRLightProbe lightProbe);
[RuntimeEnabled=WebXRCameraAccess] WebGLTexture? getCameraImage(XRFrame frame, XRView view);
};
};

4
third_party/blink/renderer/platform/exported/web_runtime_features.cc vendored

@ -481,10 +481,6 @@ void WebRuntimeFeatures::EnableWebXRPlaneDetection(bool enable) {
RuntimeEnabledFeatures::SetWebXRPlaneDetectionEnabled(enable);
}
void WebRuntimeFeatures::EnableWebXRReflectionEstimation(bool enable) {
RuntimeEnabledFeatures::SetWebXRReflectionEstimationEnabled(enable);
}
void WebRuntimeFeatures::EnableWebXRViewportScale(bool enable) {
RuntimeEnabledFeatures::SetWebXRViewportScaleEnabled(enable);
}

5
third_party/blink/renderer/platform/runtime_enabled_features.json5 vendored

@ -2216,11 +2216,6 @@
depends_on: ["WebXRARModule"],
status: "experimental",
},
{
name: "WebXRReflectionEstimation",
depends_on: ["WebXRARModule", "WebXRLightEstimation"],
status: "experimental",
},
{
name: "WebXRViewportScale",
depends_on: ["WebXRARModule"],