chromium/src
0
Fork 0
Code Activity

gin: Remove kV8MemoryReducerSingleGC feature

Browse Source 
Now that finch experiment is gone, we can also remove the
feature in gin.

Bug: v8:13842
Change-Id: I57fcaabf3eb35ff071c38c8c0d459c889951f9b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4742461
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1178856}
This commit is contained in:
Dominik Inführ
2023-08-03 07:30:51 +00:00
committed by Chromium LUCI CQ
parent 809c6c9bbf
commit 9d8fabd9a0
4 changed files with 0 additions and 32 deletions

5
gin/gin_features.cc

@ -134,11 +134,6 @@ BASE_FEATURE(kV8TurboFastApiCalls,
// Enables faster DOM methods for megamorphic ICs
BASE_FEATURE(kV8MegaDomIC, "V8MegaDomIC", base::FEATURE_DISABLED_BY_DEFAULT);
// Schedules a single MemoryReducer GC.
BASE_FEATURE(kV8MemoryReducerSingleGC,
"V8MemoryReducerSingleGC",
base::FEATURE_DISABLED_BY_DEFAULT);
// Avoids background threads for GC if isolate is in background.
BASE_FEATURE(kV8SingleThreadedGCInBackground,
"V8SingleThreadedGCInBackground",

1
gin/gin_features.h

@ -36,7 +36,6 @@ GIN_EXPORT BASE_DECLARE_FEATURE(kV8MidtierRegallocFallback);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8MinorMC);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8MinorMS);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8MegaDomIC);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8MemoryReducerSingleGC);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8NoReclaimUnmodifiedWrappers);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8OffThreadFinalization);
GIN_EXPORT BASE_DECLARE_FEATURE(kV8OptimizeJavascript);

3
gin/v8_initializer.cc

@ -310,9 +310,6 @@ void SetFlags(IsolateHolder::ScriptMode mode,
"--no-write-protect-code-memory");
SetV8FlagsIfOverridden(features::kV8SlowHistograms, "--slow-histograms",
"--no-slow-histograms");
SetV8FlagsIfOverridden(features::kV8MemoryReducerSingleGC,
"--memory-reducer-single-gc",
"--no-memory-reducer-single-gc");
SetV8FlagsIfOverridden(features::kV8SingleThreadedGCInBackground,
"--single-threaded-gc-in-background",
"--no-single-threaded-gc-in-background");

23
testing/variations/fieldtrial_testing_config.json

@ -15425,29 +15425,6 @@
]
}
],
"V8MemoryReducerSingleGC": [
{
"platforms": [
"android",
"android_weblayer",
"android_webview",
"chromeos",
"chromeos_lacros",
"fuchsia",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"V8MemoryReducerSingleGC"
]
}
]
}
],
"V8MidtierRegallocFallback": [
{
"platforms": [