chromium/src
0
Fork 0
Code Activity

[pdf] Migrate DocumentLoadProgress() tests

Browse Source 
Migrates tests exercising PdfViewPluginBase's DocumentLoadProgress()
method.

Also cleans up some dead code in pdf_view_plugin_base_unittest.cc.

Bug: 1323307
Change-Id: I67896678871983f4fee0220c99b148f728281b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697241
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: K. Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1012613}
This commit is contained in:
K. Moon
2022-06-09 18:09:10 +00:00
committed by Chromium LUCI CQ
parent 37db1e14d1
commit 9dc6319127
2 changed files with 29 additions and 46 deletions

49
pdf/pdf_view_plugin_base_unittest.cc

@ -10,7 +10,6 @@
#include <vector>
#include "base/memory/weak_ptr.h"
#include "base/test/icu_test_util.h"
#include "base/test/values_test_util.h"
#include "base/time/time.h"
#include "base/values.h"
@ -38,7 +37,6 @@ namespace chrome_pdf {
namespace {
using ::testing::ByMove;
using ::testing::ElementsAre;
using ::testing::IsEmpty;
using ::testing::NiceMock;
@ -162,12 +160,7 @@ class FakePdfViewPluginBase : public PdfViewPluginBase {
} // namespace
class PdfViewPluginBaseTest : public testing::Test {
protected:
NiceMock<FakePdfViewPluginBase> fake_plugin_;
};
class PdfViewPluginBaseWithEngineTest : public PdfViewPluginBaseTest {
class PdfViewPluginBaseWithEngineTest : public testing::Test {
public:
void SetUp() override {
auto engine = std::make_unique<NiceMock<TestPDFiumEngine>>(&fake_plugin_);
@ -191,46 +184,10 @@ class PdfViewPluginBaseWithEngineTest : public PdfViewPluginBaseTest {
})");
fake_plugin_.HandleMessage(message.GetDict());
}
NiceMock<FakePdfViewPluginBase> fake_plugin_;
};
class PdfViewPluginBaseWithScopedLocaleTest
: public PdfViewPluginBaseWithEngineTest {
protected:
base::test::ScopedRestoreICUDefaultLocale scoped_locale_{"en_US"};
base::test::ScopedRestoreDefaultTimezone la_time_{"America/Los_Angeles"};
};
TEST_F(PdfViewPluginBaseTest, DocumentLoadProgress) {
fake_plugin_.DocumentLoadProgress(10, 200);
EXPECT_THAT(fake_plugin_.sent_messages(), ElementsAre(base::test::IsJson(R"({
"type": "loadProgress",
"progress": 5.0,
})")));
}
TEST_F(PdfViewPluginBaseTest, DocumentLoadProgressIgnoreSmall) {
fake_plugin_.DocumentLoadProgress(2, 100);
fake_plugin_.clear_sent_messages();
fake_plugin_.DocumentLoadProgress(3, 100);
EXPECT_THAT(fake_plugin_.sent_messages(), IsEmpty());
}
TEST_F(PdfViewPluginBaseTest, DocumentLoadProgressMultipleSmall) {
fake_plugin_.DocumentLoadProgress(2, 100);
fake_plugin_.clear_sent_messages();
fake_plugin_.DocumentLoadProgress(3, 100);
fake_plugin_.DocumentLoadProgress(4, 100);
EXPECT_THAT(fake_plugin_.sent_messages(), ElementsAre(base::test::IsJson(R"({
"type": "loadProgress",
"progress": 4.0,
})")));
}
TEST_F(PdfViewPluginBaseWithEngineTest, HandleInputEvent) {
auto* engine = static_cast<TestPDFiumEngine*>(fake_plugin_.engine());
EXPECT_CALL(*engine, HandleInputEvent)

26
pdf/pdf_view_web_plugin_unittest.cc

@ -781,6 +781,32 @@ TEST_F(PdfViewWebPluginFullFrameTest,
pdf_receiver_.FlushForTesting();
}
TEST_F(PdfViewWebPluginTest, DocumentLoadProgress) {
EXPECT_CALL(*client_ptr_, PostMessage(base::test::IsJson(R"({
"type": "loadProgress",
"progress": 5.0,
})")));
plugin_->DocumentLoadProgress(10, 200);
}
TEST_F(PdfViewWebPluginTest, DocumentLoadProgressIgnoreSmall) {
plugin_->DocumentLoadProgress(2, 100);
EXPECT_CALL(*client_ptr_, PostMessage).Times(0);
plugin_->DocumentLoadProgress(3, 100);
}
TEST_F(PdfViewWebPluginTest, DocumentLoadProgressMultipleSmall) {
plugin_->DocumentLoadProgress(2, 100);
EXPECT_CALL(*client_ptr_, PostMessage(base::test::IsJson(R"({
"type": "loadProgress",
"progress": 4.0,
})")));
plugin_->DocumentLoadProgress(3, 100);
plugin_->DocumentLoadProgress(4, 100);
}
TEST_F(PdfViewWebPluginTest, EnableAccessibilityBeforeDocumentLoadComplete) {
EXPECT_CALL(*accessibility_data_handler_ptr_, SetAccessibilityDocInfo)
.Times(0);