chromium/src
0
Fork 0
Code Activity

Create notification_content_detection subdir under chrome/browser/

Browse Source 
With more chromium changes coming related to notification content
detection and warnings on suspicious notifications, there should be a
separate subdirectory under chrome/browser/safe_browsing/. This will
allow us to create more files as needed in a more organized way.

Change-Id: I5f38282d8d13a03b78d35f0a7e1d6591d2b61e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6390916
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sarah Krakowiak <skrakowi@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438083}
This commit is contained in:
Sarah Krakowiak Criel
2025-03-26 06:58:25 -07:00
committed by Chromium LUCI CQ
parent 76ef50b460
commit 9e2d70b5c7
16 changed files with 26 additions and 26 deletions

3
WATCHLISTS

@ -1711,7 +1711,8 @@
'third_party/blink/renderer/modules/nfc/'
},
'notification_content_detection': {
'filepath': 'components/safe_browsing/content/browser/notification_content_detection/'
'filepath': 'components/safe_browsing/content/browser/notification_content_detection/|'\
'chrome/browser/safe_browsing/notification_content_detection/'
},
'notifications': {
'filepath': 'chrome/browser/extensions/api/notifications/|'\

4
chrome/browser/BUILD.gn

@ -8906,8 +8906,8 @@ static_library("test_support") {
"predictors/loading_test_util.h",
"resource_coordinator/tab_load_tracker_test_support.cc",
"resource_coordinator/tab_load_tracker_test_support.h",
"safe_browsing/mock_notification_content_detection_service.cc",
"safe_browsing/mock_notification_content_detection_service.h",
"safe_browsing/notification_content_detection/mock_notification_content_detection_service.cc",
"safe_browsing/notification_content_detection/mock_notification_content_detection_service.h",
"share/fake_share_history.cc",
"share/fake_share_history.h",
"signin/chrome_signin_client_test_util.cc",

4
chrome/browser/notifications/persistent_notification_handler_unittest.cc

@ -20,8 +20,8 @@
#include "chrome/browser/notifications/notification_permission_context.h"
#include "chrome/browser/notifications/platform_notification_service_factory.h"
#include "chrome/browser/notifications/platform_notification_service_impl.h"
#include "chrome/browser/safe_browsing/mock_notification_content_detection_service.h"
#include "chrome/browser/safe_browsing/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection/mock_notification_content_detection_service.h"
#include "chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h"
#include "chrome/test/base/testing_profile.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/safe_browsing/content/browser/notification_content_detection/notification_content_detection_constants.h"

2
chrome/browser/notifications/platform_notification_service_impl.cc

@ -79,7 +79,7 @@
#endif // IS_CHROMEOS
#if BUILDFLAG(SAFE_BROWSING_AVAILABLE)
#include "chrome/browser/safe_browsing/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h"
#include "components/safe_browsing/content/browser/notification_content_detection/notification_content_detection_service.h"
#endif

4
chrome/browser/notifications/platform_notification_service_unittest.cc

@ -29,8 +29,8 @@
#include "chrome/browser/notifications/notification_display_service_tester.h"
#include "chrome/browser/notifications/platform_notification_service_factory.h"
#include "chrome/browser/notifications/platform_notification_service_impl.h"
#include "chrome/browser/safe_browsing/mock_notification_content_detection_service.h"
#include "chrome/browser/safe_browsing/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection/mock_notification_content_detection_service.h"
#include "chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h"
#include "chrome/browser/ui/safety_hub/safety_hub_constants.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/testing_profile.h"

2
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

@ -548,7 +548,7 @@
#include "chrome/browser/safe_browsing/chrome_password_protection_service_factory.h"
#include "chrome/browser/safe_browsing/chrome_ping_manager_factory.h"
#include "chrome/browser/safe_browsing/client_side_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/safe_browsing_metrics_collector_factory.h"
#include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager_factory.h"
#include "chrome/browser/safe_browsing/tailored_security/tailored_security_service_factory.h"

4
chrome/browser/safe_browsing/BUILD.gn

@ -171,8 +171,8 @@ static_library("safe_browsing") {
"network_context_service.h",
"network_context_service_factory.cc",
"network_context_service_factory.h",
"notification_content_detection_service_factory.cc",
"notification_content_detection_service_factory.h",
"notification_content_detection/notification_content_detection_service_factory.cc",
"notification_content_detection/notification_content_detection_service_factory.h",
"phishy_interaction_tracker.cc",
"phishy_interaction_tracker.h",
"safe_browsing_navigation_observer_manager_factory.cc",

3
chrome/browser/safe_browsing/OWNERS

@ -10,6 +10,3 @@ per-file threat_details_unittest.cc=skrakowi@chromium.org
per-file BUILD.gn=anunoy@chromium.org
per-file *client_side_detection*=andysjlim@chromium.org
# Prefer skrakowi@ for reviews.
per-file *notification_content_detection*=file://components/safe_browsing/content/browser/notification_content_detection/OWNERS

2
chrome/browser/safe_browsing/notification_content_detection/OWNERS Normal file

@ -0,0 +1,2 @@
# Prefer skrakowi@ for reviews.
file://components/safe_browsing/content/browser/notification_content_detection/OWNERS

2
chrome/browser/safe_browsing/mock_notification_content_detection_service.cc → chrome/browser/safe_browsing/notification_content_detection/mock_notification_content_detection_service.cc

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/safe_browsing/mock_notification_content_detection_service.h"
#include "chrome/browser/safe_browsing/notification_content_detection/mock_notification_content_detection_service.h"
#include "base/memory/ptr_util.h"
#include "components/optimization_guide/core/test_optimization_guide_model_provider.h"

6
chrome/browser/safe_browsing/mock_notification_content_detection_service.h → chrome/browser/safe_browsing/notification_content_detection/mock_notification_content_detection_service.h

@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CHROME_BROWSER_SAFE_BROWSING_MOCK_NOTIFICATION_CONTENT_DETECTION_SERVICE_H_
#define CHROME_BROWSER_SAFE_BROWSING_MOCK_NOTIFICATION_CONTENT_DETECTION_SERVICE_H_
#ifndef CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_MOCK_NOTIFICATION_CONTENT_DETECTION_SERVICE_H_
#define CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_MOCK_NOTIFICATION_CONTENT_DETECTION_SERVICE_H_
#include "chrome/browser/profiles/profile.h"
#include "components/keyed_service/core/keyed_service.h"
@ -38,4 +38,4 @@ class MockNotificationContentDetectionService
} // namespace safe_browsing
#endif // CHROME_BROWSER_SAFE_BROWSING_MOCK_NOTIFICATION_CONTENT_DETECTION_SERVICE_H_
#endif // CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_MOCK_NOTIFICATION_CONTENT_DETECTION_SERVICE_H_

2
chrome/browser/safe_browsing/notification_content_detection_service_browsertest.cc → chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_browsertest.cc

@ -18,7 +18,7 @@
#include "chrome/browser/optimization_guide/browser_test_util.h"
#include "chrome/browser/optimization_guide/optimization_guide_keyed_service.h"
#include "chrome/browser/optimization_guide/optimization_guide_keyed_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/test_safe_browsing_service.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"

2
chrome/browser/safe_browsing/notification_content_detection_service_factory.cc → chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.cc

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/safe_browsing/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h"
#include "base/system/sys_info.h"
#include "base/task/sequenced_task_runner.h"

6
chrome/browser/safe_browsing/notification_content_detection_service_factory.h → chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h

@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_SERVICE_FACTORY_H_
#define CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_SERVICE_FACTORY_H_
#ifndef CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_NOTIFICATION_CONTENT_DETECTION_SERVICE_FACTORY_H_
#define CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_NOTIFICATION_CONTENT_DETECTION_SERVICE_FACTORY_H_
#include "base/no_destructor.h"
#include "chrome/browser/optimization_guide/optimization_guide_keyed_service.h"
@ -50,4 +50,4 @@ class NotificationContentDetectionServiceFactory
} // namespace safe_browsing
#endif // CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_SERVICE_FACTORY_H_
#endif // CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_CONTENT_DETECTION_NOTIFICATION_CONTENT_DETECTION_SERVICE_FACTORY_H_

2
chrome/browser/safe_browsing/notification_content_detection_service_factory_unittest.cc → chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory_unittest.cc

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/safe_browsing/notification_content_detection_service_factory.h"
#include "chrome/browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory.h"
#include "base/system/sys_info.h"
#include "build/build_config.h"

4
chrome/test/BUILD.gn

@ -5329,7 +5329,7 @@ if (!is_android) {
"../browser/safe_browsing/chrome_password_protection_service_browsertest.cc",
"../browser/safe_browsing/chrome_password_protection_service_sync_browsertest.cc",
"../browser/safe_browsing/client_side_detection_host_browsertest.cc",
"../browser/safe_browsing/notification_content_detection_service_browsertest.cc",
"../browser/safe_browsing/notification_content_detection/notification_content_detection_service_browsertest.cc",
"../browser/safe_browsing/ohttp_key_service_browsertest.cc",
"../browser/safe_browsing/safe_browsing_blocking_page_test.cc",
"../browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc",
@ -6168,7 +6168,7 @@ test("unit_tests") {
"../browser/resources_util_unittest.cc",
"../browser/safe_browsing/advanced_protection_status_manager_factory_unittest.cc",
"../browser/safe_browsing/advanced_protection_status_manager_unittest.cc",
"../browser/safe_browsing/notification_content_detection_service_factory_unittest.cc",
"../browser/safe_browsing/notification_content_detection/notification_content_detection_service_factory_unittest.cc",
"../browser/search_engines/template_url_fetcher_unittest.cc",
"../browser/search_engines/template_url_parser_unittest.cc",
"../browser/search_engines/template_url_service_sync_unittest.cc",