chromium/src
0
Fork 0
Code Activity

Unified: Add tooltip to the notification icon in status tray.

Browse Source 
This only adds "Notifications" tooltip, not describing the count or DnD
status. Also screenreaders will also read the icon as "Notifications"
instead of just "image".

Bug: 878338
Change-Id: Ic8da790d85c950f5c2565bc7c88eb1ebccfd41f3
Reviewed-on: https://chromium-review.googlesource.com/1237735
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593119}
This commit is contained in:
Tatsuhisa Yamaguchi
2018-09-21 08:33:36 +00:00
committed by Commit Bot
parent 2ba8941506
commit a047f6f208
1 changed files with 4 additions and 0 deletions

4
ash/system/unified/notification_counter_view.cc

@ -9,9 +9,11 @@
#include "ash/resources/vector_icons/vector_icons.h"
#include "ash/session/session_controller.h"
#include "ash/shell.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/system/tray/tray_constants.h"
#include "ash/system/tray/tray_utils.h"
#include "base/i18n/number_formatting.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/font_list.h"
#include "ui/gfx/image/canvas_image_source.h"
@ -89,6 +91,8 @@ class NumberIconImageSource : public gfx::CanvasImageSource {
NotificationCounterView::NotificationCounterView() : TrayItemView(nullptr) {
CreateImageView();
image_view()->SetTooltipText(
l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_NOTIFICATIONS_LABEL));
SetVisible(false);
Shell::Get()->session_controller()->AddObserver(this);
}