0

Make even more strings translatable.

Bug: b:345303965
Change-Id: I63ef1a378516b585f1f819214009e24014048df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5759515
Reviewed-by: Michelle Chen <michellegc@google.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1337679}
This commit is contained in:
Darren Shen
2024-08-06 05:43:34 +00:00
committed by Chromium LUCI CQ
parent 9db96b93c5
commit a0dd6b706e
6 changed files with 15 additions and 9 deletions

@ -7390,13 +7390,16 @@ New install
desc="This string appears in a selectable menu item in a menu. When selected, it navigates to another page showing the items in the user's clipboard.">
Clipboard
</message>
<message name="IDS_PICKER_UPPER_CASE_CATEGORY_LABEL" translateable="false" desc="Label of the Picker list item which can be clicked to transform the selected text to upper case.">
<message name="IDS_PICKER_UPPER_CASE_MENU_LABEL"
desc="This string appears as a selectable menu item in a submenu. The parent menu item is labeled 'Change capitalization'. When selected, this item converts the selected text to uppercase. The casing for this string is used to illustrate the effect of this menu item, so retain the casing for languages where this makes sense.">
UPPERCASE
</message>
<message name="IDS_PICKER_LOWER_CASE_CATEGORY_LABEL" translateable="false" desc="Label of the Picker list item which can be clicked to transform the selected text to lower case.">
<message name="IDS_PICKER_LOWER_CASE_MENU_LABEL"
desc="This string appears as a selectable menu item in a submenu. The parent menu item is labeled 'Change capitalization'. When selected, this item converts the selected text to lowercase. The casing for this string is used to illustrate the effect of this menu item, so retain the casing for languages where this makes sense.">
lowercase
</message>
<message name="IDS_PICKER_TITLE_CASE_CATEGORY_LABEL" translateable="false" desc="Label of the Picker list item which can be clicked to transform the selected text to title case.">
<message name="IDS_PICKER_TITLE_CASE_MENU_LABEL"
desc="This string appears as a selectable menu item in a submenu. The parent menu item is labeled 'Change capitalization'. When selected, this item converts the selected text to title case. The casing for this string is used to illustrate the effect of this menu item, so retain the casing for languages where this makes sense.">
Title Case
</message>
<message name="IDS_PICKER_LINKS_CATEGORY_SEARCH_FIELD_PLACEHOLDER_TEXT" translateable="false" desc="Placeholder text for the search field shown in the Picker UI when the browsing history category is selected.">

@ -0,0 +1 @@
777444ddfe9775be7e9c214718a0bdd34bee7470

@ -0,0 +1 @@
777444ddfe9775be7e9c214718a0bdd34bee7470

@ -0,0 +1 @@
777444ddfe9775be7e9c214718a0bdd34bee7470

@ -26,9 +26,9 @@ using CaseTransformType = PickerSearchResult::CaseTransformData::Type;
constexpr auto kTransformMessageIds =
std::to_array<std::pair<int, CaseTransformType>>({
{IDS_PICKER_UPPER_CASE_CATEGORY_LABEL, CaseTransformType::kUpperCase},
{IDS_PICKER_LOWER_CASE_CATEGORY_LABEL, CaseTransformType::kLowerCase},
{IDS_PICKER_TITLE_CASE_CATEGORY_LABEL, CaseTransformType::kTitleCase},
{IDS_PICKER_UPPER_CASE_MENU_LABEL, CaseTransformType::kUpperCase},
{IDS_PICKER_LOWER_CASE_MENU_LABEL, CaseTransformType::kLowerCase},
{IDS_PICKER_TITLE_CASE_MENU_LABEL, CaseTransformType::kTitleCase},
});
bool IsMatch(const string_matching::TokenizedString& query,

@ -107,11 +107,11 @@ std::u16string GetLabelForCaseTransformType(
PickerSearchResult::CaseTransformData::Type type) {
switch (type) {
case PickerSearchResult::CaseTransformData::Type::kUpperCase:
return l10n_util::GetStringUTF16(IDS_PICKER_UPPER_CASE_CATEGORY_LABEL);
return l10n_util::GetStringUTF16(IDS_PICKER_UPPER_CASE_MENU_LABEL);
case PickerSearchResult::CaseTransformData::Type::kLowerCase:
return l10n_util::GetStringUTF16(IDS_PICKER_LOWER_CASE_CATEGORY_LABEL);
return l10n_util::GetStringUTF16(IDS_PICKER_LOWER_CASE_MENU_LABEL);
case PickerSearchResult::CaseTransformData::Type::kTitleCase:
return l10n_util::GetStringUTF16(IDS_PICKER_TITLE_CASE_CATEGORY_LABEL);
return l10n_util::GetStringUTF16(IDS_PICKER_TITLE_CASE_MENU_LABEL);
}
}