chromium/src
0
Fork 0
Code Activity

Nit: Remove constructor for FrameSequenceMetrics::CustomReportData

Browse Source 
As we add more data to the struct, it becomes challenging and messy
to maintain the constructor.

Change-Id: I950435c0c251b38e8c125abb13516dc7a2755d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039507
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1387188}
This commit is contained in:
Zoraiz Naeem
2024-11-23 01:27:01 +00:00
committed by Chromium LUCI CQ
parent 48de4863fa
commit a1b139e0d7
2 changed files with 7 additions and 16 deletions

19
cc/metrics/frame_sequence_metrics.cc

@ -150,15 +150,6 @@ std::string GetThroughputV4HistogramName(FrameSequenceTrackerType type,
FrameSequenceMetrics::V3::V3() = default;
FrameSequenceMetrics::V3::~V3() = default;
FrameSequenceMetrics::CustomReportData::CustomReportData(
uint32_t frames_expected,
uint32_t frames_dropped,
uint32_t jank_count,
std::vector<Jank> janks)
: frames_expected_v3(frames_expected),
frames_dropped_v3(frames_dropped),
jank_count_v3(jank_count),
janks(std::move(janks)) {}
FrameSequenceMetrics::CustomReportData::CustomReportData() = default;
FrameSequenceMetrics::CustomReportData::CustomReportData(
@ -291,9 +282,13 @@ void FrameSequenceMetrics::ReportMetrics() {
if (type_ == FrameSequenceTrackerType::kCustom) {
DCHECK(!custom_reporter_.is_null());
std::move(custom_reporter_)
.Run(CustomReportData(v3_.frames_expected, v3_.frames_dropped,
v3_.jank_count, std::move(v3_.janks)));
CustomReportData custom_data;
custom_data.frames_dropped_v3 = v3_.frames_dropped;
custom_data.frames_expected_v3 = v3_.frames_expected;
custom_data.janks = std::move(v3_.janks);
std::move(custom_reporter_).Run(std::move(custom_data));
v3_.frames_expected = 0u;
v3_.frames_dropped = 0u;

4
cc/metrics/frame_sequence_metrics.h

@ -98,10 +98,6 @@ class CC_EXPORT FrameSequenceMetrics {
struct CC_EXPORT CustomReportData {
CustomReportData();
CustomReportData(uint32_t frames_expected,
uint32_t frames_dropped,
uint32_t jank_count,
std::vector<Jank> janks);
CustomReportData(const CustomReportData&);
CustomReportData& operator=(const CustomReportData&);