chromium/src
0
Fork 0
Code Activity

FLEDGE: Fix kFledgeCustomMaxAuctionAdComponentsValue param name

Browse Source 
As Russ pointed out, Finch has some global treatment of the name,
despite the param being ostensibly tied to the feature, so "value" is
way too generic.


Change-Id: I11c151f972ee307aa8843b4b21f15be6accd8ae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5213288
Reviewed-by: Russ Hamilton <behamilton@google.com>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249082}
This commit is contained in:
Maks Orlovich
2024-01-18 22:19:48 +00:00
committed by Chromium LUCI CQ
parent 10d35908dd
commit a41f3ca3e9
2 changed files with 3 additions and 2 deletions
content/services/auction_worklet
bidder_worklet_unittest.cc
third_party/blink/common
features.cc

3
content/services/auction_worklet/bidder_worklet_unittest.cc

@ -989,7 +989,8 @@ class BidderWorkletTest : public testing::Test {
class BidderWorkletCustomAdComponentLimitTest : public BidderWorkletTest {
public:
BidderWorkletCustomAdComponentLimitTest() {
const std::map<std::string, std::string> params = {{"value", "25"}};
const std::map<std::string, std::string> params = {
{"FledgeAdComponentLimit", "25"}};
feature_list_.InitAndEnableFeatureWithParameters(
blink::features::kFledgeCustomMaxAuctionAdComponents, params);
}

2
third_party/blink/common/features.cc vendored

@ -938,7 +938,7 @@ BASE_FEATURE(kFledgeCustomMaxAuctionAdComponents,
"FledgeCustomMaxAuctionAdComponents",
base::FEATURE_DISABLED_BY_DEFAULT);
const base::FeatureParam<int> kFledgeCustomMaxAuctionAdComponentsValue{
&kFledgeCustomMaxAuctionAdComponents, "value",
&kFledgeCustomMaxAuctionAdComponents, "FledgeAdComponentLimit",
kMaxAdAuctionAdComponentsDefault};
BASE_FEATURE(kForceDeferScriptIntervention,