chromium/src
0
Fork 0
Code Activity

update description string for version answer card

Browse Source 
Bug: b/263994165
Change-Id: Ie8c7ce8bb34564fb117ea0fdac2a19fd15ae37f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4736934
Commit-Queue: Lauren Commeignes <laurencom@chromium.org>
Reviewed-by: Dmitry Grebenyuk <dgrebenyuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1177621}
This commit is contained in:
Lauren Commeignes
2023-08-01 05:20:05 +00:00
committed by Chromium LUCI CQ
parent 5e9be53471
commit a5218c53fa
4 changed files with 6 additions and 2 deletions

3
ash/ash_strings.grd

@ -2015,6 +2015,9 @@ Style notes:
<message name="IDS_ASH_VERSION_IN_LAUNCHER_MESSAGE" desc="Message content for the title of the answer card with the current version in the launcher.">
Version <ph name="VERSION_NAME">$1<ex>109.0.5414.125</ex></ph> (<ph name="OFFICIAL_STATUS">$2<ex>Official Build</ex></ph>) <ph name="CHANNEL_NAME">$3<ex>Beta</ex></ph> <ph name="PROCESSOR_VARIATION">$4<ex>(64-bit)</ex></ph>
</message>
<message name="IDS_ASH_VERSION_IN_LAUNCHER_DESCRIPTION" desc="Message content for the description of the answer card with the current version in the launcher.">
Click to check for details
</message>
<message name="IDS_ASH_CPU_IN_LAUNCHER_TITLE" desc="Message content for the title of the answer card with the current CPU system information in the launcher.">
CPU usage snapshot: <ph name="CPU_USEAGE">$1<ex>89</ex></ph>%
</message>

1
ash/ash_strings_grd/IDS_ASH_VERSION_IN_LAUNCHER_DESCRIPTION.png.sha1 Normal file

@ -0,0 +1 @@
56bdd389ecf5db392578bf6093037089b12ed446

2
chrome/browser/ash/app_list/search/system_info/system_info_card_provider.cc

@ -396,7 +396,7 @@ void SystemInfoCardProvider::UpdateChromeOsVersion() {
chrome::GetChannelName(chrome::WithExtendedStable(true))),
processor_variation);
std::u16string description =
l10n_util::GetStringUTF16(IDS_SETTINGS_ABOUT_PAGE_CHECK_FOR_UPDATES);
l10n_util::GetStringUTF16(IDS_ASH_VERSION_IN_LAUNCHER_DESCRIPTION);
AnswerCardInfo answer_card_info(
ash::SystemInfoAnswerCardDisplayType::kTextCard);

2
chrome/browser/ash/app_list/search/system_info/system_info_card_provider_unittest.cc

@ -392,7 +392,7 @@ TEST_F(SystemInfoCardProviderTest, Version) {
ASSERT_EQ(results()[0]->details_text_vector().size(), 1u);
const auto& details = results()[0]->details_text_vector()[0];
ASSERT_EQ(details.GetType(), ash::SearchResultTextItemType::kString);
EXPECT_EQ(details.GetText(), u"Check for updates");
EXPECT_EQ(details.GetText(), u"Click to check for details");
EXPECT_TRUE(details.GetTextTags().empty());
}