chromium/src
0
Fork 0
Code Activity

[remoting host][remote open url] Local fallback if IPC connection can't be made

Browse Source 
The new design is to only open the data channel and IPC if the
client enables the feature. If the IPC isn't open then it means the
client hasn't enabled the feature hence the URL forwarder should
fallback to the previous default browser.

This CL changes the behavior of the URL forwarder to do so.

Bug: b:183135000
Change-Id: Id9f9e5f5c1182def0b959308877a97a921591fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2973396
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894392}
This commit is contained in:
Yuwei Huang
2021-06-21 20:45:20 +00:00
committed by Chromium LUCI CQ
parent 1341501762
commit a537fc1604
1 changed files with 3 additions and 3 deletions

6
remoting/host/remote_open_url_client.cc

@ -74,9 +74,9 @@ void RemoteOpenUrlClient::OpenUrl(const GURL& url, base::OnceClosure done) {
auto endpoint = mojo::NamedPlatformChannel::ConnectToServer(
GetRemoteOpenUrlIpcChannelName());
if (!endpoint.is_valid()) {
LOG(WARNING)
<< "Can't make IPC connection. The remote session may be disconnected.";
OnOpenUrlResponse(mojom::OpenUrlResult::FAILURE);
HOST_LOG << "Can't make IPC connection. URL forwarding is probably "
<< "disabled by the client.";
OnOpenUrlResponse(mojom::OpenUrlResult::LOCAL_FALLBACK);
return;
}