chromium/src
0
Fork 0
Code Activity

ash: Adjust strings for autozoom

Browse Source 
Adjust strings for autozoom based on UI feedback.

Bug: b:221980963
Test: manually
Change-Id: I56c0b5d8360592cb9cd040181924e52c9ee6dc08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3887982
Auto-Submit: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046390}
This commit is contained in:
Pi-Hsun Shih
2022-09-13 15:48:55 +00:00
committed by Chromium LUCI CQ
parent a882fed23c
commit a74abbefb5
8 changed files with 13 additions and 13 deletions

12
ash/ash_strings.grd

@ -316,19 +316,19 @@ This file contains the strings for ash.
VPN Settings
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_BUTTON_LABEL" desc="The shorter label used for the button in the status tray to toggle the Autozoom feature (which controls if camera auto zoom to faces) on or off. [CHAR_LIMIT=14]">
Autozoom
Camera framing
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_TOGGLE_TOOLTIP" desc="The tooltip text used for the button in the status tray to toggle the Autozoom feature (which controls if camera auto zoom to faces) on or off.">
Toggle autozoom. <ph name="STATE_TEXT">$1<ex>Autozoom is on.</ex></ph>
Toggle camera framing. <ph name="STATE_TEXT">$1<ex>Camera framing is on.</ex></ph>
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_TOGGLE_ACCESSIBILITY_DESCRIPTION" desc="The accessible description for the button in the status tray to toggle the Autozoom feature (which controls if camera auto zoom to faces) on or off.">
Adjust camera to put you in the center of the screen.
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_OFF_STATE_TOOLTIP" desc="The tooltip text indicating the Autozoom feature is off.">
Autozoom is off.
Camera framing is off.
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_ON_STATE_TOOLTIP" desc="The tooltip text indicating the Autozoom feature is on.">
Autozoom is on.
Camera framing is on.
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_OFF_STATE" desc="Button label for the Autozoom feature." meaning="Autozoom feature is off. [CHAR_LIMIT=14]">
Off
@ -337,10 +337,10 @@ This file contains the strings for ash.
On
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_TOAST_ON_STATE" desc="The text for the toast after autozoom centers the camera.">
Autozoom centered the camera
Camera frame automatically centered
</message>
<message name="IDS_ASH_STATUS_TRAY_AUTOZOOM_EDUCATIONAL_NUDGE_TEXT" desc="The text for the educational nudge for autozoom.">
Try autozoom so you'll be in the center of the screen. Turn it on in Quick Settings.
Try camera framing so you’ll be in the center of the screen on video calls. Turn it on in Quick Settings.
</message>
<message name="IDS_ASH_STATUS_TRAY_BRAILLE_DISPLAY_CONNECTED" desc="The message shown on a notification when a braille display is connected">
Braille display connected.

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOZOOM_BUTTON_LABEL.png.sha1

@ -1 +1 @@
ac29c0bd3746ffec67b061871d081bcca339c410
e6a2db01c0e9156c4fc031b7ec814582bbf811de

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOZOOM_EDUCATIONAL_NUDGE_TEXT.png.sha1

@ -1 +1 @@
2c18373a0c261b25e04cc78c329ec314cd2ddc0f
a7118283fe895703239c5894dae921cda35af31e

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOZOOM_OFF_STATE_TOOLTIP.png.sha1

@ -1 +1 @@
9117d29de2fe89fcc33a6dde6bb329a31bceb030
95fe745d3b9134185744f734c3adebe1da115eb2

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOZOOM_ON_STATE_TOOLTIP.png.sha1

@ -1 +1 @@
ba9e1b31bddc612d6df916ee80f2161e019f90a8
145b41ccacca2e699242a53d11a31d1359395b9c

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOZOOM_TOAST_ON_STATE.png.sha1

@ -1 +1 @@
11762a1304bd9c29bcc1759fbec3b19a25b8cbc8
2ea9d98898fed8e7e831cf5d0f50ea5ad9a6b4ef

2
ash/ash_strings_grd/IDS_ASH_STATUS_TRAY_AUTOZOOM_TOGGLE_TOOLTIP.png.sha1

@ -1 +1 @@
ba9e1b31bddc612d6df916ee80f2161e019f90a8
145b41ccacca2e699242a53d11a31d1359395b9c

2
ash/system/tray/tray_constants.h

@ -251,7 +251,7 @@ constexpr SkColor kIconColorInOobe = gfx::kGoogleGrey700;
// Constants used for the autozoom toast.
constexpr int kAutozoomToastMinWidth = 160;
constexpr int kAutozoomToastMaxWidth = 320;
constexpr int kAutozoomToastMaxWidth = 400;
constexpr int kAutozoomToastMainLabelFontSize = 14;
constexpr auto kAutozoomToastInsets = gfx::Insets::VH(10, 16);
constexpr int kAutozoomToastSpacing = 16;