0

Remove outdated AutofillAI extension APIs

They are no longer used.

Bug: 395038288
Change-Id: I3ae5a74cd2653dd28fcf67af370d2acfaf1bdef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6381721
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Reviewed-by: Justin Lulejian <jlulejian@chromium.org>
Reviewed-by: Tim <tjudkins@chromium.org>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1437633}
This commit is contained in:
Jan Keitel
2025-03-25 11:37:59 -07:00
committed by Chromium LUCI CQ
parent 891c5af741
commit a7d33e53f5
9 changed files with 4 additions and 126 deletions
chrome
browser
common
test
data
extensions
api_test
autofill_private
extensions/browser
tools
metrics
histograms
metadata
extensions
typescript

@ -969,33 +969,6 @@ AutofillPrivateSetAutofillSyncToggleEnabledFunction::Run() {
return RespondNow(NoArguments());
}
////////////////////////////////////////////////////////////////////////////////
// AutofillPrivateIsUserEligibleForAutofillImprovementsFunction
// TODO(crbug.com/393318914): Remove function.
ExtensionFunction::ResponseAction
AutofillPrivateIsUserEligibleForAutofillImprovementsFunction::Run() {
Profile* profile =
Profile::FromBrowserContext(GetSenderWebContents()->GetBrowserContext());
return RespondNow(WithArguments(autofill_ai::IsUserEligible(profile)));
}
////////////////////////////////////////////////////////////////////////////////
// AutofillPrivatePredictionImprovementsIphFeatureUsedFunction
ExtensionFunction::ResponseAction
AutofillPrivatePredictionImprovementsIphFeatureUsedFunction::Run() {
autofill::ContentAutofillClient* client =
autofill::ContentAutofillClient::FromWebContents(GetSenderWebContents());
if (!client) {
return RespondNow(Error(kErrorDataUnavailable));
}
client->NotifyIphFeatureUsed(
autofill::AutofillClient::IphFeature::kAutofillAi);
return RespondNow(NoArguments());
}
////////////////////////////////////////////////////////////////////////////////
// AutofillPrivateAddOrUpdateEntityInstanceFunction

@ -442,50 +442,6 @@ class AutofillPrivateSetAutofillSyncToggleEnabledFunction
ResponseAction Run() override;
};
class AutofillPrivateIsUserEligibleForAutofillImprovementsFunction
: public AutofillPrivateExtensionFunction {
public:
AutofillPrivateIsUserEligibleForAutofillImprovementsFunction() = default;
AutofillPrivateIsUserEligibleForAutofillImprovementsFunction(
const AutofillPrivateIsUserEligibleForAutofillImprovementsFunction&) =
delete;
AutofillPrivateIsUserEligibleForAutofillImprovementsFunction& operator=(
const AutofillPrivateIsUserEligibleForAutofillImprovementsFunction&) =
delete;
DECLARE_EXTENSION_FUNCTION(
"autofillPrivate.isUserEligibleForAutofillImprovements",
AUTOFILLPRIVATE_ISUSERELIGIBLEFORAUTOFILLIMPROVEMENTS)
protected:
~AutofillPrivateIsUserEligibleForAutofillImprovementsFunction() override =
default;
// ExtensionFunction overrides.
ResponseAction Run() override;
};
class AutofillPrivatePredictionImprovementsIphFeatureUsedFunction
: public AutofillPrivateExtensionFunction {
public:
AutofillPrivatePredictionImprovementsIphFeatureUsedFunction() = default;
AutofillPrivatePredictionImprovementsIphFeatureUsedFunction(
const AutofillPrivatePredictionImprovementsIphFeatureUsedFunction&) =
delete;
AutofillPrivatePredictionImprovementsIphFeatureUsedFunction& operator=(
const AutofillPrivatePredictionImprovementsIphFeatureUsedFunction&) =
delete;
DECLARE_EXTENSION_FUNCTION(
"autofillPrivate.predictionImprovementsIphFeatureUsed",
AUTOFILLPRIVATE_PREDICTIONIMPROVEMENTSIPHFFEATUREUSED)
protected:
~AutofillPrivatePredictionImprovementsIphFeatureUsedFunction() override =
default;
// ExtensionFunction overrides.
ResponseAction Run() override;
};
class AutofillPrivateAddOrUpdateEntityInstanceFunction
: public AutofillPrivateExtensionFunction {
public:

@ -275,21 +275,6 @@ IN_PROC_BROWSER_TEST_F(AutofillPrivateApiUnitTest, BulkDeleteAllCvcs) {
}
}
IN_PROC_BROWSER_TEST_F(AutofillPrivateApiUnitTest,
PredictionImprovementsIphFeatureUsed) {
using NotifyIphMockCallback =
testing::MockFunction<void(autofill::AutofillClient::IphFeature)>;
NotifyIphMockCallback mock_callback;
autofill_client()->set_notify_iph_feature_used_mock_callback(
base::BindRepeating(&NotifyIphMockCallback::Call,
base::Unretained(&mock_callback)));
EXPECT_CALL(mock_callback,
Call(autofill::AutofillClient::IphFeature::kAutofillAi));
RunAutofillSubtest("predictionImprovementsIphFeatureUsed");
}
IN_PROC_BROWSER_TEST_F(AutofillPrivateApiUnitTest, LogServerCardLinkClicked) {
base::HistogramTester histogram_tester;
ASSERT_TRUE(RunAutofillSubtest("logServerCardLinkClicked"));

@ -386,12 +386,6 @@ IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, bulkDeleteAllCvcs) {
EXPECT_TRUE(RunAutofillSubtest("bulkDeleteAllCvcs")) << message_;
}
IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest,
IsUserEligibleForAutofillImprovements) {
EXPECT_TRUE(RunAutofillSubtest("isUserEligibleForAutofillImprovements"))
<< message_;
}
IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, AddVirtualCard) {
autofill::TestPersonalDataManager& personal_data_manager =
autofill_client()->GetPersonalDataManager();

@ -432,7 +432,6 @@ namespace autofillPrivate {
callback IsValidIbanCallback = void(boolean isValid);
callback GetCreditCardCallback = void(optional CreditCardEntry card);
callback CheckForDeviceAuthCallback = void(boolean isDeviceAuthAvailable);
callback isUserEligibleForAutofillImprovementsCallback = void(boolean eligible);
callback LoadEntityInstancesCallback = void(EntityInstanceWithLabels[] entries);
callback GetEntityInstanceByGuid = void(EntityInstance entityInstance);
callback GetAllEntityTypesCallback = void(EntityType[] entityTypes);
@ -555,13 +554,6 @@ namespace autofillPrivate {
// `syncer::UserSelectableType::kAutofill` in `SyncUserSettings`.
static void setAutofillSyncToggleEnabled(boolean enabled);
// Returns if the user is eligible for autofill improvements.
static void isUserEligibleForAutofillImprovements(
isUserEligibleForAutofillImprovementsCallback callback);
// Notifies autofill client about the prediction improvements pre changing.
static void predictionImprovementsIphFeatureUsed();
// Adds a new entity instance if it doesn't exist yet. Otherwise, it updates
// the entity instance.
static void addOrUpdateEntityInstance(

@ -856,22 +856,6 @@ var availableTests = [
chrome.test.succeed();
},
function isUserEligibleForAutofillImprovements() {
chrome.autofillPrivate.isUserEligibleForAutofillImprovements(function(
isEligible) {
// TODO(crbug.com/373609897): Override account info status in the test
// setup to verify this properly.
chrome.test.assertFalse(isEligible, "Expected not eligible");
chrome.test.succeed();
});
},
function predictionImprovementsIphFeatureUsed() {
chrome.autofillPrivate.predictionImprovementsIphFeatureUsed();
chrome.test.assertNoLastError();
chrome.test.succeed();
},
function logServerCardLinkClicked() {
chrome.autofillPrivate.logServerCardLinkClicked();
chrome.test.assertNoLastError();
@ -1088,10 +1072,6 @@ var TESTS_FOR_CONFIG = {
['authenticateUserAndFlipMandatoryAuthToggle'],
'getLocalCard': ['addNewCreditCard', 'getLocalCard'],
'bulkDeleteAllCvcs': ['bulkDeleteAllCvcs'],
'isUserEligibleForAutofillImprovements':
['isUserEligibleForAutofillImprovements'],
'predictionImprovementsIphFeatureUsed':
['predictionImprovementsIphFeatureUsed'],
'logServerCardLinkClicked': ['logServerCardLinkClicked'],
'addVirtualCard': ['addVirtualCard'],
'removeVirtualCard': ['removeVirtualCard'],

@ -1968,8 +1968,8 @@ enum HistogramValue {
AUTOTESTPRIVATE_GETDEVICEEVENTLOG = 1905,
ACCESSIBILITY_PRIVATE_UPDATEFACEGAZEBUBBLE = 1906,
DELETED_AUTOFILLPRIVATE_HASUSERANNOTATIONSENTRIES = 1907,
AUTOFILLPRIVATE_ISUSERELIGIBLEFORAUTOFILLIMPROVEMENTS = 1908,
AUTOFILLPRIVATE_PREDICTIONIMPROVEMENTSIPHFFEATUREUSED = 1909,
DELETED_AUTOFILLPRIVATE_ISUSERELIGIBLEFORAUTOFILLIMPROVEMENTS = 1908,
DELETED_AUTOFILLPRIVATE_PREDICTIONIMPROVEMENTSIPHFFEATUREUSED = 1909,
DELETED_AUTOFILLPRIVATE_TRIGGERANNOTATIONSBOOTSTRAPPING = 1910,
ACCESSIBILITY_PRIVATE_ENABLEDRAGEVENTREWRITER = 1911,
TTSENGINE_UPDATELANGUAGE = 1912,

@ -2787,9 +2787,9 @@ Called by update_extension_histograms.py.-->
<int value="1906" label="ACCESSIBILITY_PRIVATE_UPDATEFACEGAZEBUBBLE"/>
<int value="1907" label="DELETED_AUTOFILLPRIVATE_HASUSERANNOTATIONSENTRIES"/>
<int value="1908"
label="AUTOFILLPRIVATE_ISUSERELIGIBLEFORAUTOFILLIMPROVEMENTS"/>
label="DELETED_AUTOFILLPRIVATE_ISUSERELIGIBLEFORAUTOFILLIMPROVEMENTS"/>
<int value="1909"
label="AUTOFILLPRIVATE_PREDICTIONIMPROVEMENTSIPHFFEATUREUSED"/>
label="DELETED_AUTOFILLPRIVATE_PREDICTIONIMPROVEMENTSIPHFFEATUREUSED"/>
<int value="1910"
label="DELETED_AUTOFILLPRIVATE_TRIGGERANNOTATIONSBOOTSTRAPPING"/>
<int value="1911" label="ACCESSIBILITY_PRIVATE_ENABLEDRAGEVENTREWRITER"/>

@ -273,8 +273,6 @@ declare global {
export function checkIfDeviceAuthAvailable(): Promise<boolean>;
export function bulkDeleteAllCvcs(): void;
export function setAutofillSyncToggleEnabled(enabled: boolean): void;
export function isUserEligibleForAutofillImprovements(): Promise<boolean>;
export function predictionImprovementsIphFeatureUsed(): void;
export function addOrUpdateEntityInstance(entityInstance: EntityInstance):
void;
export function removeEntityInstance(guid: string): void;