chromium/src
0
Fork 0
Code Activity

Remove PDFViewerUpdate flag

Browse Source 
Bug: 1164004
Change-Id: I480f2993ab8ebdf266ab259c708d30e7427e2491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2689811
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853424}
This commit is contained in:
rbpotter
2021-02-12 07:21:45 +00:00
committed by Chromium LUCI CQ
parent 7206e59213
commit a7fbe71cb1
8 changed files with 2 additions and 39 deletions

4
chrome/browser/about_flags.cc

@ -4767,10 +4767,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAccessiblePDFFormDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kAccessiblePDFForm)},
{"pdf-viewer-update", flag_descriptions::kPdfViewerUpdateName,
flag_descriptions::kPdfViewerUpdateDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kPDFViewerUpdate)},
{"pdf-viewer-document-properties",
flag_descriptions::kPdfViewerDocumentPropertiesName,
flag_descriptions::kPdfViewerDocumentPropertiesDescription, kOsDesktop,

5
chrome/browser/flag_descriptions.cc

@ -5003,11 +5003,6 @@ const char kPaintPreviewStartupDescription[] =
#if BUILDFLAG(ENABLE_PLUGINS)
const char kPdfViewerUpdateName[] = "PDF Viewer Update";
const char kPdfViewerUpdateDescription[] =
"When enabled, the PDF viewer will display an updated UI with new "
"options and features.";
const char kPdfViewerDocumentPropertiesName[] =
"PDF Viewer Document Properties";
const char kPdfViewerDocumentPropertiesDescription[] =

3
chrome/browser/flag_descriptions.h

@ -2937,9 +2937,6 @@ extern const char kPaintPreviewStartupDescription[];
#endif // ENABLE_PAINT_PREVIEW && defined(OS_ANDROID)
#if BUILDFLAG(ENABLE_PLUGINS)
extern const char kPdfViewerUpdateName[];
extern const char kPdfViewerUpdateDescription[];
extern const char kPdfViewerDocumentPropertiesName[];
extern const char kPdfViewerDocumentPropertiesDescription[];

2
chrome/browser/pdf/pdf_extension_test.cc

@ -391,7 +391,6 @@ class PDFExtensionTest : public extensions::ExtensionApiTest {
// Hooks to set up feature flags.
virtual const std::vector<base::Feature> GetEnabledFeatures() const {
std::vector<base::Feature> enabled;
enabled.push_back(chrome_pdf::features::kPDFViewerUpdate);
if (ShouldEnablePdfViewerPresentationMode()) {
enabled.push_back(chrome_pdf::features::kPdfViewerPresentationMode);
}
@ -3107,7 +3106,6 @@ class PDFExtensionAccessibilityTreeDumpTest
const std::vector<base::Feature> GetEnabledFeatures() const override {
std::vector<base::Feature> enabled = {
chrome_pdf::features::kAccessiblePDFForm,
chrome_pdf::features::kPDFViewerUpdate,
};
return enabled;
}

4
chrome/browser/resources/pdf/viewport.js

@ -173,7 +173,7 @@ export class Viewport {
// Set to a default zoom manager - used in tests.
this.setZoomManager(new InactiveZoomManager(this.getZoom.bind(this), 1));
// Case where |chrome_pdf::features::kPDFViewerUpdate| is disabled.
// Print Preview
if (this.window_ === document.documentElement ||
// Necessary check since during testing a fake DOM element is used.
!(this.window_ instanceof HTMLElement)) {
@ -186,7 +186,7 @@ export class Viewport {
// |resizeCallback| to be called on the mock |window_| object (legacy).
this.window_.resizeCallback = this.resizeWrapper_.bind(this);
} else {
// Case where |chrome_pdf::features::kPDFViewerUpdate| is enabled.
// Standard PDF viewer
this.window_.addEventListener('scroll', this.updateViewport_.bind(this));
const resizeObserver = new ResizeObserver(_ => this.resizeWrapper_());
const target = this.window_.parentElement;

3
pdf/pdf_features.cc

@ -22,9 +22,6 @@ const base::Feature kPdfIncrementalLoading = {
const base::Feature kPdfPartialLoading = {"PdfPartialLoading",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kPDFViewerUpdate = {"PDFViewerUpdate",
base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kPdfViewerDocumentProperties = {
"PdfViewerDocumentProperties", base::FEATURE_DISABLED_BY_DEFAULT};

1
pdf/pdf_features.h

@ -18,7 +18,6 @@ extern const base::Feature kPdfIncrementalLoading;
extern const base::Feature kPdfPartialLoading;
extern const base::Feature kPdfViewerDocumentProperties;
extern const base::Feature kPdfViewerPresentationMode;
extern const base::Feature kPDFViewerUpdate;
extern const base::Feature kPdfXfaSupport;
extern const base::Feature kTabAcrossPDFAnnotations;

19
testing/variations/fieldtrial_testing_config.json

@ -5001,25 +5001,6 @@
]
}
],
"PDFViewerUpdate": [
{
"platforms": [
"chromeos",
"chromeos_lacros",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"PDFViewerUpdate"
]
}
]
}
],
"PageInfoV2": [
{
"platforms": [