Remove PageLiveStateDecoratorDefaultImpl

This CL simply makes PageLiveStateDecorator an interface with default
impls for each method. The pure virtual vs virtual with default impl
distinction is not needed.

Bug: 409466139
Change-Id: I91ff21f4b25df9f81a66f5d9cf111f3b494ddf6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6437464
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Auto-Submit: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1444970}

chrome/browser/extensions/api/tabs/tabs_event_router.h

@@ -39,14 +39,13 @@ namespace extensions {
 // extension process renderers.
 // TabsEventRouter will only route events from windows/tabs within a profile to
 // extension processes in the same profile.
-class TabsEventRouter
-    : public TabStripModelObserver,
-      public BrowserTabStripTrackerDelegate,
-      public BrowserListObserver,
-      public favicon::FaviconDriverObserver,
-      public zoom::ZoomObserver,
-      public resource_coordinator::LifecycleUnitObserver,
-      public performance_manager::PageLiveStateObserverDefaultImpl {
+class TabsEventRouter : public TabStripModelObserver,
+                        public BrowserTabStripTrackerDelegate,
+                        public BrowserListObserver,
+                        public favicon::FaviconDriverObserver,
+                        public zoom::ZoomObserver,
+                        public resource_coordinator::LifecycleUnitObserver,
+                        public performance_manager::PageLiveStateObserver {
  public:
   explicit TabsEventRouter(Profile* profile);
 
@@ -99,7 +98,7 @@ class TabsEventRouter
       ::mojom::LifecycleUnitState previous_state,
       ::mojom::LifecycleUnitStateChangeReason reason) override;
 
-  // performance_manager::PageLiveStateObserverDefaultImpl:
+  // performance_manager::PageLiveStateObserver:
   void OnIsAutoDiscardableChanged(
       const performance_manager::PageNode* page_node) override;
 

chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc

@@ -87,7 +87,7 @@ class MockLifecycleUnitObserver : public LifecycleUnitObserver {
 };
 
 class MockPageLiveStateObserver
-    : public performance_manager::PageLiveStateObserverDefaultImpl {
+    : public performance_manager::PageLiveStateObserver {
  public:
   MOCK_METHOD(void,
               OnIsAutoDiscardableChanged,

components/performance_manager/decorators/frame_visibility_decorator.h

@@ -44,21 +44,6 @@ class FrameVisibilityDecorator : public GraphOwnedDefaultImpl,
   // PageLiveStateObserver:
   void OnIsBeingMirroredChanged(const PageNode* page_node) override;
 
-  // Unused from PageLiveStateObserver:
-  void OnIsConnectedToUSBDeviceChanged(const PageNode* page_node) override {}
-  void OnIsConnectedToBluetoothDeviceChanged(
-      const PageNode* page_node) override {}
-  void OnIsConnectedToHidDeviceChanged(const PageNode* page_node) override {}
-  void OnIsConnectedToSerialPortChanged(const PageNode* page_node) override {}
-  void OnIsCapturingVideoChanged(const PageNode* page_node) override {}
-  void OnIsCapturingAudioChanged(const PageNode* page_node) override {}
-  void OnIsCapturingWindowChanged(const PageNode* page_node) override {}
-  void OnIsCapturingDisplayChanged(const PageNode* page_node) override {}
-  void OnIsAutoDiscardableChanged(const PageNode* page_node) override {}
-  void OnIsActiveTabChanged(const PageNode* page_node) override {}
-  void OnIsPinnedTabChanged(const PageNode* page_node) override {}
-  void OnIsDevToolsOpenChanged(const PageNode* page_node) override {}
-
   // FrameNodeObserver:
   void OnBeforeFrameNodeAdded(
       const FrameNode* frame_node,

components/performance_manager/decorators/page_live_state_decorator.cc

@@ -681,7 +681,4 @@ PageLiveStateDecorator::Data::GetOrCreateForPageNode(
 PageLiveStateObserver::PageLiveStateObserver() = default;
 PageLiveStateObserver::~PageLiveStateObserver() = default;
 
-PageLiveStateObserverDefaultImpl::PageLiveStateObserverDefaultImpl() = default;
-PageLiveStateObserverDefaultImpl::~PageLiveStateObserverDefaultImpl() = default;
-
 }  // namespace performance_manager

components/performance_manager/decorators/page_live_state_decorator_unittest.cc

@@ -132,7 +132,7 @@ class TestPageLiveStateObserver : public PageLiveStateObserver {
       scoped_observation_{this};
 };
 
-class MockPageLiveStateObserver : public PageLiveStateObserverDefaultImpl {
+class MockPageLiveStateObserver : public PageLiveStateObserver {
  public:
   MOCK_METHOD(void,
               OnIsConnectedToUSBDeviceChanged,

components/performance_manager/freezing/freezing_policy.h

@@ -53,7 +53,7 @@ namespace performance_manager {
 // freezing.
 class FreezingPolicy : public PageNodeObserver,
                        public FrameNodeObserver,
-                       public PageLiveStateObserverDefaultImpl,
+                       public PageLiveStateObserver,
                        public resource_attribution::QueryResultObserver,
                        public GraphOwnedAndRegistered<FreezingPolicy>,
                        public NodeDataDescriberDefaultImpl {
@@ -175,7 +175,7 @@ class FreezingPolicy : public PageNodeObserver,
       const FrameNode* previous_parent_or_outer_document_or_embedder) override;
   void OnIsAudibleChanged(const FrameNode* frame_node) override;
 
-  // PageLiveStateObserverDefaultImpl:
+  // PageLiveStateObserver:
   void OnIsConnectedToUSBDeviceChanged(const PageNode* page_node) override;
   void OnIsConnectedToBluetoothDeviceChanged(
       const PageNode* page_node) override;

components/performance_manager/public/decorators/page_live_state_decorator.h

@@ -198,46 +198,20 @@ class PageLiveStateObserver : public base::CheckedObserver {
   PageLiveStateObserver(const PageLiveStateObserver& other) = delete;
   PageLiveStateObserver& operator=(const PageLiveStateObserver&) = delete;
 
-  virtual void OnIsConnectedToUSBDeviceChanged(const PageNode* page_node) = 0;
+  virtual void OnIsConnectedToUSBDeviceChanged(const PageNode* page_node) {}
   virtual void OnIsConnectedToBluetoothDeviceChanged(
-      const PageNode* page_node) = 0;
-  virtual void OnIsConnectedToHidDeviceChanged(const PageNode* page_node) = 0;
-  virtual void OnIsConnectedToSerialPortChanged(const PageNode* page_node) = 0;
-  virtual void OnIsCapturingVideoChanged(const PageNode* page_node) = 0;
-  virtual void OnIsCapturingAudioChanged(const PageNode* page_node) = 0;
-  virtual void OnIsBeingMirroredChanged(const PageNode* page_node) = 0;
-  virtual void OnIsCapturingWindowChanged(const PageNode* page_node) = 0;
-  virtual void OnIsCapturingDisplayChanged(const PageNode* page_node) = 0;
-  virtual void OnIsAutoDiscardableChanged(const PageNode* page_node) = 0;
-  virtual void OnIsActiveTabChanged(const PageNode* page_node) = 0;
-  virtual void OnIsPinnedTabChanged(const PageNode* page_node) = 0;
-  virtual void OnIsDevToolsOpenChanged(const PageNode* page_node) = 0;
-};
-
-class PageLiveStateObserverDefaultImpl : public PageLiveStateObserver {
- public:
-  PageLiveStateObserverDefaultImpl();
-  ~PageLiveStateObserverDefaultImpl() override;
-  PageLiveStateObserverDefaultImpl(
-      const PageLiveStateObserverDefaultImpl& other) = delete;
-  PageLiveStateObserverDefaultImpl& operator=(
-      const PageLiveStateObserverDefaultImpl&) = delete;
-
-  // PageLiveStateObserver:
-  void OnIsConnectedToUSBDeviceChanged(const PageNode* page_node) override {}
-  void OnIsConnectedToBluetoothDeviceChanged(
-      const PageNode* page_node) override {}
-  void OnIsConnectedToHidDeviceChanged(const PageNode* page_node) override {}
-  void OnIsConnectedToSerialPortChanged(const PageNode* page_node) override {}
-  void OnIsCapturingVideoChanged(const PageNode* page_node) override {}
-  void OnIsCapturingAudioChanged(const PageNode* page_node) override {}
-  void OnIsBeingMirroredChanged(const PageNode* page_node) override {}
-  void OnIsCapturingWindowChanged(const PageNode* page_node) override {}
-  void OnIsCapturingDisplayChanged(const PageNode* page_node) override {}
-  void OnIsAutoDiscardableChanged(const PageNode* page_node) override {}
-  void OnIsActiveTabChanged(const PageNode* page_node) override {}
-  void OnIsPinnedTabChanged(const PageNode* page_node) override {}
-  void OnIsDevToolsOpenChanged(const PageNode* page_node) override {}
+      const PageNode* page_node) {}
+  virtual void OnIsConnectedToHidDeviceChanged(const PageNode* page_node) {}
+  virtual void OnIsConnectedToSerialPortChanged(const PageNode* page_node) {}
+  virtual void OnIsCapturingVideoChanged(const PageNode* page_node) {}
+  virtual void OnIsCapturingAudioChanged(const PageNode* page_node) {}
+  virtual void OnIsBeingMirroredChanged(const PageNode* page_node) {}
+  virtual void OnIsCapturingWindowChanged(const PageNode* page_node) {}
+  virtual void OnIsCapturingDisplayChanged(const PageNode* page_node) {}
+  virtual void OnIsAutoDiscardableChanged(const PageNode* page_node) {}
+  virtual void OnIsActiveTabChanged(const PageNode* page_node) {}
+  virtual void OnIsPinnedTabChanged(const PageNode* page_node) {}
+  virtual void OnIsDevToolsOpenChanged(const PageNode* page_node) {}
 };
 
 }  // namespace performance_manager

components/performance_manager/public/user_tuning/tab_revisit_tracker.h

@@ -20,7 +20,7 @@ namespace performance_manager {
 // active/background/closed/discarded states and records timing information
 // about these states.
 class TabRevisitTracker : public TabPageObserver,
-                          public PageLiveStateObserverDefaultImpl,
+                          public PageLiveStateObserver,
                           public PageNodeObserver,
                           public GraphOwnedAndRegistered<TabRevisitTracker> {
  public:
@@ -83,7 +83,7 @@ class TabRevisitTracker : public TabPageObserver,
       TabPageDecorator::TabHandle* tab_handle) override;
   void OnBeforeTabRemoved(TabPageDecorator::TabHandle* tab_handle) override;
 
-  // PageLiveStateObserverDefaultImpl:
+  // PageLiveStateObserver:
   void OnIsActiveTabChanged(const PageNode* page_node) override;
 
   // PageNodeObserver: