chromium/src
0
Fork 0
Code Activity

Accessibility: Update select to speak accelerator dialog strings

Browse Source 
This CL updates the strings used in the select to speak accelerator
dialog so that they match the UXW-approved strings.

Bug: b/286006143
Change-Id: Ib9562b57839f168d8d3fe188b6fa4ce1166d62e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564169
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Padlipsky <dpad@google.com>
Cr-Commit-Position: refs/heads/main@{#1308764}
This commit is contained in:
Akihiro Ota
2024-05-31 18:10:35 +00:00
committed by Chromium LUCI CQ
parent 9a56446902
commit a8a7aba3f0
4 changed files with 16 additions and 6 deletions

12
ash/accessibility/accessibility_controller.cc

@ -84,6 +84,7 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/display/screen.h"
#include "ui/display/tablet_state.h"
#include "ui/events/ash/keyboard_capability.h"
#include "ui/gfx/animation/animation.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/public/cpp/notifier_id.h"
@ -2127,8 +2128,15 @@ void AccessibilityController::ShowSelectToSpeakKeyboardDialog() {
std::u16string title =
l10n_util::GetStringUTF16(IDS_ASH_SELECT_TO_SPEAK_KEYBOARD_DIALOG_TITLE);
std::u16string description = l10n_util::GetStringUTF16(
IDS_ASH_SELECT_TO_SPEAK_KEYBOARD_DIALOG_DESCRIPTION);
std::u16string modifier_key;
if (Shell::Get()->keyboard_capability()->HasLauncherButtonOnAnyKeyboard()) {
modifier_key = l10n_util::GetStringUTF16(IDS_KSV_MODIFIER_LAUNCHER);
} else {
modifier_key = l10n_util::GetStringUTF16(IDS_KSV_MODIFIER_SEARCH);
}
std::u16string description = l10n_util::GetStringFUTF16(
IDS_ASH_SELECT_TO_SPEAK_KEYBOARD_DIALOG_DESCRIPTION, modifier_key);
ShowConfirmationDialog(
title, description, l10n_util::GetStringUTF16(IDS_APP_CANCEL),
base::BindOnce(

6
ash/ash_strings.grd

@ -1456,10 +1456,12 @@ Style notes:
<!-- Select to Speak keyboard dialog strings -->
<message name="IDS_ASH_SELECT_TO_SPEAK_KEYBOARD_DIALOG_TITLE" desc="The title of a dialog that is shown when Select to Speak is enabled from the keyboard.">
Turn on Select-to-Speak?
Turn on Select-to-speak?
</message>
<message name="IDS_ASH_SELECT_TO_SPEAK_KEYBOARD_DIALOG_DESCRIPTION" desc="The description of a dialog that is shown when Select-to-Speak is enabled from the keyboard.">
Hear specific text read aloud. First, select the Select-to-speak icon on the bottom of your screen, then highlight text. You can also use a keyboard shortcut: Highlight text, then press Search/Launcher + S.
To hear text read aloud, select the Select-to-speak icon on the bottom of your screen, then highlight text.
You can also use the keyboard shortcut. First, highlight text, then press <ph name="modifier">$1<ex>launcher</ex></ph> + s.
</message>
<!-- Accessibility nudges -->

2
ash/ash_strings_grd/IDS_ASH_SELECT_TO_SPEAK_KEYBOARD_DIALOG_DESCRIPTION.png.sha1

@ -1 +1 @@
4a51afee868b526dcb197c5bca8e412e57487692
3dbbf57d0f61ec2571c3d367eadf54ebeb209d86

2
ash/ash_strings_grd/IDS_ASH_SELECT_TO_SPEAK_KEYBOARD_DIALOG_TITLE.png.sha1

@ -1 +1 @@
d1ab8f35ea4f475bba5e94a7ec5e2914edb05182
3dbbf57d0f61ec2571c3d367eadf54ebeb209d86