chromium/src
0
Fork 0
Code Activity

[PDF Ink Signatures] Add IFTTT to brush color values

Browse Source 
Add IFTTT to the brush color values that map to metrics.

NO_IFTTT=This CL adds new IFTTT to existing code.

Bug: 380433757
Change-Id: Ie18ed74f6c3fd297ac0904cd340cc78731576ac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062744
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1391318}
This commit is contained in:
Andy Phan
2024-12-03 23:10:28 +00:00
committed by Chromium LUCI CQ
parent de22bc5538
commit a9e6174997
2 changed files with 9 additions and 0 deletions
chrome/browser/resources/pdf/elements
ink_color_selector.ts
pdf
pdf_ink_metrics_handler.cc

5
chrome/browser/resources/pdf/elements/ink_color_selector.ts

@ -20,6 +20,7 @@ interface ColorOption {
}
const HIGHLIGHTER_COLORS: ColorOption[] = [
// LINT.IfChange(HighlighterColors)
// Row 1:
{name: 'highlighterColorLightRed', color: '#f28b82'},
{name: 'highlighterColorLightYellow', color: '#fdd663'},
@ -32,9 +33,12 @@ const HIGHLIGHTER_COLORS: ColorOption[] = [
{name: 'highlighterColorGreen', color: '#25e387'},
{name: 'highlighterColorBlue', color: '#5379ff'},
{name: 'highlighterColorOrange', color: '#ff630c'},
// LINT.ThenChange(//pdf/pdf_ink_metrics_handler.cc:HighlighterColors)
];
const PEN_COLORS: ColorOption[] = [
// LINT.IfChange(PenColors)
// Row 1:
{name: 'penColorBlack', color: '#000000'},
{name: 'penColorDarkGrey2', color: '#5f6368'},
@ -59,6 +63,7 @@ const PEN_COLORS: ColorOption[] = [
{name: 'penColorGreen3', color: '#188038'},
{name: 'penColorBlue3', color: '#1967d2'},
{name: 'penColorTan3', color: '#885945'},
// LINT.ThenChange(//pdf/pdf_ink_metrics_handler.cc:PenColors)
];
/**

4
pdf/pdf_ink_metrics_handler.cc

@ -37,6 +37,7 @@ constexpr auto kHighlighterSizes =
});
// LINT.ThenChange(//chrome/browser/resources/pdf/elements/ink_size_selector.ts:HighlighterSizes)
// LINT.IfChange(PenColors)
constexpr auto kPenColors =
base::MakeFixedFlatMap<SkColor, StrokeMetricPenColor>({
{SK_ColorBLACK, StrokeMetricPenColor::kBlack},
@ -60,7 +61,9 @@ constexpr auto kPenColors =
{SkColorSetRGB(0x19, 0x67, 0xD2), StrokeMetricPenColor::kBlue3},
{SkColorSetRGB(0x88, 0x59, 0x45), StrokeMetricPenColor::kTan3},
});
// LINT.ThenChange(//chrome/browser/resources/pdf/elements/ink_color_selector.ts:PenColors)
// LINT.IfChange(HighlighterColors)
constexpr auto kHighlighterColors =
base::MakeFixedFlatMap<SkColor, StrokeMetricHighlighterColor>({
{SkColorSetRGB(0xF2, 0x8B, 0x82),
@ -81,6 +84,7 @@ constexpr auto kHighlighterColors =
{SkColorSetRGB(0xFF, 0x63, 0x0C),
StrokeMetricHighlighterColor::kOrange},
});
// LINT.ThenChange(//chrome/browser/resources/pdf/elements/ink_color_selector.ts:HighlighterColors)
void ReportStrokeTypeAndSize(StrokeMetricBrushType type,
StrokeMetricBrushSize size) {