0

[URL] Opt-out "drivefs://" scheme from non-special URL support

The following test is failing [^1][^2] in linux-chromeos-rel when we
enable the StandardCompliandNonSpecialSchemeURLParser feature [^3]:

- SystemNotificationManagerTest.Errors

It appears that the test uses "drivefs://" scheme URLs.

Usually, I would try to fix the failure somehow, however, chromeos
codebase presents a challenge for me, due to limitations in my
familiarity with ChromeOS development.

Therefore, as a temporary solution, let me tentatively opt-out
"drivefs://" scheme from non-special URL support, as I did it for
"android://" scheme [4]. That makes these failing tests pass regardless
of the feature state.

For a more permanent solution, code owners or domain experts familiar
with ChromeOS development might want to work on a real fix, if
necessary. If a proper fix is critical before we ship the feature, I'd
appreciate if you could file a bug and marking it blocking for bug
40063064 so we don't ship the feature until all critical issues are
addressed.

[^1]: https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-rel/b8747893304852642561/test-results
[^2]: https://docs.google.com/spreadsheets/d/1Pqw1iKXK_lxHj-kLIAeRFs-khFz-BPZDio1W7SgEVE4/
[^3]: http://bit.ly/url-non-special
[^4]: https://crrev.com/c/5515685

Bug: 40063064
Change-Id: Ifecd15b90b458f2abcd4b743c25db921125e2015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569365
Reviewed-by: Ben Reich <benreich@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306594}
This commit is contained in:
Hayato Ito
2024-05-28 05:06:46 +00:00
committed by Chromium LUCI CQ
parent 0252be9ea5
commit aa5588aad9
2 changed files with 4 additions and 0 deletions

@ -37,6 +37,8 @@ inline constexpr char kCrosApps[] = "cros-apps";
inline constexpr char16_t kCrosApps16[] = u"cros-apps";
inline constexpr char kDataScheme[] = "data";
inline constexpr char16_t kDataScheme16[] = u"data";
inline constexpr char kDrivefs[] = "drivefs";
inline constexpr char16_t kDrivefs16[] = u"drivefs";
inline constexpr char kFileScheme[] = "file";
inline constexpr char16_t kFileScheme16[] = u"file";
inline constexpr char kFileSystemScheme[] = "filesystem";

@ -126,6 +126,8 @@ struct SchemeRegistry {
// Temporarily opted-out. See https://crrev.com/c/5547181.
kAlmanac,
kCrosApps,
// Temporarily opted-out. See https://crrev.com/c/5569365.
kDrivefs,
};
// Schemes with a predefined default custom handler.