Use NOTREACHED_IN_MIGRATION() in components/
This was generated by replacing " NOTREACHED()" with " NOTREACHED_IN_MIGRATION()" and running git cl format. This prepares for making NOTREACHED() [[noreturn]] alongside NotReachedIsFatal migration of existing inventory. Bug: 40580068 Change-Id: I92e83d0b564d44267f003147a1ce6ba3674621a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539175 Owners-Override: Lei Zhang <thestig@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300923}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
043e32e8ad
commit
aaf19db38d
components
account_id
account_manager_core
android_autofill
arc
intent_helper
assist_ranker
attribution_reporting
autofill
content
renderer
core
browser
address_data_manager.ccaddress_profile_save_manager.ccaddress_profile_save_manager_unittest.ccautofill_address_util.ccautofill_external_delegate.ccautofill_field.ccautofill_manager.ccautofill_profile_import_process.ccautofill_save_update_address_profile_delegate_ios.ccautofill_test_utils.ccbrowser_autofill_manager.ccbrowser_autofill_manager_unittest.cc
data_model
autofill_profile.ccautofill_profile_comparator.ccautofill_structured_address_regex_provider.cccredit_card.cciban.ccphone_number.cc
field_filling_payments_util_unittest.ccform_data_importer_unittest.ccform_filler.ccform_parsing
form_structure.ccform_structure_rationalizer.ccform_types.ccgeo
logging
metrics
autofill_metrics.ccfield_filling_stats_and_score_metrics.cclog_event.cc
payments
profile_import_metrics.ccquality_metrics_unittest.ccpayments
autofill_save_card_infobar_delegate_mobile.ccautofill_virtual_card_enrollment_infobar_delegate_mobile.cccredit_card_access_manager.cccredit_card_access_manager_unittest.cccredit_card_cvc_authenticator.cccredit_card_fido_authenticator.cccredit_card_otp_authenticator.cccredit_card_save_manager_unittest.ccfull_card_request.cclocal_card_migration_manager.ccpayments_network_interface_unittest.cc
payments_data_manager.ccrandomized_encoder.ccpayments_requests
get_card_upload_details_request.ccget_details_for_enrollment_request.ccget_details_for_enrollment_request_unittest.ccopt_change_request.ccunmask_card_request.ccupdate_virtual_card_enrollment_request.ccupdate_virtual_card_enrollment_request_unittest.cc
virtual_card_enroll_metrics_logger.ccvirtual_card_enrollment_manager_unittest.ccui
payments
webdata
addresses
autocomplete
payments
common
ios
browser
background_fetch
background_sync
blocked_content
bookmarks
browser
bookmark_client.ccbookmark_codec.ccbookmark_model.ccbookmark_model_unittest.ccbookmark_node_data_ios.ccbookmark_utils.cc
managed
browser_ui
site_settings
android
browsing_data
content
core
browsing_topics
captive_portal
cast
message_port
fuchsia
cast_streaming
browser
renderer
cbor
cdm
chromeos_camera
cloud_devices
common
commerce
component_updater
content_capture
content_settings
browser
core
browser
content_settings_default_provider.cccontent_settings_policy_provider.cccontent_settings_uma_util.cccontent_settings_utils.cchost_content_settings_map.ccprivate_network_settings.cc
common
renderer
crash
content
browser
core
cronet
native
desks_storage
device_event_log
device_signals
discardable_memory
dom_distiller
domain_reliability
download
content
internal
database
internal
background_service
controller_impl.ccentry_utils.ccin_memory_download_driver.cc
ios
logger_impl.ccmodel_stats.ccproto_conversions.ccscheduler
stats.cccommon
public
background_service
common
drive
embedder_support
enterprise
browser
controller
reporting
client_certificates
data_controls
error_page
exo
drag_drop_operation.ccextended_drag_source.cckeyboard.ccpointer.ccseat.ccshell_surface.ccsurface.cc
test
touch.ccwayland
favicon
favicon_base
feature_engagement
feed
core
find_in_page
flags_ui
gcm_driver
crypto
fake_gcm_profile_service.ccgcm_account_tracker.ccgcm_client_impl.ccgcm_desktop_utils.ccgcm_driver.ccgcm_driver_android.ccgcm_stats_recorder_impl.ccinstance_id
global_media_controls
public
guest_view
browser
headless
policy
heap_profiling
in_process
multi_process
history
content
browser
core
history_clusters
core
image_fetcher
invalidation
javascript_dialogs
keep_alive_registry
keyed_service
leveldb_proto
internal
public
live_caption
local_state
lookalikes
media_message_center
media_router
browser
common
memory_pressure
metrics
call_stacks
content
debug
delegating_provider.ccdemographics
field_trials_provider.ccfile_metrics_provider.ccmachine_id_provider_win.ccmetrics_log.ccmetrics_provider.ccmetrics_service_observer.ccnet
persistent_system_profile.ccstability_metrics_helper.ccstructured
unsent_log_store.ccversion_utils.ccminidump_uploader
mirroring
nacl
browser
loader
renderer
named_mojo_ipc_server
navigation_interception
net_log
network_time
no_state_prefetch
browser
ntp_tiles
offline_pages
content
background_loader
core
background
downloads
model
request_header
task
omnibox
browser
actions
autocomplete_controller.ccautocomplete_match.ccautocomplete_match_type.ccautocomplete_provider.ccautocomplete_result.ccautocomplete_result_android.ccautocomplete_scoring_model_executor.ccfavicon_cache.cchistory_fuzzy_provider.cchistory_fuzzy_provider_unittest.cclocation_bar_model_util.ccomnibox_edit_model.ccomnibox_popup_selection.ccomnibox_view.ccsearch_provider.cczero_suggest_provider.ccopen_from_clipboard
openscreen_platform
optimization_guide
content
browser
core
hint_cache.cchints_fetcher.cchints_manager.cchints_processing_util.cc
model_execution
model_execution_features.ccmodel_execution_manager_unittest.ccon_device_model_execution_proto_value_utils.ccoptimization_guide_model_execution_error.cc
model_info.ccmodel_quality
model_util.ccmodel_validator.ccoptimization_guide_util.ccstore_update_data.cctools
os_crypt
page_content_annotations
core
page_image_service
page_info
page_load_metrics
browser
metrics_web_contents_observer.cc
observers
page_load_metrics_forward_observer.ccpage_load_metrics_test_waiter.ccpage_load_tracker.ccrenderer
paint_preview
browser
paint_preview_base_service_unittest.ccpaint_preview_client.ccpaint_preview_client_unittest.ccpaint_preview_file_mixin.cc
common
player
renderer
password_manager
content
core
browser
browser_save_password_progress_logger.cccredential_manager_pending_prevent_silent_access_task.ccform_fetcher_impl.cc
generation
import
password_autofill_manager.ccpassword_form.ccpassword_form_metrics_recorder.ccpassword_generation_frame_helper_unittest.ccpassword_manager_metrics_recorder.ccpassword_manager_metrics_util.ccpassword_save_manager_impl.ccpassword_store
password_model_type_controller_delegate_android.ccpassword_store_backend_metrics_recorder.ccpassword_store_built_in_backend.cc
sharing
store_metrics_reporter.ccsync
votes_uploader.ccservices
csv_password
public
payments
content
android
android_payment_app.ccpayment_app.ccpayment_method_manifest_table.ccpayment_request.ccpayment_request_converter.ccpayment_request_spec.ccsecure_payment_confirmation_app.ccsecure_payment_confirmation_controller.ccsecure_payment_confirmation_no_creds.ccservice_worker_payment_app.ccssl_validity_checker.ccweb_app_manifest_section_table.cccore
pdf
browser
performance_manager
decorators
execution_context
graph
metrics
performance_manager_feature_observer_client.ccperformance_manager_impl.ccservice_worker_context_adapter.ccv8_memory
permissions
android
bluetooth_chooser_controller.ccchooser_controller.cccontexts
geolocation_permission_context_android.ccpayment_handler_permission_context.ccwake_lock_permission_context.cc
pepc_initiated_permission_request_unittest.ccpermission_hats_trigger_helper.ccpermission_request.ccpermission_request_manager.ccpermission_uma_util.ccpermission_util.ccprediction_service
prediction_common.ccprediction_model_executor.ccprediction_model_handler_provider.ccprediction_service.cc
request_type.cctest
plugins
renderer
plus_addresses
policy
core
browser
common
android
cloud
cloud_policy_client.cccloud_policy_client_registration_helper.cccloud_policy_refresh_scheduler.cccloud_policy_util.cccloud_policy_validator.ccdevice_management_service.ccdmserver_job_configurations.ccrealtime_reporting_job_configuration.ccresource_cache.ccuser_cloud_policy_store.cc
device_local_account_type.ccmock_configuration_policy_provider.ccpolicy_bundle.ccpolicy_loader_lacros.ccpolicy_loader_win_unittest.ccpolicy_map.ccpolicy_statistics_collector.ccpolicy_utils.ccremote_commands
schema.ccschema_registry.cctest_support
power_bookmarks
prefs
printing
privacy_sandbox
proxy_config
query_parser
query_tiles
internal
reading_list
remote_cocoa
renderer_context_menu
reporting
client
rlz
safe_browsing
android
content
browser
base_blocking_page.ccbase_ui_manager.ccbrowser_url_loader_throttle.ccclient_report_util.ccsafe_browsing_network_context.cc
triggers
ui_manager.ccui_manager_unittest.ccweb_ui
renderer
core
browser
db
database_manager.ccv4_database.ccv4_local_database_manager.ccv4_rice.ccv4_store.ccv4_update_protocol_manager.cc
hashprefix_realtime
password_protection
ping_manager.ccrealtime
safe_browsing_metrics_collector.ccsafe_browsing_url_checker_impl_unittest.ccverdict_cache_manager.cccommon
safe_search_api
saved_tab_groups
search_engines
search_provider_logos
security_interstitials
content
captive_portal_blocking_page.cchttps_only_mode_blocking_page.ccinsecure_form_blocking_page.cc
renderer
security_interstitial_controller_client.ccssl_error_handler.ccstateful_ssl_host_state_delegate.cccore
security_state
segmentation_platform
internal
database
dummy_ukm_data_manager.ccexecution
optimization_guide
processing
metadata
migration
post_processor
selection
signals
stats.ccservices
app_service
public
font
heap_profiling
paint_preview_compositor
storage
dom_storage
indexed_db
public
cpp
filesystem
service_worker
sessions
core
ios
shared_highlighting
core
signin
core
browser
internal
identity_manager
account_capabilities_fetcher_unittest.ccaccount_tracker_service.ccaccounts_mutator_impl.ccmutable_profile_oauth2_token_service_delegate.ccoauth_multilogin_token_fetcher.ccprofile_oauth2_token_service_builder.ccprofile_oauth2_token_service_delegate.ccprofile_oauth2_token_service_delegate_chromeos.ccprofile_oauth2_token_service_delegate_ios.cc
ios
public
site_engagement
site_isolation
speech
spellcheck
browser
common
renderer
ssl_errors
startup_metric_utils
browser
storage_monitor
subresource_filter
content
browser
shared
core
supervised_user
core
sync
base
engine
commit.cccommit_processor.cc
cycle
get_updates_processor.ccloopback_server
model_type_worker.ccnet
nigori
shutdown_reason.ccsync_manager_impl.ccsync_protocol_error.ccsync_scheduler_impl.ccsync_string_conversions.ccsyncer.ccsyncer_proto_util.ccinvalidations
model
nigori
protocol
service
data_type_manager_impl.ccdata_type_status_table.ccmodel_type_controller.ccnon_ui_syncable_service_based_model_type_controller.ccpassphrase_type_metrics_provider.ccsync_auth_manager.ccsync_internals_util.ccsync_prefs.ccsync_service.ccsync_service_crypto.ccsync_service_impl.ccsync_service_utils.ccsync_session_durations_metrics_recorder.cc
test
sync_bookmarks
sync_device_info
sync_preferences
sync_sessions
sync_user_events
system_media_controls
tab_groups
translate
content
core
browser
translate_internals
trusted_vault
ui_devtools
update_client
url_formatter
tools
url_matcher
url_pattern_index
url_rewrite
common
user_education
common
feature_promo_controller.ccfeature_promo_lifecycle.ccfeature_promo_lifecycle_unittest.cchelp_bubble.cc
views
webui
user_manager
value_store
variations
visitedlink
viz
common
host
service
compositor_frame_fuzzer
display
dc_layer_overlay.ccdirect_renderer.ccdisplay_resource_provider_skia_unittest.ccdisplay_scheduler.ccexternal_use_client.ccnull_renderer.ccoutput_surface.ccoverlay_processor_ozone.ccoverlay_processor_using_strategy.ccrenderer_pixeltest.ccskia_renderer.ccsoftware_renderer.ccsurface_aggregator_unittest.cc
display_embedder
output_presenter_fuchsia.ccoutput_surface_provider_impl.ccoutput_surface_unified.ccskia_output_device.ccskia_output_device_buffer_queue_unittest.ccskia_output_device_vulkan.ccskia_output_surface_impl_on_gpu.cc
frame_sinks
compositor_frame_sink_support.ccexternal_begin_frame_source_ios.mmroot_compositor_frame_sink_impl.cc
video_capture
gl
performance_hint
transitions
test
web_package
webapps
browser
webauthn
webcrypto
webrtc
webxr
android
wifi
@ -74,7 +74,7 @@ bool AccountId::operator==(const AccountId& other) const {
|
||||
case AccountType::ACTIVE_DIRECTORY:
|
||||
return id_ == other.id_ && user_email_ == other.user_email_;
|
||||
default:
|
||||
NOTREACHED() << "Unknown account type";
|
||||
NOTREACHED_IN_MIGRATION() << "Unknown account type";
|
||||
}
|
||||
return false;
|
||||
}
|
||||
@ -104,7 +104,7 @@ bool AccountId::is_valid() const {
|
||||
case AccountType::UNKNOWN:
|
||||
return id_.empty() && !user_email_.empty();
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
@ -152,7 +152,7 @@ const std::string AccountId::GetAccountIdKey() const {
|
||||
case AccountType::ACTIVE_DIRECTORY:
|
||||
return std::string(kKeyAdIdPrefix) + id_;
|
||||
default:
|
||||
NOTREACHED() << "Unknown account type";
|
||||
NOTREACHED_IN_MIGRATION() << "Unknown account type";
|
||||
}
|
||||
return std::string();
|
||||
}
|
||||
@ -201,7 +201,7 @@ AccountType AccountId::StringToAccountType(
|
||||
return AccountType::ACTIVE_DIRECTORY;
|
||||
if (account_type_string == kUnknown)
|
||||
return AccountType::UNKNOWN;
|
||||
NOTREACHED() << "Unknown account type " << account_type_string;
|
||||
NOTREACHED_IN_MIGRATION() << "Unknown account type " << account_type_string;
|
||||
return AccountType::UNKNOWN;
|
||||
}
|
||||
|
||||
|
@ -23,7 +23,7 @@ struct EnumTraits<signin::mojom::AccountType, AccountType> {
|
||||
case AccountType::ACTIVE_DIRECTORY:
|
||||
return signin::mojom::AccountType::ACTIVE_DIRECTORY;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return signin::mojom::AccountType::UNKNOWN;
|
||||
}
|
||||
|
||||
@ -39,7 +39,7 @@ struct EnumTraits<signin::mojom::AccountType, AccountType> {
|
||||
*out = AccountType::ACTIVE_DIRECTORY;
|
||||
return true;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
};
|
||||
@ -61,7 +61,7 @@ struct StructTraits<signin::mojom::AccountIdDataView, AccountId> {
|
||||
// Return an empty string for such accounts.
|
||||
return std::string();
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::string();
|
||||
}
|
||||
static std::string user_email(const AccountId& r) { return r.GetUserEmail(); }
|
||||
|
@ -119,11 +119,11 @@ bool GetIsAvailableInArcBySource(
|
||||
kChromeOSProjectorAppReauth:
|
||||
case AccountManagerFacade::AccountAdditionSource::
|
||||
kChromeSettingsReauthAccountButton:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
// Unused enums that cannot be deleted.
|
||||
case AccountManagerFacade::AccountAdditionSource::kPrintPreviewDialogUnused:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
@ -65,7 +65,7 @@ ToMojoInvalidGaiaCredentialsReason(
|
||||
return cm::GoogleServiceAuthError::InvalidGaiaCredentialsReason::
|
||||
kCredentialsMissing;
|
||||
case GoogleServiceAuthError::InvalidGaiaCredentialsReason::NUM_REASONS:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return cm::GoogleServiceAuthError::InvalidGaiaCredentialsReason::kUnknown;
|
||||
}
|
||||
}
|
||||
@ -94,7 +94,7 @@ crosapi::mojom::GoogleServiceAuthError::State ToMojoGoogleServiceAuthErrorState(
|
||||
case GoogleServiceAuthError::State::CHALLENGE_RESPONSE_REQUIRED:
|
||||
return cm::GoogleServiceAuthError::State::kChallengeResponseRequired;
|
||||
case GoogleServiceAuthError::State::NUM_STATES:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return cm::GoogleServiceAuthError::State::kNone;
|
||||
}
|
||||
}
|
||||
@ -147,7 +147,8 @@ crosapi::mojom::AccountUpsertionResult::Status ToMojoAccountAdditionStatus(
|
||||
// entirely on the remote side when the receiver can't even be reached.
|
||||
// They do not have any Mojo equivalent since they are never passed over
|
||||
// the wire in the first place.
|
||||
NOTREACHED() << "These statuses should not be passed over the wire";
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< "These statuses should not be passed over the wire";
|
||||
// Return something to make the compiler happy. This should never happen
|
||||
// in production.
|
||||
return cm::AccountUpsertionResult::Status::kUnexpectedResponse;
|
||||
|
@ -158,13 +158,13 @@ void AndroidAutofillClient::ShowAutofillSettings(
|
||||
void AndroidAutofillClient::ShowEditAddressProfileDialog(
|
||||
const autofill::AutofillProfile& profile,
|
||||
AddressProfileSavePromptCallback on_user_decision_callback) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
void AndroidAutofillClient::ShowDeleteAddressProfileDialog(
|
||||
const autofill::AutofillProfile& profile,
|
||||
AddressProfileDeleteDialogCallback delete_dialog_callback) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
void AndroidAutofillClient::ConfirmCreditCardFillAssist(
|
||||
|
@ -249,7 +249,7 @@ AndroidFormEventLogger* AndroidAutofillManager::GetEventFormLogger(
|
||||
case FormType::kUnknownFormType:
|
||||
return nullptr;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
|
@ -284,7 +284,7 @@ void ArcIntentHelperBridge::IsChromeAppEnabled(
|
||||
return;
|
||||
}
|
||||
|
||||
NOTREACHED() << "Unknown chrome app";
|
||||
NOTREACHED_IN_MIGRATION() << "Unknown chrome app";
|
||||
std::move(callback).Run(false);
|
||||
}
|
||||
|
||||
|
@ -114,13 +114,13 @@ bool FeatureToInt64(const Feature& feature,
|
||||
value = StringToIntBits(feature.string_list().string_value(index));
|
||||
} else {
|
||||
DVLOG(3) << "Invalid index for string list: " << index;
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
break;
|
||||
default:
|
||||
DVLOG(3) << "Feature type is supported for logging: " << type;
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
*res = PairInt(type, value, index);
|
||||
|
@ -34,7 +34,7 @@ bool RankerURLFetcher::Request(
|
||||
// This function is not supposed to be called if the previous operation is not
|
||||
// finished.
|
||||
if (state_ == REQUESTING) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -193,7 +193,7 @@ void GetReportsFromIndexRecursive(TriggerSpecs::Iterator it,
|
||||
}
|
||||
prev_sum += num_states;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
absl::uint128 GetNumStatesCached(const TriggerSpecs& specs,
|
||||
|
@ -404,7 +404,7 @@ bool IsInCrossOriginIframeOrEmbeddedFrame(const WebInputElement& element) {
|
||||
if (element.GetDocument().GetFrame()->IsInFencedFrameTree()) {
|
||||
return true;
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
return false;
|
||||
|
@ -663,7 +663,7 @@ AddressDataManager::GetProfileStorage(AutofillProfile::Source source) const {
|
||||
case AutofillProfile::Source::kAccount:
|
||||
return account_profiles_;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
void AddressDataManager::OnAutofillProfileChanged(
|
||||
|
@ -97,7 +97,7 @@ void AddressProfileSaveManager::MaybeOfferSavePrompt(
|
||||
return;
|
||||
|
||||
case AutofillProfileImportType::kImportTypeUnspecified:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
@ -440,7 +440,7 @@ void AddressProfileSaveManagerTest::VerifyUpdateAffectedTypesHistogram(
|
||||
break;
|
||||
|
||||
default:
|
||||
NOTREACHED() << "Decision not covered by test logic.";
|
||||
NOTREACHED_IN_MIGRATION() << "Decision not covered by test logic.";
|
||||
}
|
||||
for (auto changed_type :
|
||||
test_scenario.expected_affeceted_types_in_merge_for_metrics) {
|
||||
|
@ -71,7 +71,7 @@ std::vector<AutofillAddressUIComponent> GetAddressComponents(
|
||||
ui_language_code, components_language_code);
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return {};
|
||||
}
|
||||
|
||||
|
@ -682,7 +682,7 @@ void AutofillExternalDelegate::DidPerformButtonActionForSuggestion(
|
||||
NOTIMPLEMENTED();
|
||||
return;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -234,7 +234,7 @@ bool AutofillField::server_type_prediction_is_override() const {
|
||||
void AutofillField::set_heuristic_type(HeuristicSource s, FieldType type) {
|
||||
if (type < 0 || type > MAX_VALID_FIELD_TYPE ||
|
||||
type == FIELD_WITH_DEFAULT_VALUE) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
// This case should not be reachable; but since this has potential
|
||||
// implications on data uploaded to the server, better safe than sorry.
|
||||
type = UNKNOWN_TYPE;
|
||||
|
@ -322,7 +322,7 @@ void AutofillManager::OnFormsParsed(const std::vector<FormData>& forms) {
|
||||
for (const FormData& form : forms) {
|
||||
FormStructure* form_structure = FindCachedFormById(form.global_id());
|
||||
if (!form_structure) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
continue;
|
||||
}
|
||||
|
||||
|
@ -373,7 +373,7 @@ void ProfileImportProcess::SetUserDecision(
|
||||
break;
|
||||
|
||||
case UserDecision::kUndefined:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@ -195,7 +195,7 @@ bool AutofillSaveUpdateAddressProfileDelegateIOS::EqualsDelegate(
|
||||
}
|
||||
|
||||
int AutofillSaveUpdateAddressProfileDelegateIOS::GetIconId() const {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return IDR_INFOBAR_AUTOFILL_CC;
|
||||
}
|
||||
|
||||
|
@ -614,7 +614,7 @@ std::vector<CardUnmaskChallengeOption> GetCardUnmaskChallengeOptions(
|
||||
break;
|
||||
}
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@ -387,9 +387,9 @@ FillDataType GetEventTypeFromSingleFieldSuggestionType(SuggestionType type) {
|
||||
case SuggestionType::kWebauthnSignInWithAnotherDevice:
|
||||
case SuggestionType::kDevtoolsTestAddresses:
|
||||
case SuggestionType::kDevtoolsTestAddressEntry:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return FillDataType::kUndefined;
|
||||
}
|
||||
|
||||
@ -2920,7 +2920,7 @@ void BrowserAutofillManager::LogEventCountsUMAMetric(
|
||||
log_event)) {
|
||||
++num_rationalization_event;
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -2962,7 +2962,7 @@ void BrowserAutofillManager::SetFastCheckoutRunId(
|
||||
case FormType::kPasswordForm:
|
||||
case FormType::kUnknownFormType:
|
||||
// FastCheckout only supports address and credit card forms.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -1158,7 +1158,7 @@ class BrowserAutofillManagerTest : public testing::Test {
|
||||
matchers.push_back(
|
||||
Equal(absl::get<RationalizationFieldLogEvent>(event)));
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
return ElementsAreArray(matchers);
|
||||
@ -1213,7 +1213,7 @@ class BrowserAutofillManagerTest : public testing::Test {
|
||||
if (metric & (1 << sample))
|
||||
return sample;
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -544,7 +544,7 @@ bool AutofillProfile::IsPresentButInvalid(FieldType type) const {
|
||||
return !IsValidEmailAddress(data);
|
||||
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@ -1185,7 +1185,7 @@ FormGroup* AutofillProfile::MutableFormGroupForType(const AutofillType& type) {
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
|
@ -574,7 +574,8 @@ bool AutofillProfileComparator::MergeCompanyNames(
|
||||
switch (result) {
|
||||
case DIFFERENT_TOKENS:
|
||||
default:
|
||||
NOTREACHED() << "Unexpected mismatch: '" << c1 << "' vs '" << c2 << "'";
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< "Unexpected mismatch: '" << c1 << "' vs '" << c2 << "'";
|
||||
return false;
|
||||
case S1_CONTAINS_S2:
|
||||
best = &c1;
|
||||
@ -955,7 +956,7 @@ bool AutofillProfileComparator::HaveMergeablePhoneNumbers(
|
||||
case PhoneNumberUtil::NO_MATCH:
|
||||
return false;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
@ -532,7 +532,7 @@ std::string StructuredAddressesRegExProvider::GetPattern(
|
||||
case RegEx::kParseStreetNameHouseNumber:
|
||||
return ParseStreetNameHouseNumberExpression();
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
const RE2* StructuredAddressesRegExProvider::GetRegEx(
|
||||
|
@ -730,7 +730,8 @@ void CreditCard::SetRawInfoWithVerificationStatus(FieldType type,
|
||||
break;
|
||||
|
||||
default:
|
||||
NOTREACHED() << "Attempting to set unknown info-type " << type;
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< "Attempting to set unknown info-type " << type;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@ -252,7 +252,7 @@ std::u16string Iban::GetRawInfo(FieldType type) const {
|
||||
return value_;
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::u16string();
|
||||
}
|
||||
|
||||
@ -262,7 +262,7 @@ void Iban::SetRawInfoWithVerificationStatus(FieldType type,
|
||||
if (type == IBAN_VALUE) {
|
||||
set_value(value);
|
||||
} else {
|
||||
NOTREACHED() << "Attempting to set unknown info-type" << type;
|
||||
NOTREACHED_IN_MIGRATION() << "Attempting to set unknown info-type" << type;
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -270,7 +270,7 @@ std::u16string PhoneNumber::GetInfoImpl(const AutofillType& type,
|
||||
return std::u16string();
|
||||
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::u16string();
|
||||
}
|
||||
}
|
||||
|
@ -305,7 +305,7 @@ TEST_P(CreditCardVerificationCodeTest, FillFormField_StandaloneCVCField) {
|
||||
EXPECT_EQ(credit_card.cvc(), value_to_fill);
|
||||
return;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
@ -331,7 +331,7 @@ TEST_P(CreditCardVerificationCodeTest,
|
||||
EXPECT_EQ(kCvc, value_to_fill);
|
||||
return;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -217,7 +217,7 @@ AutofillProfile ConstructProfileFromTypeValuePairs(
|
||||
VerificationStatus::kObserved);
|
||||
}
|
||||
if (!profile.FinalizeAfterImport())
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return profile;
|
||||
}
|
||||
|
||||
|
@ -944,7 +944,7 @@ void FormFiller::TriggerRefill(const FormData& form,
|
||||
trigger_details,
|
||||
/*is_refill=*/true);
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -33,7 +33,7 @@ void AutofillScanner::Advance() {
|
||||
|
||||
AutofillField* AutofillScanner::Cursor() const {
|
||||
if (IsEnd()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
|
@ -62,7 +62,7 @@ bool FieldCanFitDataForFieldType(uint64_t max_length, FieldType type) {
|
||||
return max_length >= kMinimum4YearCcExpLength;
|
||||
}
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
@ -378,7 +378,7 @@ std::u16string PhoneFieldParser::GetRegExp(RegexType regex_id) {
|
||||
case REGEX_EXTENSION:
|
||||
return kPhoneExtensionRe;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
return std::u16string();
|
||||
@ -406,7 +406,7 @@ const char* PhoneFieldParser::GetRegExpName(RegexType regex_id) {
|
||||
case REGEX_EXTENSION:
|
||||
return "kPhoneExtensionRe";
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
return "";
|
||||
@ -435,7 +435,7 @@ std::string PhoneFieldParser::GetJSONFieldType(RegexType phonetype_id) {
|
||||
case REGEX_EXTENSION:
|
||||
return "PHONE_EXTENSION";
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
return std::string();
|
||||
|
@ -47,7 +47,7 @@ base::span<const MatchPatternRef> GetMatchPatterns(
|
||||
return it->second[0];
|
||||
}
|
||||
#endif
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return {};
|
||||
}
|
||||
|
||||
|
@ -707,7 +707,7 @@ void FormStructure::AssignBestFieldTypes(
|
||||
|
||||
const AutofillField* FormStructure::field(size_t index) const {
|
||||
if (index >= fields_.size()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return nullptr;
|
||||
}
|
||||
return fields_[index].get();
|
||||
|
@ -740,7 +740,7 @@ void FormStructureRationalizer::RationalizeAddressLineFields(
|
||||
<< "ADDRESS_HOME_LINE3";
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
++nb_address_rationalized;
|
||||
|
@ -44,7 +44,7 @@ std::string_view FormTypeToStringView(FormType form_type) {
|
||||
return "Unknown";
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "UnknownFormType";
|
||||
}
|
||||
|
||||
|
@ -89,7 +89,7 @@ FieldType TypeForField(AddressField address_field) {
|
||||
case ::i18n::addressinput::RECIPIENT:
|
||||
return NAME_FULL;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return UNKNOWN_TYPE;
|
||||
}
|
||||
|
||||
|
@ -306,7 +306,7 @@ bool PhoneNumbersMatch(const std::u16string& number_a,
|
||||
return true;
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -73,7 +73,7 @@ std::vector<std::string> RenderFragment(const base::Value::Dict& entry) {
|
||||
std::vector<std::string> RenderEntry(const base::Value::Dict& entry) {
|
||||
const std::string* type = entry.FindString("type");
|
||||
if (!type) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
} else if (*type == "element") {
|
||||
return RenderElement(entry);
|
||||
} else if (*type == "text") {
|
||||
@ -81,7 +81,7 @@ std::vector<std::string> RenderEntry(const base::Value::Dict& entry) {
|
||||
} else if (*type == "fragment") {
|
||||
return RenderFragment(entry);
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
return {};
|
||||
}
|
||||
|
@ -333,7 +333,8 @@ int GetFieldTypeGroupPredictionQualityMetric(
|
||||
case CREDIT_CARD_STANDALONE_VERIFICATION_CODE:
|
||||
case SINGLE_USERNAME_FORGOT_PASSWORD:
|
||||
case SINGLE_USERNAME_WITH_INTERMEDIATE_VALUES:
|
||||
NOTREACHED() << field_type << " type is not in that group.";
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< field_type << " type is not in that group.";
|
||||
group = GROUP_AMBIGUOUS;
|
||||
break;
|
||||
}
|
||||
@ -372,7 +373,8 @@ int GetFieldTypeGroupPredictionQualityMetric(
|
||||
group = GROUP_CREDIT_CARD_VERIFICATION;
|
||||
break;
|
||||
default:
|
||||
NOTREACHED() << field_type << " has no group assigned (ambiguous)";
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< field_type << " has no group assigned (ambiguous)";
|
||||
group = GROUP_AMBIGUOUS;
|
||||
break;
|
||||
}
|
||||
@ -391,7 +393,7 @@ int GetFieldTypeGroupPredictionQualityMetric(
|
||||
break;
|
||||
|
||||
case FieldTypeGroup::kTransaction:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
|
||||
@ -430,7 +432,7 @@ const char* GetQualityMetricPredictionSource(
|
||||
switch (source) {
|
||||
default:
|
||||
case AutofillMetrics::PREDICTION_SOURCE_UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "Unknown";
|
||||
|
||||
case AutofillMetrics::PREDICTION_SOURCE_HEURISTIC:
|
||||
@ -446,7 +448,7 @@ const char* GetQualityMetricTypeSuffix(
|
||||
AutofillMetrics::QualityMetricType metric_type) {
|
||||
switch (metric_type) {
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
[[fallthrough]];
|
||||
case AutofillMetrics::TYPE_SUBMISSION:
|
||||
return "";
|
||||
@ -964,7 +966,7 @@ void AutofillMetrics::LogUnmaskPromptEventDuration(
|
||||
suffix = ".Success";
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
base::UmaHistogramLongTimes("Autofill.UnmaskPrompt.Duration", duration);
|
||||
@ -1019,7 +1021,7 @@ void AutofillMetrics::LogRealPanResult(
|
||||
metric_result = PAYMENTS_RESULT_VCN_RETRIEVAL_PERMANENT_FAILURE;
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -1032,7 +1034,7 @@ void AutofillMetrics::LogRealPanResult(
|
||||
card_type_suffix = "VirtualCard";
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcCardType::kUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -1084,7 +1086,7 @@ void AutofillMetrics::LogRealPanDuration(
|
||||
result_suffix = "NetworkError";
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -1111,7 +1113,7 @@ void AutofillMetrics::LogUnmaskingDuration(
|
||||
card_type_suffix = "VirtualCard";
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcCardType::kUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -1132,7 +1134,7 @@ void AutofillMetrics::LogUnmaskingDuration(
|
||||
result_suffix = "NetworkError";
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
base::UmaHistogramLongTimes("Autofill.UnmaskPrompt.UnmaskingDuration",
|
||||
@ -1443,7 +1445,7 @@ void AutofillMetrics::LogStoredCreditCardMetrics(
|
||||
break;
|
||||
case CreditCard::RecordType::kVirtualCard:
|
||||
// This card type is not persisted in Chrome.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
@ -1629,7 +1631,7 @@ AutofillMetrics::CreditCardSeamlessness::QualitativeFillableFormEvent() const {
|
||||
return autofill_metrics::
|
||||
FORM_EVENT_CREDIT_CARD_SEAMLESS_FILLABLE_PARTIAL_FILL;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return autofill_metrics::
|
||||
FORM_EVENT_CREDIT_CARD_SEAMLESS_FILLABLE_PARTIAL_FILL;
|
||||
}
|
||||
@ -1656,7 +1658,7 @@ AutofillMetrics::CreditCardSeamlessness::QualitativeFillFormEvent() const {
|
||||
return autofill_metrics::
|
||||
FORM_EVENT_CREDIT_CARD_SEAMLESS_FILL_PARTIAL_FILL;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return autofill_metrics::FORM_EVENT_CREDIT_CARD_SEAMLESS_FILL_PARTIAL_FILL;
|
||||
}
|
||||
|
||||
@ -2809,7 +2811,7 @@ void AutofillMetrics::LogAutocompletePredictionCollisionTypes(
|
||||
autocomplete_suffix = "Password";
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
// Log the metric for heuristic and server type.
|
||||
@ -2849,7 +2851,7 @@ const std::string PaymentsRpcResultToMetricsSuffix(
|
||||
result_suffix = ".VcnRetrievalFailure";
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
return result_suffix;
|
||||
@ -2882,7 +2884,7 @@ std::string AutofillMetrics::GetHistogramStringForCardType(
|
||||
case AutofillClient::PaymentsRpcCardType::kVirtualCard:
|
||||
return ".VirtualCard";
|
||||
case AutofillClient::PaymentsRpcCardType::kUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
} else if (absl::holds_alternative<CreditCard::RecordType>(card_type)) {
|
||||
|
@ -252,7 +252,7 @@ void FormGroupFillingStats::AddFieldFillingStatus(FieldFillingStatus status) {
|
||||
num_left_empty++;
|
||||
return;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
FieldFillingStatus GetFieldFillingStatus(const AutofillField& field) {
|
||||
|
@ -32,11 +32,11 @@ bool OptionalBooleanToBool(OptionalBoolean value) {
|
||||
case OptionalBoolean::kTrue:
|
||||
return true;
|
||||
case OptionalBoolean::kUndefined:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -104,7 +104,7 @@ void LogLocalCardMigrationPromptMetric(
|
||||
histogram_name += "SettingsPage";
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
base::UmaHistogramEnumeration(histogram_name, metric,
|
||||
|
@ -40,7 +40,7 @@ void LogOfferNotificationBubbleOfferMetric(
|
||||
commerce::UrlContainsDiscountUtmTag(url));
|
||||
break;
|
||||
case AutofillOfferData::OfferType::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
base::UmaHistogramBoolean(histogram_name, is_reshow);
|
||||
@ -70,7 +70,7 @@ void LogOfferNotificationBubblePromoCodeButtonClicked(
|
||||
break;
|
||||
case AutofillOfferData::OfferType::GPAY_CARD_LINKED_OFFER:
|
||||
case AutofillOfferData::OfferType::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
base::UmaHistogramBoolean(histogram_name, true);
|
||||
@ -98,7 +98,7 @@ void LogOfferNotificationBubbleResultMetric(
|
||||
histogram_name += "FreeListingCouponOffer.";
|
||||
break;
|
||||
case AutofillOfferData::OfferType::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
// Add subhistogram for |is_reshow| decision.
|
||||
@ -120,7 +120,7 @@ void LogOfferNotificationBubbleSuppressed(
|
||||
break;
|
||||
case AutofillOfferData::OfferType::GPAY_CARD_LINKED_OFFER:
|
||||
case AutofillOfferData::OfferType::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
base::UmaHistogramBoolean(histogram_name, true);
|
||||
@ -152,7 +152,7 @@ void LogStoredOfferMetrics(
|
||||
break;
|
||||
case AutofillOfferData::OfferType::FREE_LISTING_COUPON_OFFER:
|
||||
case AutofillOfferData::OfferType::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
continue;
|
||||
}
|
||||
base::UmaHistogramCounts1000(related_merchant_count_histogram_name,
|
||||
@ -205,7 +205,7 @@ void LogIndividualOfferSuggestionEvent(
|
||||
case AutofillOfferData::OfferType::GPAY_CARD_LINKED_OFFER:
|
||||
case AutofillOfferData::OfferType::FREE_LISTING_COUPON_OFFER:
|
||||
case AutofillOfferData::OfferType::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
|
@ -41,7 +41,7 @@ const char* GetAddressPromptDecisionMetricsSuffix(
|
||||
case AutofillClient::AddressPromptUserDecision::kAutoDeclined:
|
||||
return ".AutoDeclined";
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "";
|
||||
}
|
||||
|
||||
|
@ -465,7 +465,7 @@ class PredictionQualityMetricsTest
|
||||
return "Decca";
|
||||
|
||||
default:
|
||||
NOTREACHED(); // Fall through
|
||||
NOTREACHED_IN_MIGRATION(); // Fall through
|
||||
return "unexpected!";
|
||||
}
|
||||
}
|
||||
@ -523,7 +523,7 @@ class PredictionQualityMetricsTest
|
||||
actual_type != predicted_type && predicted_type == UNKNOWN_TYPE;
|
||||
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
@ -95,7 +95,7 @@ std::u16string AutofillSaveCardInfoBarDelegateMobile::GetButtonLabel(
|
||||
return ui_info_.cancel_text;
|
||||
}
|
||||
|
||||
NOTREACHED() << "Unsupported button label requested.";
|
||||
NOTREACHED_IN_MIGRATION() << "Unsupported button label requested.";
|
||||
return std::u16string();
|
||||
}
|
||||
|
||||
|
@ -119,7 +119,7 @@ AutofillVirtualCardEnrollmentInfoBarDelegateMobile::GetButtonLabel(
|
||||
return virtual_card_enroll_bubble_controller_->GetUiModel()
|
||||
.cancel_action_text;
|
||||
}
|
||||
NOTREACHED() << "Unsupported button label requested.";
|
||||
NOTREACHED_IN_MIGRATION() << "Unsupported button label requested.";
|
||||
return std::u16string();
|
||||
}
|
||||
|
||||
|
@ -235,7 +235,7 @@ void CreditCardAccessManager::LogMetricsAndFillFormForServerUnmaskFlows(
|
||||
case UnmaskAuthFlowType::kCvc:
|
||||
case UnmaskAuthFlowType::kCvcFallbackFromFido:
|
||||
case UnmaskAuthFlowType::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
std::move(on_credit_card_fetched_callback_)
|
||||
@ -541,7 +541,7 @@ void CreditCardAccessManager::Authenticate(
|
||||
autofill_metrics::LogCardUnmaskTypeDecision(
|
||||
autofill_metrics::CardUnmaskTypeDecisionMetric::kFidoOnly);
|
||||
#if BUILDFLAG(IS_IOS)
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
#else
|
||||
// If |is_authentication_in_progress_| is false, it means the process has
|
||||
// been cancelled via the verification pending dialog. Do not run
|
||||
@ -659,7 +659,7 @@ void CreditCardAccessManager::Authenticate(
|
||||
}
|
||||
case UnmaskAuthFlowType::kNone:
|
||||
// Run into other unexpected types.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
Reset();
|
||||
break;
|
||||
}
|
||||
@ -905,7 +905,7 @@ void CreditCardAccessManager::OnOtpAuthenticationComplete(
|
||||
break;
|
||||
case OtpAuthenticationResponse::Result::kSuccess:
|
||||
case OtpAuthenticationResponse::Result::kUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -1336,7 +1336,7 @@ void CreditCardAccessManager::OnRiskBasedAuthenticationResponseReceived(
|
||||
break;
|
||||
case CreditCardRiskBasedAuthenticator::RiskBasedAuthenticationResponse::
|
||||
Result::kUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
Reset();
|
||||
break;
|
||||
}
|
||||
@ -1515,7 +1515,7 @@ void CreditCardAccessManager::OnUserAcceptedAuthenticationSelectionDialog(
|
||||
// here as a safety.
|
||||
if (!selected_challenge_option_ ||
|
||||
virtual_card_unmask_response_details_.context_token.empty()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
std::move(on_credit_card_fetched_callback_)
|
||||
.Run(CreditCardFetchResult::kTransientError, nullptr);
|
||||
client_->GetPaymentsAutofillClient()->ShowAutofillErrorDialog(
|
||||
@ -1542,7 +1542,7 @@ void CreditCardAccessManager::OnUserAcceptedAuthenticationSelectionDialog(
|
||||
UnmaskAuthFlowType::kThreeDomainSecureConsentAlreadyGiven;
|
||||
break;
|
||||
case CardUnmaskChallengeOptionType::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
Authenticate(selected_authentication_type);
|
||||
@ -1576,7 +1576,7 @@ void CreditCardAccessManager::OnVirtualCardUnmaskCancelled() {
|
||||
case UnmaskAuthFlowType::kFido:
|
||||
case UnmaskAuthFlowType::kCvcThenFido:
|
||||
case UnmaskAuthFlowType::kCvcFallbackFromFido:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
ABSL_FALLTHROUGH_INTENDED;
|
||||
case UnmaskAuthFlowType::kThreeDomainSecure:
|
||||
// TODO(crbug.com/40240970): Add a flow type for the kThreeDomainSecure
|
||||
|
@ -544,7 +544,7 @@ class CreditCardAccessManagerTest : public testing::Test {
|
||||
EXPECT_TRUE(vcn_3ds_context.user_consent_already_given);
|
||||
break;
|
||||
case CardUnmaskChallengeOptionType::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
@ -3979,7 +3979,7 @@ TEST_F(CreditCardAccessManagerTest,
|
||||
break;
|
||||
case CardUnmaskChallengeOptionType::kEmailOtp:
|
||||
case CardUnmaskChallengeOptionType::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@ -127,7 +127,7 @@ void CreditCardCvcAuthenticator::OnFullCardRequestFailed(
|
||||
event = autofill_metrics::CvcAuthEvent::kGenericError;
|
||||
break;
|
||||
case payments::FullCardRequest::FailureType::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
event = autofill_metrics::CvcAuthEvent::kUnknown;
|
||||
break;
|
||||
}
|
||||
|
@ -360,7 +360,7 @@ void CreditCardFidoAuthenticator::OptChange(
|
||||
OptChangeRequestDetails::ADD_CARD_FOR_FIDO_AUTH;
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
|
||||
@ -594,7 +594,7 @@ CreditCardFidoAuthenticator::ParseCreationOptions(
|
||||
} else if (base::EqualsCaseInsensitiveASCII(*attestation, "DIRECT")) {
|
||||
options->attestation = device::AttestationConveyancePreference::kDirect;
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
// Only allow user-verifying platform authenticators.
|
||||
@ -725,7 +725,7 @@ void CreditCardFidoAuthenticator::LogWebauthnResult(
|
||||
: autofill_metrics::WebauthnFlowEvent::kCheckoutOptIn;
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -812,7 +812,7 @@ void CreditCardFidoAuthenticator::HandleGetAssertionSuccess(
|
||||
case NONE_FLOW:
|
||||
case OPT_IN_FETCH_CHALLENGE_FLOW:
|
||||
case OPT_OUT_FLOW: {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
}
|
||||
@ -864,7 +864,7 @@ void CreditCardFidoAuthenticator::HandleGetAssertionFailure() {
|
||||
case NONE_FLOW:
|
||||
case OPT_IN_FETCH_CHALLENGE_FLOW:
|
||||
case OPT_OUT_FLOW: {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@ -285,7 +285,7 @@ void CreditCardOtpAuthenticator::OnDidGetRealPan(
|
||||
if (response_details.card_type !=
|
||||
AutofillClient::PaymentsRpcCardType::kVirtualCard) {
|
||||
// Currently we offer OTP authentication only for virtual cards.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
if (requester_) {
|
||||
requester_->OnOtpAuthenticationComplete(
|
||||
OtpAuthenticationResponse().with_result(
|
||||
|
@ -447,7 +447,7 @@ class CreditCardSaveManagerTest : public testing::Test {
|
||||
if (metric & (1 << sample))
|
||||
return sample;
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return 0;
|
||||
}
|
||||
};
|
||||
|
@ -129,7 +129,7 @@ void FullCardRequest::GetFullCardImpl(
|
||||
// failure and reset.
|
||||
if (card.record_type() == CreditCard::RecordType::kVirtualCard &&
|
||||
!last_committed_primary_main_frame_origin.has_value()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
if (ui_delegate_) {
|
||||
ui_delegate_->OnUnmaskVerificationResult(
|
||||
AutofillClient::PaymentsRpcResult::kVcnRetrievalPermanentFailure);
|
||||
@ -377,7 +377,7 @@ void FullCardRequest::OnDidGetRealPan(
|
||||
AutofillClient::PaymentsRpcCardType::kServerCard) {
|
||||
request_->card.set_record_type(CreditCard::RecordType::kFullServerCard);
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
// TODO(crbug.com/40621544): Once |fido_opt_in| is added to
|
||||
@ -398,7 +398,7 @@ void FullCardRequest::OnDidGetRealPan(
|
||||
}
|
||||
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@ -334,7 +334,7 @@ void LocalCardMigrationManager::OnDidMigrateLocalCards(
|
||||
MigratableCreditCard::MigrationStatus::SUCCESS_ON_UPLOAD);
|
||||
migrated_cards.push_back(card.credit_card());
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -1934,7 +1934,7 @@ class UpdateVirtualCardEnrollmentTest
|
||||
net::HTTP_REQUEST_TIMEOUT, "");
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
EXPECT_EQ(response_type_for_test, result_);
|
||||
@ -2075,7 +2075,7 @@ TEST_P(GetVirtualCardEnrollmentDetailsTest,
|
||||
net::HTTP_REQUEST_TIMEOUT, "");
|
||||
break;
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
EXPECT_EQ(result, result_);
|
||||
|
@ -109,7 +109,7 @@ std::string GetCardUploadDetailsRequest::GetRequestContent() {
|
||||
"LOCAL_CARD_MIGRATION_SETTINGS_PAGE");
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
std::string request_content;
|
||||
|
@ -61,7 +61,7 @@ std::string GetDetailsForEnrollmentRequest::GetRequestContent() {
|
||||
billable_service_number = kDownstreamEnrollBillableServiceNumber;
|
||||
break;
|
||||
case VirtualCardEnrollmentSource::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
context.Set("billable_service", billable_service_number);
|
||||
@ -89,7 +89,7 @@ std::string GetDetailsForEnrollmentRequest::GetRequestContent() {
|
||||
request_dict.Set("channel_type", "CHROME_DOWNSTREAM");
|
||||
break;
|
||||
case VirtualCardEnrollmentSource::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
|
||||
|
@ -73,7 +73,7 @@ TEST_P(GetDetailsForEnrollmentRequestTest, GetRequestContent) {
|
||||
channel_type = "CHROME_DOWNSTREAM";
|
||||
break;
|
||||
case VirtualCardEnrollmentSource::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
ASSERT_TRUE(false);
|
||||
break;
|
||||
}
|
||||
|
@ -59,7 +59,7 @@ std::string OptChangeRequest::GetRequestContent() {
|
||||
reason = "ADD_CARD_FOR_FIDO_AUTH";
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
request_dict.Set("reason", std::move(reason));
|
||||
|
@ -146,7 +146,7 @@ void ParseAsCvcChallengeOption(
|
||||
challenge_info_position_string = l10n_util::GetStringUTF16(
|
||||
IDS_AUTOFILL_CARD_UNMASK_PROMPT_SECURITY_CODE_POSITION_BACK_OF_CARD);
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
parsed_challenge_option->cvc_position = CvcPosition::kUnknown;
|
||||
}
|
||||
}
|
||||
@ -295,7 +295,7 @@ std::string UnmaskCardRequest::GetRequestContent() {
|
||||
cvc_position = "CVC_POSITION_BACK";
|
||||
break;
|
||||
case autofill::CvcPosition::kUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
challenge_option.Set("cvc_position", cvc_position);
|
||||
@ -438,7 +438,7 @@ void UnmaskCardRequest::ParseResponse(const base::Value::Dict& response) {
|
||||
response_details_.card_type =
|
||||
AutofillClient::PaymentsRpcCardType::kServerCard;
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
const base::Value::Dict* decline_details =
|
||||
|
@ -50,7 +50,7 @@ std::string UpdateVirtualCardEnrollmentRequest::GetRequestContent() {
|
||||
BuildUnenrollRequestDictionary(&request_dict);
|
||||
break;
|
||||
case VirtualCardEnrollmentRequestType::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
|
||||
@ -89,7 +89,7 @@ bool UpdateVirtualCardEnrollmentRequest::IsResponseComplete() {
|
||||
// error. Thus, we always return true.
|
||||
return true;
|
||||
case VirtualCardEnrollmentRequestType::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@ -127,7 +127,7 @@ void UpdateVirtualCardEnrollmentRequest::BuildEnrollRequestDictionary(
|
||||
request_dict->Set("channel_type", "CHROME_DOWNSTREAM");
|
||||
break;
|
||||
case VirtualCardEnrollmentSource::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
if (request_details_.billing_customer_number != 0) {
|
||||
|
@ -90,7 +90,7 @@ TEST_P(UpdateVirtualCardEnrollmentRequestTest, GetRequestContent) {
|
||||
channel_type = "CHROME_UPSTREAM";
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
EXPECT_TRUE(GetRequest()->GetRequestContent().find(
|
||||
billable_service_number) != std::string::npos);
|
||||
|
@ -63,7 +63,7 @@ VirtualCardEnrollmentBubbleSource ConvertToVirtualCardEnrollmentBubbleSource(
|
||||
features::kAutofillEnableVirtualCardEnrollMetricsLogger)) {
|
||||
NOTREACHED_NORETURN();
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return VirtualCardEnrollmentBubbleSource::
|
||||
VIRTUAL_CARD_ENROLLMENT_UNKNOWN_SOURCE;
|
||||
}
|
||||
|
@ -518,7 +518,7 @@ TEST_F(VirtualCardEnrollmentManagerTest, Enroll) {
|
||||
suffix = "SettingsPage";
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
// Verifies the logging.
|
||||
|
@ -379,7 +379,7 @@ void PaymentsDataManager::OnWebDataServiceRequestDone(
|
||||
OnMaskedBankAccountsRefreshed();
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
@ -1037,7 +1037,7 @@ bool PaymentsDataManager::IsKnownCard(const CreditCard& credit_card) const {
|
||||
}
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
@ -1676,7 +1676,7 @@ bool PaymentsDataManager::ShouldSuggestServerPaymentMethods() const {
|
||||
|
||||
void PaymentsDataManager::LoadCreditCards() {
|
||||
if (!database_helper_->GetLocalDatabase()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -1704,7 +1704,7 @@ void PaymentsDataManager::LoadCreditCardCloudTokenData() {
|
||||
|
||||
void PaymentsDataManager::LoadIbans() {
|
||||
if (!database_helper_->GetLocalDatabase()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
CancelPendingLocalQuery(&pending_local_ibans_query_);
|
||||
@ -1766,7 +1766,7 @@ void PaymentsDataManager::CancelPendingLocalQuery(
|
||||
WebDataServiceBase::Handle* handle) {
|
||||
if (*handle) {
|
||||
if (!database_helper_->GetLocalDatabase()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
database_helper_->GetLocalDatabase()->CancelRequest(*handle);
|
||||
@ -1778,7 +1778,7 @@ void PaymentsDataManager::CancelPendingServerQuery(
|
||||
WebDataServiceBase::Handle* handle) {
|
||||
if (*handle) {
|
||||
if (!database_helper_->GetServerDatabase()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
database_helper_->GetServerDatabase()->CancelRequest(*handle);
|
||||
|
@ -218,7 +218,7 @@ std::string RandomizedEncoder::Encode(FormSignature form_signature,
|
||||
std::string_view data_type,
|
||||
std::string_view data_value) const {
|
||||
if (!encoding_info_) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::string();
|
||||
}
|
||||
|
||||
|
@ -82,7 +82,7 @@ const std::u16string AutofillErrorDialogControllerImpl::GetTitle() {
|
||||
return l10n_util::GetStringUTF16(
|
||||
IDS_AUTOFILL_IBAN_UNMASK_ERROR_DIALOG_TITLE);
|
||||
case AutofillErrorDialogType::kTypeUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::u16string();
|
||||
}
|
||||
}
|
||||
@ -120,7 +120,7 @@ const std::u16string AutofillErrorDialogControllerImpl::GetDescription() {
|
||||
return l10n_util::GetStringUTF16(
|
||||
IDS_AUTOFILL_IBAN_UNMASK_ERROR_DIALOG_MESSAGE);
|
||||
case AutofillErrorDialogType::kTypeUnknown:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::u16string();
|
||||
}
|
||||
}
|
||||
|
@ -161,7 +161,7 @@ void CardUnmaskAuthenticationSelectionDialogControllerImpl::
|
||||
case CardUnmaskChallengeOptionType::kThreeDomainSecure:
|
||||
// TODO(crbug.com/41494927): Add kThreeDomainSecure logic.
|
||||
case CardUnmaskChallengeOptionType::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
@ -207,7 +207,7 @@ std::u16string CardUnmaskAuthenticationSelectionDialogControllerImpl::
|
||||
return l10n_util::GetStringUTF16(
|
||||
IDS_AUTOFILL_AUTHENTICATION_MODE_THREE_DOMAIN_SECURE);
|
||||
case CardUnmaskChallengeOptionType::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::u16string();
|
||||
}
|
||||
}
|
||||
@ -238,7 +238,7 @@ CardUnmaskAuthenticationSelectionDialogControllerImpl::GetOkButtonLabel()
|
||||
return l10n_util::GetStringUTF16(
|
||||
IDS_AUTOFILL_CARD_UNMASK_AUTHENTICATION_SELECTION_DIALOG_OK_BUTTON_LABEL_CONTINUE);
|
||||
case CardUnmaskChallengeOptionType::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::u16string();
|
||||
}
|
||||
}
|
||||
|
@ -77,7 +77,7 @@ void CardUnmaskOtpInputDialogControllerImpl::OnOtpVerificationResult(
|
||||
ShowInvalidState(result);
|
||||
break;
|
||||
case OtpUnmaskResult::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
@ -218,7 +218,7 @@ void CardUnmaskOtpInputDialogControllerImpl::ShowInvalidState(
|
||||
case OtpUnmaskResult::kSuccess:
|
||||
case OtpUnmaskResult::kPermanentFailure:
|
||||
case OtpUnmaskResult::kUnknownType:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -126,7 +126,7 @@ void CardUnmaskPromptControllerImpl::OnVerificationResult(
|
||||
}
|
||||
|
||||
case AutofillClient::PaymentsRpcResult::kNone:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
|
@ -242,7 +242,7 @@ optional<ModelError>
|
||||
AutofillProfileInitialSyncDifferenceTracker::IncorporateRemoteDelete(
|
||||
const std::string& storage_key) {
|
||||
// Remote delete is not allowed in initial sync.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return std::nullopt;
|
||||
}
|
||||
|
||||
|
@ -323,7 +323,7 @@ int AutocompleteTable::GetCountOfValuesContainedBetween(base::Time begin,
|
||||
s.BindInt64(1, end_time_t);
|
||||
|
||||
if (!s.Step()) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
return s.ColumnInt(0);
|
||||
|
@ -58,7 +58,7 @@ std::string GetClientTagForSpecificsId(WalletMetadataSpecifics::Type type,
|
||||
case WalletMetadataSpecifics::IBAN:
|
||||
return "iban-" + specifics_id;
|
||||
case WalletMetadataSpecifics::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "";
|
||||
}
|
||||
}
|
||||
@ -101,7 +101,8 @@ TypeAndMetadataId ParseWalletMetadataStorageKey(
|
||||
int type_int;
|
||||
std::string specifics_id;
|
||||
if (!iterator.ReadInt(&type_int) || !iterator.ReadString(&specifics_id)) {
|
||||
NOTREACHED() << "Unsupported storage_key provided " << storage_key;
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< "Unsupported storage_key provided " << storage_key;
|
||||
}
|
||||
|
||||
TypeAndMetadataId parsed;
|
||||
@ -247,7 +248,7 @@ bool AddServerMetadata(PaymentsAutofillTable* table,
|
||||
// ADDRESS metadata syncing is deprecated.
|
||||
case WalletMetadataSpecifics::ADDRESS:
|
||||
case WalletMetadataSpecifics::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@ -263,7 +264,7 @@ bool RemoveServerMetadata(PaymentsAutofillTable* table,
|
||||
// ADDRESS metadata syncing is deprecated.
|
||||
case WalletMetadataSpecifics::ADDRESS:
|
||||
case WalletMetadataSpecifics::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@ -279,7 +280,7 @@ bool UpdateServerMetadata(PaymentsAutofillTable* table,
|
||||
// ADDRESS metadata syncing is deprecated.
|
||||
case WalletMetadataSpecifics::ADDRESS:
|
||||
case WalletMetadataSpecifics::UNKNOWN:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
@ -27,7 +27,7 @@ const char* LogMessageToString(LogMessage message) {
|
||||
// Clean up.
|
||||
#undef AUTOFILL_TEMPLATE
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "";
|
||||
}
|
||||
|
||||
@ -48,7 +48,7 @@ const char* LogMessageValue(LogMessage message) {
|
||||
// Clean up.
|
||||
#undef AUTOFILL_TEMPLATE
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "";
|
||||
}
|
||||
|
||||
|
@ -27,7 +27,7 @@ const char* LoggingScopeToString(LoggingScope scope) {
|
||||
// Clean up.
|
||||
#undef AUTOFILL_TEMPLATE
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "";
|
||||
}
|
||||
|
||||
|
@ -173,7 +173,7 @@ SubmissionIndicatorEvent ToSubmissionIndicatorEvent(SubmissionSource source) {
|
||||
return SubmissionIndicatorEvent::DOM_MUTATION_AFTER_AUTOFILL;
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return SubmissionIndicatorEvent::NONE;
|
||||
}
|
||||
|
||||
|
@ -109,7 +109,7 @@ std::string_view FieldTypeToStringView(HtmlFieldType type) {
|
||||
return "HTML_TYPE_UNRECOGNIZED";
|
||||
}
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "";
|
||||
}
|
||||
|
||||
@ -126,7 +126,7 @@ std::string_view HtmlFieldModeToStringView(HtmlFieldMode mode) {
|
||||
case HtmlFieldMode::kShipping:
|
||||
return "shipping";
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return "";
|
||||
}
|
||||
|
||||
|
@ -83,7 +83,7 @@ UnionTraits<autofill::mojom::SectionValueDataView,
|
||||
if (absl::holds_alternative<autofill::Section::FieldIdentifier>(r))
|
||||
return autofill::mojom::SectionValueDataView::Tag::kFieldIdentifier;
|
||||
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return autofill::mojom::SectionValueDataView::Tag::kDefaultSection;
|
||||
}
|
||||
|
||||
|
@ -457,7 +457,8 @@ std::string SavePasswordProgressLogger::GetStringFromID(
|
||||
return "INVALID";
|
||||
// Intentionally no default: clause here -- all IDs need to get covered.
|
||||
}
|
||||
NOTREACHED(); // Win compilers don't believe this is unreachable.
|
||||
NOTREACHED_IN_MIGRATION(); // Win compilers don't believe this is
|
||||
// unreachable.
|
||||
return std::string();
|
||||
}
|
||||
|
||||
|
@ -419,8 +419,8 @@ constexpr CGFloat kSuggestionIconWidth = 32;
|
||||
autofillManager->OnUserAcceptedCardsFromAccountOption();
|
||||
}
|
||||
} else {
|
||||
NOTREACHED() << "unknown identifier "
|
||||
<< base::to_underlying(suggestion.popupItemId);
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< "unknown identifier " << base::to_underlying(suggestion.popupItemId);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -201,7 +201,7 @@ JobDetails* BackgroundFetchDelegateBase::GetJobDetails(
|
||||
auto job_details_iter = job_details_map_.find(job_id);
|
||||
if (job_details_iter == job_details_map_.end()) {
|
||||
if (!allow_null)
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
|
||||
return nullptr;
|
||||
}
|
||||
@ -394,12 +394,12 @@ void BackgroundFetchDelegateBase::OnDownloadReceived(
|
||||
break;
|
||||
case StartResult::BACKOFF:
|
||||
// TODO(delphick): try again later?
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
case StartResult::UNEXPECTED_CLIENT:
|
||||
// This really should never happen since we're supplying the
|
||||
// DownloadClient.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
case StartResult::CLIENT_CANCELLED:
|
||||
// TODO(delphick): do we need to do anything here, since we will have
|
||||
@ -407,10 +407,10 @@ void BackgroundFetchDelegateBase::OnDownloadReceived(
|
||||
break;
|
||||
case StartResult::INTERNAL_ERROR:
|
||||
// TODO(delphick): We need to handle this gracefully.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
case StartResult::COUNT:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@ -19,5 +19,5 @@ void BackgroundSyncPermissionContext::DecidePermission(
|
||||
permissions::PermissionRequestData request_Data,
|
||||
permissions::BrowserPermissionCallback callback) {
|
||||
// The user should never be prompted to authorize background sync.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
@ -100,7 +100,7 @@ std::u16string PopupBlockedInfoBarDelegate::GetButtonLabel(
|
||||
case BUTTON_CANCEL:
|
||||
return l10n_util::GetStringUTF16(IDS_PERMISSION_DENY);
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
}
|
||||
return std::u16string();
|
||||
|
@ -132,7 +132,7 @@ void PopupBlockerTabHelper::ShowBlockedPopup(
|
||||
|
||||
switch (popup->block_type) {
|
||||
case PopupBlockType::kNotBlocked:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
break;
|
||||
case PopupBlockType::kNoGesture:
|
||||
LogAction(Action::kClickedThroughNoGesture);
|
||||
|
@ -31,7 +31,7 @@ bool BookmarkClient::SupportsTypedCountForUrls() {
|
||||
|
||||
void BookmarkClient::GetTypedCountForUrls(
|
||||
UrlTypedCountMap* url_typed_count_map) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
} // namespace bookmarks
|
||||
|
@ -256,13 +256,13 @@ bool BookmarkCodec::DecodeNode(const base::Value::Dict& value,
|
||||
// If no |node| is specified, we'll create one and add it to the |parent|.
|
||||
// Therefore, in that case, |parent| must be non-NULL.
|
||||
if (!node && !parent) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
// It's not valid to have both a node and a specified parent.
|
||||
if (node && parent) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -652,7 +652,7 @@ void BookmarkModel::SetTitle(const BookmarkNode* node,
|
||||
}
|
||||
|
||||
if (is_permanent_node(node) && !client_->CanSetPermanentNodeTitle(node)) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
|
@ -363,7 +363,7 @@ class BookmarkModelTest : public testing::Test, public BookmarkModelObserver {
|
||||
|
||||
void BookmarkModelLoaded(bool ids_reassigned) override {
|
||||
// We never load from the db, so that this should never get invoked.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
void BookmarkNodeMoved(const BookmarkNode* old_parent,
|
||||
|
@ -10,16 +10,16 @@ namespace bookmarks {
|
||||
|
||||
// static
|
||||
bool BookmarkNodeData::ClipboardContainsBookmarks() {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
void BookmarkNodeData::WriteToClipboard(bool is_off_the_record) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
bool BookmarkNodeData::ReadFromClipboard(ui::ClipboardBuffer buffer) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -244,7 +244,7 @@ void CloneBookmarkNode(BookmarkModel* model,
|
||||
size_t index_to_add_at,
|
||||
bool reset_node_times) {
|
||||
if (!parent->is_folder() || !model) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
for (size_t i = 0; i < elements.size(); ++i) {
|
||||
@ -310,7 +310,7 @@ void MakeTitleUnique(const BookmarkModel* model,
|
||||
return;
|
||||
}
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
void PasteFromClipboard(BookmarkModel* model,
|
||||
|
@ -177,7 +177,7 @@ bool ManagedBookmarksTracker::LoadBookmark(const base::Value::List& list,
|
||||
const base::Value::Dict* dict = list[index].GetIfDict();
|
||||
if (!dict) {
|
||||
// Should never happen after policy validation.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
const std::string* name = dict->FindString(kName);
|
||||
@ -185,7 +185,7 @@ bool ManagedBookmarksTracker::LoadBookmark(const base::Value::List& list,
|
||||
const base::Value::List* children_list = dict->FindList(kChildren);
|
||||
if (!name || (!spec && !children_list)) {
|
||||
// Should never happen after policy validation.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -906,7 +906,8 @@ static void JNI_WebsitePreferenceBridge_SetContentSettingEnabled(
|
||||
value = CONTENT_SETTING_ALLOW;
|
||||
break;
|
||||
default:
|
||||
NOTREACHED() << static_cast<int>(type); // Not supported on Android.
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< static_cast<int>(type); // Not supported on Android.
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -101,7 +101,8 @@ BrowsingDataModel::DataOwner GetDataOwner::GetOwningOriginOrHost<url::Origin>(
|
||||
return GetOwnerBasedOnScheme(data_key);
|
||||
}
|
||||
|
||||
NOTREACHED() << "Unexpected StorageType: " << static_cast<int>(storage_type_);
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< "Unexpected StorageType: " << static_cast<int>(storage_type_);
|
||||
return "";
|
||||
}
|
||||
|
||||
@ -119,8 +120,8 @@ GetDataOwner::GetOwningOriginOrHost<blink::StorageKey>(
|
||||
case BrowsingDataModel::StorageType::kCdmStorage:
|
||||
return GetOwnerBasedOnScheme(data_key.origin());
|
||||
default:
|
||||
NOTREACHED() << "Unexpected StorageType: "
|
||||
<< static_cast<int>(storage_type_);
|
||||
NOTREACHED_IN_MIGRATION()
|
||||
<< "Unexpected StorageType: " << static_cast<int>(storage_type_);
|
||||
return "";
|
||||
}
|
||||
}
|
||||
@ -350,7 +351,7 @@ void StorageRemoverHelper::Visitor::operator()<
|
||||
->ClearSharedDictionaryCacheForIsolationKey(
|
||||
isolation_key, helper->GetCompleteCallback());
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
@ -372,7 +373,7 @@ void StorageRemoverHelper::Visitor::operator()<net::CanonicalCookie>(
|
||||
bool deleted) { std::move(callback).Run(); },
|
||||
helper->GetCompleteCallback()));
|
||||
} else {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -136,7 +136,7 @@ void BrowsingDataQuotaHelperImpl::GotStorageKeyUsage(
|
||||
(*quota_info)[storage_key].syncable_usage += usage;
|
||||
break;
|
||||
default:
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -25,5 +25,5 @@ void FakeBrowsingDataModel::RemoveBrowsingDataEntriesFromDisk(
|
||||
|
||||
void FakeBrowsingDataModel::PopulateFromDisk(
|
||||
base::OnceClosure finished_callback) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user